Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace namespaces robot_state and robot_model with moveit::core #1924

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

ayushgargdroid
Copy link
Contributor

Description

Fixes issue #1878.
Using moveit::core namespace instead of robot_state and robot_model namespaces.

These namespaces acted as aliases for backward compatibility defined here.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov-io
Copy link

Codecov Report

Merging #1924 into master will decrease coverage by 0.02%.
The diff coverage is 56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage   50.28%   50.26%   -0.03%     
==========================================
  Files         313      313              
  Lines       24647    24647              
==========================================
- Hits        12394    12389       -5     
- Misses      12253    12258       +5
Impacted Files Coverage Δ
...moveit/move_group_interface/move_group_interface.h 36.84% <ø> (ø) ⬆️
...it/collision_distance_field/collision_env_hybrid.h 0% <ø> (ø) ⬆️
...e/moveit/robot_interaction/kinematic_options_map.h 0% <ø> (ø) ⬆️
...parameterization/model_based_state_space_factory.h 100% <ø> (ø) ⬆️
...n_distance_field/collision_common_distance_field.h 93.33% <ø> (ø) ⬆️
...eit/planning_scene_monitor/current_state_monitor.h 0% <ø> (ø) ⬆️
...rc/default_capabilities/move_action_capability.cpp 38.88% <ø> (ø) ⬆️
...ude/moveit/robot_interaction/interaction_handler.h 0% <ø> (ø) ⬆️
...g_scene_interface/src/planning_scene_interface.cpp 1.23% <ø> (ø) ⬆️
...eit/constraint_samplers/union_constraint_sampler.h 12.5% <ø> (ø) ⬆️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a4072...56be68f. Read the comment docs.

@rhaschke rhaschke merged commit ba4b60e into moveit:master Mar 3, 2020
@welcome
Copy link

welcome bot commented Mar 3, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@ayushgargdroid ayushgargdroid deleted the fixNamespace branch March 3, 2020 19:36
@tylerjw tylerjw mentioned this pull request May 8, 2020
20 tasks
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants