Support for video embedding#550
Conversation
|
Thanks a lot for putting in the effort! I love that the video seems to work, and I don't mind the file living in I'm not familiar with the build process, so I'm not sure what you mean by |
|
I am just learning my way around sphinx. There seems like there should be a way to link to the released extension simply by adding |
|
I don't know myself, but you can probably try what works in a |
|
I'll just mention, one of the tutorials already has an embedded Youtube video. https://ros-planning.github.io/moveit_tutorials/doc/realtime_servo/realtime_servo_tutorial.html |
|
I've updated this so that the video loops forever like a gif would. When I built it locally using the |
|
I believe CI would pass for this now that #556 is merged. |
|
Closing and reopening to trigger CI. |
davetcoleman
left a comment
There was a problem hiding this comment.
Seems like this has been greatly simplified, for better or worse :-)
|
@DLu this is probably worth adding to the repo README on best practice for embedding video/gif, so we don't go through this again |
* Support for video embedding * Remove video dependency in favor of raw html * Loop=true * Update default text
Description
Based on feedback in #546, I spun the video embedding out into this PR, which
Copies the source code from sphinx-contrib/video directly. I was unable to figure out the proper way to install a dependency on the upstream extension.because the above extension doesn't seem to copy it to the destination folder like the image extension does.~Its not the most elegant solution, but it works. I welcome feedback on how to make it more elegant. ~
Checklist