Conversation
If the grid has standard ordering we leave it alone.
HYCOM and BGC coupling
…rate thermo_timestep doesn't make sense, so I'm removing it.
Remove thermo_timestep
…to get at coupler.exchange_grid_file.
Add SST and SSS to the list of available moorings (issue #454)
…rror Output the name and longName of moorings (issue #456).
This reverts commit ee98a16.
…stic Conflicts: model/finiteelement.cpp
…_melted_diagnostic Issue 329 adding ice volume melted diagnostic
…r_depth].as<bool>() when initialising the DataSet class.
… toETOPO_Arctic_2arcmin.nc)
…o only Mohr-Coulomb.
… thing that both works and makes sense.
…through relaxation.
#536 simplify dockerfile and readme
Bug check angles
Make the page hierarchy cleaner, use standard GitHub Markdown syntax, use code blocks for sets of commands.
Issue 541: Tidy README.md
Make snow conductivity an option
I've changed the default values of C_lab and compression_factor to match that of the BBM paper. See also issue #544.
Change C_lab and compression_factor defaults
We want to change the name of the "thin ice" class to "young ice". This makes more sense, physically, and is more in line with the general nomenclature (also WMO). Here we only change the name of variables (both in the code and in output) - no physics or numerics changes.
Change name of thin ice class to young ice
tdcwilliams
approved these changes
Aug 6, 2021
Contributor
tdcwilliams
left a comment
tdcwilliams
left a comment
There was a problem hiding this comment.
Looks great - a lot of good work in this one
tdcwilliams
added a commit
that referenced
this pull request
Mar 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge develop into master and update to neXtSIM 2.0.0
Main change here is the introduction of BBM and removal of MEB.
Lots of other smaller changes - most importantly perhaps we now call the "thin ice" class "young ice".