Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add fix for msbuild errors on windows #1657

Closed
wants to merge 63 commits into from

Commits on Jun 6, 2017

  1. Upgrade to tar v3

    Tar version 3 performs better and is more well tested than its
    predecessor.  npm will be using this in the near future, so there is no
    benefit in shipping a node-gyp that uses the slower and less reliable
    fstream-based tar.
    
    This drops support for node 0.x, and thus should be considered a
    breaking semver-major change.
    
    PR-URL: nodejs#1212
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    isaacs authored and refack committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    5f924ce View commit details
    Browse the repository at this point in the history
  2. bump to v4.0.0

    * dropping support for node < 4
    * signal the CI not to test node < 4
    refack committed Jun 6, 2017
    4 Configuration menu
    Copy the full SHA
    75cfae2 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2017

  1. configure: don't set ensure if tarball is set

    If you're providing a path to a header tarball to install, you probably
    want it to always be re-installed.
    
    PR-URL: nodejs#1220
    Fixes: nodejs#1216
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    gibfahn committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    c84a541 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2017

  1. gyp: update xml string encoding conversion

    * test: build simple addon in path with non-ascii characters
    * test: add test-charmap.py
    
    PR-URL: nodejs#1203
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    lc-soft authored and refack committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    d6139b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2017

  1. doc: headerify the Install instructions

    Enable linking to the platform specific installation instructions
    
    PR-URL: nodejs#1225
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    nschonni authored and refack committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    35e1dbb View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2017

  1. doc: update proposed DCO and CoC

    Lifted verbatim from
    https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
    then `s/Node.js/node-gyp/`.
    
    PR-URL: nodejs#1229
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    mikeal authored and gibfahn committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    2e40fad View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2017

  1. doc: add github PR and Issue templates

    Give users reporting bugs a clearer idea of the info that will be
    helpful when reporting issues.
    
    PR-URL: nodejs#1228
    Refs: https://github.com/nodejs/node/tree/master/.github
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    gibfahn committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    7245415 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2017

  1. win: run PS with -NoProfile

    PR-URL: nodejs#1292
    Refs: nodejs#1195 (comment)
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    refack committed Sep 19, 2017
    1 Configuration menu
    Copy the full SHA
    63f43c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. zos: support platform

    Initial work to add z/OS support to node-gyp.
    
    
    PR-URL: nodejs#1276
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jBarz authored and gibfahn committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    a8ba528 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2017

  1. Fix IndexError when parsing GYP files.

    GYP automatically turns variables ending in _dir, _file or _path into
    absolute paths but didn't check for empty strings.
    
    It interacted badly with variables inherited through the environment
    from npm, the `scripts-prepend-node-path=false` setting in particular
    because it is turned into `npm_config_script_prepend_node_path=`.
    
    Fixes: nodejs#1217
    PR-URL: nodejs#1267
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    bnoordhuis committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    05d2002 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2018

  1. Configuration menu
    Copy the full SHA
    6b68b60 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Update --nodedir description in README.

    The description erroneously stated that it should point the node binary.
    It needs to point to the node source code.
    
    PR-URL: nodejs#1372
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    bnoordhuis committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    57279a2 View commit details
    Browse the repository at this point in the history
  2. Fix infinite install loop.

    Retry the download+install dance only once after encountering an EACCES.
    
    That only happens when both the devdir (usually: `$HOME/.node-gyp`) and
    the current working directory aren't writable.  Users won't often hit
    that except through `sudo npm install` because npm drops privileges
    before executing node-gyp.
    
    Fixes: nodejs#1383
    PR-URL: nodejs#1384
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    bnoordhuis committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    8b7ccfe View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. gyp: don't print xcodebuild not found errors

    As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be
    printing the error every time GYP is run.
    
    PR-URL: nodejs#1370
    Fixes: nodejs#569
    Refs: nodejs#1057
    Refs: https://chromium-review.googlesource.com/c/492046/
    gibfahn committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    3a52936 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. doc: update macOS information in README

    PR-URL: nodejs#1323
    Fixes: nodejs#1295
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    josh- authored and maclover7 committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    91789c2 View commit details
    Browse the repository at this point in the history
  2. gyp: fix regex to match multi-digit versions

    This fixes the regular expression matching in `xcode_emulation`
    to also handle version numbers with multiple-digit major versions
    which would otherwise break under use of XCode 10
    
    Fixes: nodejs#1454
    PR-URL: nodejs#1455
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jhermsmeier authored and bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    293092c View commit details
    Browse the repository at this point in the history
  3. zos: add search locations for libnode.x

    Node.js on z/OS uses shared dll (libnode.so). When linking native
    addons, node-gyp needs to find the corresponding libnode.x during
    the link step.
    
    PR-URL: nodejs#1451
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    jBarz authored and bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    02ac2e7 View commit details
    Browse the repository at this point in the history
  4. zos: don't use universal-new-lines mode

    PR-URL: nodejs#1451
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    jBarz authored and bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    eaedc12 View commit details
    Browse the repository at this point in the history
  5. gyp: add support for .mm files to msvs generator

    PR-URL: nodejs#1167
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jracle authored and bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    206309e View commit details
    Browse the repository at this point in the history
  6. Prefix build targets with /t: on Windows

    Currently, on non-Windows platforms, it is possible to have
    a multi-target native module and specify building just some
    of the targets using `node-gyp build my_target`.
    
    On Windows, however, specifying the targets to build requires the `/t:`
    or `/target:` flag. Without this change you will get an `MSB1008` error
    because MSBuild thinks you are trying to specify multiple solutions.
    
    PR-URL: nodejs#1164
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    NatalieWolfe authored and bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    4379c47 View commit details
    Browse the repository at this point in the history
  7. Fix include path when pointing to Node.js source

    Header files for deps are in a different location in the Node.js
    source tree compared to the release tarballs.
    
    PR-URL: nodejs#1055
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    richardlau authored and bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    fbecb38 View commit details
    Browse the repository at this point in the history
  8. Drop dependency on minimatch.

    PR-URL: nodejs#1158
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    doowb authored and bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    d70513a View commit details
    Browse the repository at this point in the history
  9. gyp: escape spaces in filenames in make generator

    PR-URL: nodejs#1436
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Jeff Senn authored and bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    1cf636b View commit details
    Browse the repository at this point in the history
  10. Remove unused gyp test scripts.

    Shrinks node-gyp's size by about 100 kB.
    
    PR-URL: nodejs#1458
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    bnoordhuis committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    50b8734 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. doc: lint README.md

    Fixes grammar, removes extra lines and spaces, etc. Also removes a few
    references to `node-waf`, which was removed ~6 years ago now. Happy to
    add back if people still need that information.
    
    PR-URL: nodejs#1498
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    maclover7 committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    c5e9802 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2018

  1. bin,lib: remove extra comments/lines/spaces

    - Removes "module dependencies" comments and things that, IMHO, don't add
    too much value. Happy to add back if helps some people when reading
    through `node-gyp`.
    - DRY up `lib/process-release.js`.
    - Removes a bunch of extra blank lines, as well as random spaces.
    
    PR-URL: nodejs#1508
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    maclover7 committed Jul 28, 2018
    Configuration menu
    Copy the full SHA
    6b0f4ae View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Add ESLint no-unused-vars rule

    - Uses `.eslintrc.yaml` for configuration
    - `npm run lint` is part of `npm test`
    
    PR-URL: nodejs#1497
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
    maclover7 committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    b2e5cf0 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2018

  1. win: improve parsing of SDK version

    This makes the parsing more robust and fixes the additional issue
    related to USB Device Connectivity component.
    
    Fixes: nodejs#1466
    PR-URL: nodejs#1516
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Loghorn authored and joaocgreis committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    25208f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2018

  1. configure: use sys.version_info to get python version

    This is cleaner than filtering additional strings from
    platform.python_version().
    
    PR-URL: nodejs#1504
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    hashseed authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    da5db40 View commit details
    Browse the repository at this point in the history
  2. doc: fix visual studio links

    Fixes: nodejs#1472
    PR-URL: nodejs#1490
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    bzoz authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    1309efb View commit details
    Browse the repository at this point in the history
  3. doc: update link to commit guidelines

    This updates the link to the commit guidelines in the
    `PULL_REQUEST_TEMPLATE.md`, as they have moved from the
    `CONTRIBUTING.md` to `doc/guides/contributing/pull-requests.md`
    
    PR-URL: nodejs#1456
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    jhermsmeier authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    a0cf9d5 View commit details
    Browse the repository at this point in the history
  4. doc: update Xcode preferences tab name.

    PR-URL: nodejs#1330
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    divan authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    d9ee0ea View commit details
    Browse the repository at this point in the history
  5. deps: pin request version range

    Required for "node < 4" compatibility and is congruent with `npm`
    
    minimum for passing `npm test` >= 2.9.0
    setting < 2.82.0 allows deduping
    
    PR-URL: nodejs#1300
    Fixes: nodejs#1299
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    refack authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    fb2d3a2 View commit details
    Browse the repository at this point in the history
  6. deps: bump request to 2.8.7, fixes heok/hawk issues

    PR-URL: nodejs#1492
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Matheus Marchini <matheus@sthima.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Rohithzr authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    baa0616 View commit details
    Browse the repository at this point in the history
  7. test: added test/processExecSync.js for when execFileSync is not avai…

    …lable.
    
    PR-URL: nodejs#1492
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Matheus Marchini <matheus@sthima.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Rohithzr authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    eb78b5a View commit details
    Browse the repository at this point in the history
  8. test: formatting and minor fixes for execFileSync replacement

    PR-URL: nodejs#1521
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    877b83b View commit details
    Browse the repository at this point in the history
  9. gyp: backport GYP fix to fix AIX shared suffix

    Required to support the shared library builds on AIX - this sets the
    shared library suffix within GYP to .a instead of .so on AIX
    My patch: https://codereview.chromium.org/2492233002/ was landed as
    as part of this one which fixed some other (not required, but
    included for completeness of the backport) changes:
    
    PR-URL: https://github.com/nodejs/node/pull9675
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Ref: https://codereview.chromium.org/2511733005/
    Stewart Addison authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    8ad9ecd View commit details
    Browse the repository at this point in the history
  10. gyp: float gyp patch for long filenames

    Pulling in https://codereview.chromium.org/2019133002/ in its current
    state, as gyp seems to be largely abandoned as a project.
    
    Original commit message:
    
        Hash intermediate file name to avoid ENAMETOOLONG
    
        Hash the intermediate Makefile target used for multi-output rules
        so that it still works when the involved file names are very long.
    
        Since the intermediate file's name is effectively arbitrary, this
        does not come with notable behavioural changes.
    
        The `import hashlib` boilerplate is taken directly
        from `xcodeproj_file.py`.
    
    Concretely, this makes the V8 inspector build currently fail when long
    pathnames are involved, notably when using ecryptfs which has a lower
    file name length limit.
    
    Fixes: nodejs/node#7959
    Ref: nodejs/node#7510
    PR-URL: nodejs/node#7963
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
    addaleax authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    a265040 View commit details
    Browse the repository at this point in the history
  11. gyp: add compile_commands.json gyp generator

    this is a re-base of the gyp part of
    3c46bb9931ecea71167342322e09121ee48cde8e
    after bumping GYP version to
    https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161
    
    Original-Review-By: James M Snell <jasnell@gmail.com>
    Ref: nodejs/node#7986
    PR-URL: nodejs/node#12450
    Reviewed-By: João Reis <reis@janeasystems.com>
    bnoordhuis authored and rvagg committed Aug 9, 2018
    1 Configuration menu
    Copy the full SHA
    5c2aad8 View commit details
    Browse the repository at this point in the history
  12. gyp: enable cctest to use objects (gyp part)

    this is a re-base of the gyp part of
    6a09a69ec9d36b705e9bde2ac1a193566a702d96
    after bumping GYP version to
    https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161
    
    Original-PR-URL: nodejs/node#11956
    Original-Ref: nodejs/node#9163
    Original-Reviewed-By: James M Snell <jasnell@gmail.com>
    
    PR-URL: nodejs/node#12450
    Reviewed-By: João Reis <reis@janeasystems.com>
    danbev authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    6ffef51 View commit details
    Browse the repository at this point in the history
  13. gyp: implement LD/LDXX for ninja and FIPS

    The ability to set the link rule is used for FIPS, and needs to set
    both the `ld =` and `ldxx =` variables in the ninja build file to link
    c++ (node) and c (openssl-cli, etc.) executables.
    
    URL: nodejs/node#14227
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sam-github authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    f739c18 View commit details
    Browse the repository at this point in the history
  14. tools: fix "the the" typos in comments

    PR-URL: nodejs/node#20716
    Fixes: nodejs/node#20682
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Masashi Hirano authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    d8eac7a View commit details
    Browse the repository at this point in the history
  15. tools: patch gyp to avoid xcrun errors

    Previously running ./configure with only the Xcode Command Line Tools
    installed would give:
    
    xcrun: error: unable to lookup item 'PlatformPath' from command line tools installation
    xcrun: error: unable to lookup item 'PlatformPath' in SDK '/'
    
    Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
    Fixes: nodejs/node#12531
    
    PR-URL: nodejs/node#21520
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ryzokuken authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    eebc8f6 View commit details
    Browse the repository at this point in the history
  16. gyp: fix ninja build failure (GYP patch)

    Currently the files specified in libraries in node.gyp `cctest` target are
    getting a '.lib' extension on windows when generated with ninja.
    This commit adds a check to see if a file has a '.obj' extension and in
    that case no '.lib' extension will be added.
    
    Also, the LIBS specified in the 'libraries' section are not
    being included in the --start-group --end-group section which
    means that these libraries will not be searched causing issue
    with linkers where the order matters.
    
    PR-URL: nodejs/node#12484
    Fixes: nodejs/node#12448
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    danbev authored and rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    2ca32e0 View commit details
    Browse the repository at this point in the history
  17. doc: update changelog

    rvagg committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    bac9e44 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2018

  1. test: remove unused variable

    This fixes linting.
    
    nodejs#1561
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    joaocgreis authored and refack committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    3481739 View commit details
    Browse the repository at this point in the history
  2. gyp: get ready for python 3

    nodejs#1335
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    cclauss authored and refack committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    c9276f3 View commit details
    Browse the repository at this point in the history
  3. gyp: use print as a function, as specified in PEP 3105.

    nodejs#1150
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    rodrigc authored and refack committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    73b5b63 View commit details
    Browse the repository at this point in the history
  4. gyp: replace deprecated functions

    * assertEquals() with assertEqual()
    * iteritems() with items() for Python 3.
    * xrange() with range() for Python 3.
    
    nodejs#1150
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    rodrigc authored and refack committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    3321444 View commit details
    Browse the repository at this point in the history
  5. gyp: replace basestring with str, but only on Python 3.

    On Python 2, basestring is (unicode, str).
    On Python 3, basestring and unicode are gone, and there is only str.
    rodrigc authored and refack committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    9eb9b39 View commit details
    Browse the repository at this point in the history
  6. gyp: _winreg module was renamed to winreg in Python 3.

    nodejs#1150
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    rodrigc authored and refack committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    ef8b60a View commit details
    Browse the repository at this point in the history
  7. gyp: fix sntex error

    PR-URL: nodejs#1333
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    cclauss authored and refack committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    ae0be87 View commit details
    Browse the repository at this point in the history
  8. gyp: fix target --> self.target

    target is an undefined name in this context.
    
    nodejs#1334
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    cclauss authored and refack committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    2394a1e View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2018

  1. deps: replace osenv dependency with native os

    Breaking change: needs Node.js version 6 or higher
    
    nodejs#1570
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Siilwyn authored and refack committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    1ef7709 View commit details
    Browse the repository at this point in the history
  2. bin: follow XDG OS conventions for storing data

    PR-URL: nodejs#1570
    Fixes: nodejs#175
    Fixes: nodejs#1124
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Siilwyn authored and refack committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    2b5ce52 View commit details
    Browse the repository at this point in the history
  3. lib: use print() for python version detection

    PR-URL: nodejs#1534
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    greenaddress authored and refack committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    aebdd7a View commit details
    Browse the repository at this point in the history
  4. tools: fix usage of inherited -fPIC and -fPIE

    PR-URL: nodejs#1340
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    arrkiin authored and refack committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    e2401e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. win: fix delay-load hook for electron 4

    PR-URL: nodejs#1566
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    adill authored and refack committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    3fcddce View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. python: more informative error

    PR-URL: nodejs#1269
    Refs: nodejs#1582
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: João Reis <reis@janeasystems.com>
    refack authored and joaocgreis committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    6b7c8e6 View commit details
    Browse the repository at this point in the history
  2. python: clean-up detection

    Try everything until Python is found.
    
    PR-URL: nodejs#1582
    Reviewed-By: Rod Vagg <rod@vagg.org>
    joaocgreis committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    a6990ad View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. doc: python info needs own header

    PR-URL: nodejs#1245
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Taylor D. Lee authored and refack committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    9dee52f View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. doc: improve issue template

    Suggest using --verbose npm switch when providing logs. Hopefully,
    better direct users to use backticks correctly.
    
    PR-URL: nodejs#1618
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    bzoz authored and joaocgreis committed Dec 19, 2018
    1 Configuration menu
    Copy the full SHA
    53b6074 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Configuration menu
    Copy the full SHA
    fa8b5c8 View commit details
    Browse the repository at this point in the history