Conversation
The superBrl braille display driver includes escape sequences which produce non-ASCII characters; e.g. "\xff". Due to a gettext bug, this causes xgettext to fail even though these aren't in translatable strings. See #2592 (comment). 1. To work around this, declare encoding as UTF-8 for the superBrl driver. 2. Make AppVeyor build the translation template so that builds fail for problems like this. This way, we learn about such problems long before they get to the translation system. 3. Explicitly exclude source\comInterfaces for scons pot to avoid unknown encoding warnings. These files never contain translatable strings anyway.
Contributor
Author
|
P1 because this breaks translation. |
michaelDCurran
approved these changes
Jul 20, 2017
Collaborator
|
Would it be an idea to also add the pot generation to scons tests? This
will allow one to see with testing whether there's a regression in pot
generation.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes regression introduced by #7352.
Summary of the issue:
The translation system failed to build a translation template due to the superBrl driver.
Description of how this pull request fixes the issue:
The superBrl braille display driver includes escape sequences which produce non-ASCII characters; e.g. "\xff". Due to a gettext bug, this causes xgettext to fail even though these aren't in translatable strings. See #2592 (comment).
I also updated the Contributing document to mention the need for an encoding declaration in this case.
Testing performed:
scons potsucceeded.Known issues with pull request:
None.
Change log entry:
None needed.
Merge notes:
This should be merged straight to master. Once done, a mergePot job should be manually triggered on the translation system, since the scheduled job failed.