Inform about SSL changes #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-sslchange event on webview incoked when SSL state changed.
# Conflicts: # DEPS # chrome/browser/file_select_helper.cc # extensions/renderer/render_frame_observer_natives.cc
rogerwang
force-pushed
the
nw13
branch
6 times, most recently
from
80b6452
to
85c8bc4
Compare
rogerwang
force-pushed
the
nw13
branch
3 times, most recently
from
dc5c466
to
803ab01
Compare
rogerwang
force-pushed
the
nw13
branch
3 times, most recently
from
114f968
to
f581ec8
Compare
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
* Workaround font rendering issue in Hindi by adding padding to the end of the text. * Fix incorrect order-of-operations in the calculation for title width, which could cause title text to overlap with the search bar. BUG=665406 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2508043002 Cr-Commit-Position: refs/heads/master@{#433065} (cherry picked from commit 1e4fcf3) Review URL: https://codereview.chromium.org/2519783002 . Cr-Commit-Position: refs/branch-heads/2924@{#13} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
BUG=681778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2640053004 Cr-Commit-Position: refs/heads/master@{#445164} (cherry picked from commit 2d6a760) Review-Url: https://codereview.chromium.org/2649683003 . Cr-Commit-Position: refs/branch-heads/2987@{#13} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
Watchers are not always correct by design. See the long comments at AddWatcher(). BUG=chromium:684233 TEST=trybot Review-Url: https://codereview.chromium.org/2715473003 Cr-Commit-Position: refs/heads/master@{#454590} (cherry picked from commit 7049abb) Review-Url: https://codereview.chromium.org/2731883002 . Cr-Commit-Position: refs/branch-heads/3029@{#13} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
…straint This CL adds a check to reject applyConstraints() if it is passed an unsupported constraint. LayoutTests gets an updated, albeit a bit a cumbersome one because they hit an unrelated bug (https://crbug.com/711524). BUG=711694 Review-Url: https://codereview.chromium.org/2819653003 Cr-Commit-Position: refs/heads/master@{#464820} (cherry picked from commit 635372d) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2819233002 Cr-Commit-Position: refs/branch-heads/3071@{#13} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
rogerwang
pushed a commit
that referenced
this pull request
Jul 20, 2017
This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
…01 of https://codereview.chromium.org/2969123002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=747171 Original issue's description: > Add deduplication logic to .pak files > > Now, when multiple entries contain the same content, multiple > table-of-contents entries will be created, but only one data region. > > As of now, en-US.pak has ~3200 entries, and 350 of them are duplicates. > > For MonochromePublic.apk, shrinks uncompressed .pak size by ~130kb, and > compressed .pak size by 32kb. > > BUG=738566 > > Review-Url: https://codereview.chromium.org/2969123002 > Cr-Commit-Position: refs/heads/master@{#488215} > Committed: https://chromium.googlesource.com/chromium/src/+/ade347f539a378fb37500f6d17e8835edc1d8ec0 TBR=flackr@chromium.org,sadrul@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=738566 Review-Url: https://codereview.chromium.org/2989443002 Cr-Original-Commit-Position: refs/heads/master@{#488554} Change-Id: I33eff508d4177907d050424bee967d643fe022e4 Reviewed-on: https://chromium-review.googlesource.com/583542 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#13} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
TBR=dimu@chromium.org Change-Id: I5a73d2e5f11ddd992cc37b922c7e40663fc6d429 Reviewed-on: https://chromium-review.googlesource.com/648061 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#13} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
Bug: 772354 Change-Id: Ie82bb502cbfbf989d653d45ba7e73164de448d26 Reviewed-on: https://chromium-review.googlesource.com/713949 Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#508741} (cherry picked from commit aed1fed) TBR=creis@chromium.org,kenrb@chromium.org,wjmaclean@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: Ib8f5ed55ed080a98b076c3ef9625fb670b6c21df Reviewed-on: https://chromium-review.googlesource.com/721682 Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#13} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
TBR=dimu@chromium.org Change-Id: I0bc2ac45f06cecaff5f469bf4bfa88e79314688e Reviewed-on: https://chromium-review.googlesource.com/878059 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#13} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
This reverts commit 4d546d6. Reason for revert: this patch caused a bug where we leave extraneous windows around when coming out of sleep. TBR=rdevlin.cronin@chromium.org, sky@chromium.org (c/b/ui/browser - clean revert) (cherry picked from commit f16ef54) Bug: 818351 Change-Id: I3cf6d60a4588b36619dc4e461c3b8cf29722d6cd Reviewed-on: https://chromium-review.googlesource.com/947473 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540720} Reviewed-on: https://chromium-review.googlesource.com/949307 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#13} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
…ement. This patch adds the ability for implementers of PaymentInstrument interface to determine whether skipping the payment sheet into this instrument should require a user gesture. By default, the user gesture is required for the skip UI flow. TBR=rouslan@chromium.org (cherry picked from commit d5ccecd) Bug: 828427 Change-Id: Id6878c7d0d9bef71da7734d2efec3fd6002fe282 Reviewed-on: https://chromium-review.googlesource.com/1010975 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550461} Reviewed-on: https://chromium-review.googlesource.com/1013608 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#13} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
In https://crrev.com/c/924027, we blocked copy command if selection is hidden, but also incidentally broke copying on image documents because: - We don't have visible selection on image document - Copying on image document is done via a fast path that doesn't check selection at all, but the CL blocked the fast path This patch moves the fast path before checking selection visibility, so that the original copy behavior on image documents is recovered. Bug: 845957 Change-Id: I920198d13ab3aa387f550c5c213fcbadc42fd43e Reviewed-on: https://chromium-review.googlesource.com/1072730 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561989}(cherry picked from commit bbc2ac0) Reviewed-on: https://chromium-review.googlesource.com/1075687 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#13} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
Bug: 831971 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id656f7fec7577080116e01c5883d9cbf21fd4ce8 Reviewed-on: https://chromium-review.googlesource.com/1128269 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576960}(cherry picked from commit 0d313e2) Reviewed-on: https://chromium-review.googlesource.com/1146840 Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#13} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
StreamCreated() may be called after CloseStream(), leading to a null pointer deref on |delegate_|. Avoid this by invalidating the weak pointer that was bound into StreamCreated(). Bug: 879257 Change-Id: I954421b384928bff3c3d17506850012e2a1da1b3 Reviewed-on: https://chromium-review.googlesource.com/1199142 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587981}(cherry picked from commit 4ef85aa) Reviewed-on: https://chromium-review.googlesource.com/1202042 Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#13} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
…h()." Depending on which process the MediaCodec is running in, there may already be a non-default looper and handler which results in stale input/output indexes being delivered to the bridge after start(). To prevent this, we now call start() immediately after flush(), but post the clearing of mPendingStart through the handler/looper. A sequence counter is added so that rapid flush()/stop() calls don't prematurely use invalid indices. BUG=892591 TEST=Run chrome with --in-process-gpu and seek a bunch on any video. Change-Id: I8c60a73b8c00c85a7ab3d253bc8df2397c1fa00d Reviewed-on: https://chromium-review.googlesource.com/c/1278293 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599283}(cherry picked from commit 1508795) Reviewed-on: https://chromium-review.googlesource.com/c/1279958 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#13} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
This optimization was the cause of at least one bug (crbug.com/812166), and will hopefully not be needed once Composite After Paint is implemented. Bug: 812166 Change-Id: I2024b887949904bad5515d76b2fa29607dae3ff9 Reviewed-on: https://chromium-review.googlesource.com/c/1354572 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612670}(cherry picked from commit f6e075c) Reviewed-on: https://chromium-review.googlesource.com/c/1359144 Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#13} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
TBR=cmasso@chromium.org Change-Id: I472c26bfa08e78c4a26a1c6ac2304b31d7530c36 Reviewed-on: https://chromium-review.googlesource.com/c/1438463 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#13} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
Missed changing this field in crosreview.com/1498791. Bug: 920024 Bug: 930786 Change-Id: Iae6516ca0846b7d20c2489caa0891a6e6e37666a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510699 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#638947}(cherry picked from commit 8991023ac1e774a5cdcd4f9d240c60ef4be4b54c) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513794 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#13} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever SSL state is changed 'sslchange' event on Webview is emitted with certificate details (if available).