Nw14 mas #16

ghostoy · 2016-05-05T09:18:50Z

Chromium side patches for MAS build. The patch includes many commits for reviewing easily.

* fixed long socket file path issue * used team id for mach global lookup/checkin

Removed private API calls according to a list of crbug: https://bugs.chromium.org/p/chromium/issues/detail?id=496049 The following non-public APIs are reported: '/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit' : _NSAppendToKillRing : _NSDrawCarbonThemeBezel : _NSDrawCarbonThemeListBox : _NSInitializeKillRing : _NSNewKillRingSequence : _NSPrependToKillRing : _NSSetKillRingToYankedState : _NSYankFromKillRing '/System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices' : CGSSetDenyWindowServerConnections : CGSShutdownServerConnections ‘/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation' : _CFBundleLoadExecutableAndReturnError : _CFURLCopyPropertyListRepresentation : _CFURLCreateFromPropertyListRepresentation '/usr/lib/libSystem.B.dylib' : vproc_swap_complex # this one is not found in NW.js binary Removed private API calls to xpc_* Removed following non-public API(s) framework: '/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit' : NSAccessibilityUnregisterUniqueIdForUIElement : NSTextInputReplacementRangeAttributeName framework: '/System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices' : AXTextMarkerCreate : AXTextMarkerGetBytePtr : AXTextMarkerRangeCopyEndMarker : AXTextMarkerRangeCopyStartMarker : AXTextMarkerRangeCreate : CGSSetWindowBackgroundBlurRadius : CTFontCopyDefaultCascadeList Removed following non-public API(s) * _CGSDefaultConnection * CGSSetWindowTransform * CGSSetWindowWarp * CGSSetWindowAlpha

* Fix for "Anatomy of Framework Bundles" compatible * Apple requires frameworks to be "versioned". Files in top folder should be symblic links to it's current version folder (`Versions/Current`), which is also a symbolic link to a real version in the same folder (like `Versions/A`). * Fixed property list file for mac * Removed `CFBundleDocumentTypes` and `CFBundleURLTypes` * Declared `*.nw` files being opened by NW.js * Removed app_mode_app * Removed crashpad for MAS * Not to symbolic link to Helpers * Helpers folder will not be created if not copying crashpad_handler. Symbolic link to Helpers folder will be invalid for uploading to App Store. * Not to symbolic link to 'Internet Plug-Ins' * 'Internet Plug-Ins' folder will not be created if nacl is not copied. Symbolic link to this folder will be invalid for uploading to App Store. * Updated default icons with all required scales According to [OS X Human Interface Guidelines][1], app icons should provide scales of following resolutions: * icon_512x512@2x : 1024 x 1024 * icon_512x512 : 512 x 512 * icon_256x256@2x : 512 x 512 * icon_256x256 : 256 x 256 * icon_128x128@2x : 256 x 256 * icon_128x128 : 128 x 128 * icon_32x32@2x : 64 x 64 * icon_32x32 : 32 x 32 * icon_16x16@2x : 32 x 32 * icon_16x16 : 16 x 16 The new icons are generated from original icon files by using `iconutil` tool ``` iconutil -c iconset -o <file>.iconset <file>.icns iconutil -c icns -o <file>.icns <file>.iconset ``` [1]: https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/Designing.html

Bluetooth query will fail on accessing BT devices when it's not entitled with `com.apple.security.device.bluetooth`. And disabling the query won't prevent using `chrome.bluetooth` APIs.

gfx::Image has pointer-like semantics and is not thread-safe. The previous code did PNG encoding on blocking pool on a gfx::Image object that might be shared with other places, and lead to the crash. The new code does the encode only once on the initialization time, to avoid the racy state. BUG=661197 TEST=manually verified file manager and browser context menu icons. Review-Url: https://codereview.chromium.org/2507403003 Cr-Commit-Position: refs/heads/master@{#433070} (cherry picked from commit 290840c) Review URL: https://codereview.chromium.org/2520783002 . Cr-Commit-Position: refs/branch-heads/2924@{#16} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

…nge()." to M57 branch. This CL has no user-visible behavior changes. BUG=682927 Review-Url: https://codereview.chromium.org/2646903002 Cr-Commit-Position: refs/heads/master@{#444980} (cherry picked from commit bc3500b) Review-Url: https://codereview.chromium.org/2648183002 . Cr-Commit-Position: refs/branch-heads/2987@{#16} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

This CL fixes a minor ommision in CL 2685523002. BUG=688945 Review-Url: https://codereview.chromium.org/2726223003 Cr-Commit-Position: refs/heads/master@{#454684} (cherry picked from commit 291cbdc) Review-Url: https://codereview.chromium.org/2728333002 . Cr-Commit-Position: refs/branch-heads/3029@{#16} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

…ps://codereview.chromium.org/2815453006/ ) Reason for revert: Reason for revert: https://codereview.chromium.org/2653923008/ is suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Introduce ModulePendingScript > > BUG=594639 > > Review-Url: https://codereview.chromium.org/2815453006 > Cr-Commit-Position: refs/heads/master@{#464627} > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59a88f77bb50f5 TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594639 Review-Url: https://codereview.chromium.org/2816043005 Cr-Commit-Position: refs/heads/master@{#464765} (cherry picked from commit 80f482b) Review-Url: https://codereview.chromium.org/2825523002 . Cr-Commit-Position: refs/branch-heads/3071@{#16} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

When Element == document.scrollingElement, these methods should delegate to the `window` object's scrolling methods. With the inert visual viewport change shipping in M61, these methods are relative to the layout viewport so calling through document.scrollingElement should behave the same way. TBR=bokan@chromium.org (cherry picked from commit 59c9922) Bug: 747413 Change-Id: Ibb1d1bb29545161f1768110b22d63ea4a2d4f708 Reviewed-on: https://chromium-review.googlesource.com/581876 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488970} Reviewed-on: https://chromium-review.googlesource.com/584028 Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#16} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

TBR=dimu@chromium.org Change-Id: Ib2458baa75a5facdb491c5f591332f6549535a1d Reviewed-on: https://chromium-review.googlesource.com/648849 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#16} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

TBR=amineer@chromium.org Change-Id: I2a853de9d365433f1b578884090d55c6780605fd Reviewed-on: https://chromium-review.googlesource.com/721736 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#16} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

This reverts commit e23729f. Reason for revert: Probably causing other crashing (see bug) Original change's description: > Fix crash when switching back from Samsung DeX to Phone mode. > > Regressed in d875cac > > Bug: 780593 > Change-Id: Ifee7a93ada73f5b757a35ece75b0bef61ea767c2 > Reviewed-on: https://chromium-review.googlesource.com/820531 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527117} TBR=agrieve@chromium.org, tedchoc@chromium.org, twellington@chromium.org (cherry picked from commit 3f25cfc) Bug: 780593, 794551 Change-Id: Ia91f278b1dff52af4f4fc1bbd33743168dfb5e4a Reviewed-on: https://chromium-review.googlesource.com/874803 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530406} Reviewed-on: https://chromium-review.googlesource.com/879112 Cr-Commit-Position: refs/branch-heads/3325@{#16} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

Bug was introduced here: https://chromium-review.googlesource.com/920790 Change introducing the bug was not actually related to the fix in that CL. TBR=stevenjb@chromium.org (cherry picked from commit bb670e0) Bug: 817706 Change-Id: I9e73f05fe66745b1b7651333a6d715c682018a1a Reviewed-on: https://chromium-review.googlesource.com/944161 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540536} Reviewed-on: https://chromium-review.googlesource.com/949965 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#16} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

…ents Contextual Search show/hide events are not 1:1. Show can be called multiple times when the text selection changes (which is pretty often). This would cause the bottom sheet to remain hidden after Contextual Search was gone. This patch checks if Contextual Search is already showing in the BottomSheetController as not to change the behavior of other Contextual Search observers. TBR=mdjones@chromium.org (cherry picked from commit f3b7557) Bug: 827353 Change-Id: Ib133224042cef6509d3cd7b81df78810093190f8 Reviewed-on: https://chromium-review.googlesource.com/1012193 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550689} Reviewed-on: https://chromium-review.googlesource.com/1014189 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#16} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

TBR=amineer@chromium.org Change-Id: Ie42141f8cb7f537724d446bd4fca501923e6015f Reviewed-on: https://chromium-review.googlesource.com/1075613 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#16} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

Launch bug (w/ approvals): crbug.com/831743 Intent 2 ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2xR7cucnOA Bug: 832811, 831743 Change-Id: I24d2f49e82b5afe1dd668dc57e0ceb98af36e205 Reviewed-on: https://chromium-review.googlesource.com/1141104 Reviewed-by: Alex Russell <slightlyoff@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576796}(cherry picked from commit 4fcc638) Reviewed-on: https://chromium-review.googlesource.com/1147040 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#16} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

Within MTPDeviceDelegateImplLinux::ReadDirectoryInternal, the call to PendingRequestDone at the end of the function allowed for another task to run and potentially delete the file_id from the cache prior to the directory listing being done. This would then cause a nullptr dereference in OnDidReadDirectory which expects the cache entry to exist. Since ReadDirectoryInternal is only run from a task, just continue the task instead of posting it to the request queue. BUG=817523 Change-Id: I9df651864ba1ef3c26365832b149871b027f99d5 Reviewed-on: https://chromium-review.googlesource.com/1195202 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587857}(cherry picked from commit 897f35e) Reviewed-on: https://chromium-review.googlesource.com/1203550 Reviewed-by: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#16} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

Wired most of the UMA logging, there are two methods in the bridge not connected since it is new UMA, will do in next CL. Bug: 831641 Change-Id: I154261aa3266d1f6d0af07ccb7510b3879f2744e Reviewed-on: https://chromium-review.googlesource.com/c/1275130 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599089}(cherry picked from commit ab5a1ef) Reviewed-on: https://chromium-review.googlesource.com/c/1280122 Reviewed-by: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#16} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

This change introduces a new Autofill section into the Chrome settings UI. This section contains "Passwords", "Payment Methods" and "Addresses and more", which prior to this change were part of the People section. In particular, this change: - Renames passwords_and_forms_page to autofill_page - Moves autofill entries from people_page.html to autofill_page.html - Adds a chrome://settings/autofill route for the new section, renaming the previously existing autofill route to chrome://settings/addresses - Removes the kAutofillHome feature flag and related conditionals - Removes a few now obsolete strings from settings_strings.grdp Bug: 907035, 854562 Change-Id: I479841db651c23813ab1ac1525f712d0ff9266c2 Reviewed-on: https://chromium-review.googlesource.com/c/1348039 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612541}(cherry picked from commit 38d2033) Reviewed-on: https://chromium-review.googlesource.com/c/1358638 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#16} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

R=kariah@chromium.org Change-Id: I63ffd37ea5b57b5c352891ba53564397ad37fba2 Reviewed-on: https://chromium-review.googlesource.com/c/1436264 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#16} Cr-Branched-From: e510299-refs/heads/master@{#625896}

…try. This CL adds basic plumbing to start isolating sites where a user types in a password. We intend to use this on Android, where full site isolation is disabled. This is all gated behind a new base::Feature, which is disabled by default. The plan is to (eventually) enable that feature in our site isolation Android trials and start getting some experience with how well this works. The heuristic to start isolating sites based on entering a password is expected to be refined over time to handle more cases. For example, we will also want to eventually isolate origins for which the user had previously stored a password. Design doc and discussion is at: https://docs.google.com/document/d/10P1qV2X-gNoDoqgRVya4iXo7PDtGphytgle08o1ccr8/edit?usp=sharing Bug: 905513 Change-Id: I251c965bd6ffd85d279c6cdda7d4f902c6223586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507315 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#638920}(cherry picked from commit 07e1bb40ca556ab3a2c5de1665b840b9f76a56d3) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513010 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#16} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

rogerwang force-pushed the nw14 branch 4 times, most recently from 3478215 to d0282e2 Compare May 13, 2016 05:52

rogerwang force-pushed the nw14 branch 2 times, most recently from 3a725c9 to c26c469 Compare May 18, 2016 04:58

rogerwang force-pushed the nw14 branch 5 times, most recently from 078615d to 47e208b Compare May 30, 2016 01:52

rogerwang force-pushed the nw14 branch 7 times, most recently from 47f09a5 to 343327e Compare June 8, 2016 06:16

rogerwang force-pushed the nw14 branch 2 times, most recently from 03c9b12 to f846851 Compare June 13, 2016 11:16

rogerwang force-pushed the nw14 branch 3 times, most recently from 64fe72c to a215279 Compare June 26, 2016 08:36

rogerwang force-pushed the nw14 branch from a215279 to 954e187 Compare July 20, 2016 03:05

nwjs master

c661222

rogerwang force-pushed the nw14 branch from 954e187 to c661222 Compare July 22, 2016 00:36

ghostoy force-pushed the nw14-mas branch from fa6823a to 318e429 Compare August 19, 2016 06:10

Cong Liu added 3 commits October 9, 2016 09:47

Enabled sandbox support for MAS

bfe18c6

* fixed long socket file path issue * used team id for mach global lookup/checkin

Removed deps of QTKit framework (chromium part)

50b5126

Cong Liu added 2 commits October 9, 2016 09:47

Disable unnecessary BT adaptor query on start

1c092d6

Bluetooth query will fail on accessing BT devices when it's not entitled with `com.apple.security.device.bluetooth`. And disabling the query won't prevent using `chrome.bluetooth` APIs.

ghostoy force-pushed the nw14-mas branch from 450b0f3 to 1c092d6 Compare October 11, 2016 02:06

rogerwang force-pushed the nw14 branch from c661222 to 4e17801 Compare March 6, 2017 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nw14 mas #16

Nw14 mas #16

ghostoy commented May 5, 2016

Nw14 mas #16

Are you sure you want to change the base?

Nw14 mas #16

Conversation

ghostoy commented May 5, 2016