[mac] Really hide app when pressing `Cmd+H` #4

ghostoy · 2016-03-07T05:45:26Z

Chrome hides all web app windows without hiding entire app, and
turn over the controls to Chrome browser. But for NW.js, this will
cause the app still activative without showing any window when
pressing Cmd+H and not able to unhide since we don't have the
browser part to do this. The fix simply hides the app instead of
hiding all windows.

Fixed nwjs/nw.js#4296

Chrome hides all web app windows without hiding entire app, and turn over the controls to Chrome browser. But for NW.js, this will cause the app still activative without showing any window when pressing `Cmd+H` and not able to unhide since we don't have the browser part to do this. The fix simply hides the app instead of hiding all windows. Fixed nwjs/nw.js#4296

rogerwang · 2016-03-07T12:26:41Z

merged into the master patch.

…able. (patchset #4 id:80001 of https://codereview.chromium.org/2145323002/ )" to M55 branch Reason for revert: It caused regression: https://bugs.chromium.org/p/chromium/issues/detail?id=656736 Original issue's description: > Content in disabled input field should not be selectable. > > Spec: https://html.spec.whatwg.org/multipage/forms.html#the-readonly-attribute:attr-input-readonly > > BUG=626581 > > Committed: https://crrev.com/21d670d3e740b26dcdf63631d163c45a57d9531c > Cr-Commit-Position: refs/heads/master@{#405717} TBR=tkent@chromium.org,ramya.v@samsung.com BUG=626581 Review-Url: https://codereview.chromium.org/2455853002 Cr-Commit-Position: refs/heads/master@{#428261} (cherry picked from commit e16d4aa) Review URL: https://codereview.chromium.org/2461293002 . Cr-Commit-Position: refs/branch-heads/2883@{#379} Cr-Branched-From: 614d31d-refs/heads/master@{#423768}

This reverts commit 60c148e. https://codereview.chromium.org/2476113002/ BUG=666154 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=esprehn@chromium.org,blundell@chromium.org,ccameron@chromium.org,danakj@chromium.org,fmalita@chromium.org,khushalsagar@chromium.org,raymes@chromium.org,sky@chromium.org,tobiasjs@chromium.org Review-Url: https://codereview.chromium.org/2509983004 Cr-Commit-Position: refs/heads/master@{#433136} (cherry picked from commit c5afa23) Review URL: https://codereview.chromium.org/2519513002 . Cr-Commit-Position: refs/branch-heads/2924@{#4} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

…intrinsic sizes (patchset #4 id:60001 of https://codereview.chromium.org/2287533002/ ) Reason for revert: Caused crash on Mac. See http://crbug.com/662016 We're reverting only the code change as we want to keep the tests, that will be fixed after the refactoring happening in bug #627812 is done. So, we need to mark 2 tests as failure in TestExpectations file. BUG=662016,666688,627812 Original issue's description: > [css-grid] Remove a duplicated auto repeat computation for intrinsic sizes > > After crrev.com/414446 we can safely remove the temporary fix > (crrev.com/405529) we had to avoid crashes and recursive calls when > computing the auto repeat tracks count for grids with intrinsic sizes. > > This change unveiled a couple of bugs in the computation of auto repeat > tracks for intrinsic sizes. The first one is that we were not considering the > existence of definite minimum sizes. In those cases, instead of just returning 1 > repetition, we should return the minimum number of repetitions that fulfill the > minimum size requirement. > > The second bug was that grids were not properly recomputing the number of > auto repeat tracks when the min|max-content contributions of grid items > changed (whenever the grid container had an intrinsic width). > > One Mozilla test had to be updated too because it was wrong. > BUG=621517,633474 > > Review-Url: https://codereview.chromium.org/2287533002 > Cr-Commit-Position: refs/heads/master@{#425958} Review-Url: https://codereview.chromium.org/2510393002 Cr-Commit-Position: refs/heads/master@{#433183} (cherry picked from commit b9e7d1d) Review URL: https://codereview.chromium.org/2521573002 . Cr-Commit-Position: refs/branch-heads/2924@{#24} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

…:60001 of https://codereview.chromium.org/2416693002/ ) Reason for revert: It changed transform->mapRect(enclosingIntRect(rect)) to transform->mapRect(FloatRect(enclosingIntRect(rect))) causing missing enclosingIntRect() after the transform. We may also need enclosingIntRect for empty rects because even empty object can have visible filter depending on pixel snapping here. BUG=669774 TEST=paint/invalidation/rotated-subpixel.html Original issue's description: > Don't expand empty rect during rect mapping > > For example, enclosingIntRect(LayoutRect(0.5, 0.5, 0, 0)) results > IntRect(0, 0, 1, 1). This causes unnecessary non-empty visual rects > mapped from empty LayoutRects. > > This CL is mainly to reduce the difference between the old path and > slimmingPaintInvalidation with pixel snapping feature. > > Committed: https://crrev.com/67c516aaed2486295a98d7f0ff2235b921cd7933 > Cr-Commit-Position: refs/heads/master@{#424970} TBR=chrishtr@chromium.org Review URL: https://codereview.chromium.org/2547093002 . Review-Url: https://codereview.chromium.org/2545573002 Cr-Original-Commit-Position: refs/heads/master@{#435677} Cr-Commit-Position: refs/branch-heads/2924@{#293} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}

This reverts commit 87b724b on branch 2987 to make PFQ happy. BUG=682868, 661105 TBR=yoshiki@chromium.org Review-Url: https://codereview.chromium.org/2644383002 . Cr-Commit-Position: refs/branch-heads/2987@{#4} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

…id:80001 of https://codereview.chromium.org/2626123002/ ) Reason for revert: crbug/691904 reports that when changing the language, the pages are not redrawn in the newly selected language. This CL is not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I can look into it further for a later milestone. Original issue's description: > [i18n] chromeos login i18n-content to $i18n{} > > This is a semi-mechanical change to convert i18n-content to $i18n{}. The > Non-mechancal changes are some formatting adjustments. > > BUG=677338 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2626123002 > Cr-Commit-Position: refs/heads/master@{#443327} > Committed: https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d7f8bceebea99 TBR=tommycli@chromium.org BUG=691904 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2694353002 Cr-Commit-Position: refs/heads/master@{#450762} (cherry picked from commit 8f21fb4) Review-Url: https://codereview.chromium.org/2718563003 . Cr-Commit-Position: refs/branch-heads/2987@{#673} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

…try if Declarative Web Request is enabled. (patchset #4 id:60001 of https://codereview.chromium.org/2705513002/ ) Reason for revert: Declarative Web Request is enabled on Stable through <webview>. Hence we can't disable creation of rules registry on Stable. Original issue's description: > Extensions: Only create Web request rules registry if Declarative Web Request is enabled. > > Currently the Web Request rules registry required by the Declarative Web > Request API is created on all Chrome channels, even though the Declarative Web > Request API is disabled on Stable. The UMA metric > Extensions.NetworkDelayRegistryLoad shows significant delay for some web > requests which are blocked due to the loading of the Web Request rules > registry even on Stable. The mean delay is around 1.7 sec and the median delay > is around 50ms. > > This CL modifies RulesRegistryService::EnsureDefaultRulesRegistriesRegistered > to ensure the Web Request rules registry is only created for the channels on > which the Declarative Web Request API is enabled. To do this, > Feature::IsAvailableToChannel is introduced. > > BUG=693243 > > Review-Url: https://codereview.chromium.org/2705513002 > Cr-Commit-Position: refs/heads/master@{#452240} > Committed: https://chromium.googlesource.com/chromium/src/+/a77b53baca5f2a4ff102592c17c8ea3f53dd5307 BUG=693243 Review-Url: https://codereview.chromium.org/2773593003 Cr-Commit-Position: refs/heads/master@{#459269} (cherry picked from commit 9df2ccc) Review-Url: https://codereview.chromium.org/2783543003 . Cr-Commit-Position: refs/branch-heads/3029@{#462} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

Starting with Chrome M58, setting secure cookies for http urls is not allowed (strict secure cookies). However, Webview using applications used to set cookies using a Webview setCookie API and until now we discovered 3 apps doing that and failing in different ways. This change is a temporary hack to allow this API to modify HTTP urls to HTTPS when setting secure cookies. BUG=706993 Review-Url: https://codereview.chromium.org/2821623003 Cr-Commit-Position: refs/heads/master@{#464734} (cherry picked from commit 5054938) Review-Url: https://codereview.chromium.org/2817343002 . Cr-Commit-Position: refs/branch-heads/3071@{#4} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

… (patchset #4 id:170001 of https://codereview.chromium.org/2809043004/ ) Reason for revert: Causes http://crbug.com/714386 Original issue's description: > Reland of Initialize default audio device ID with explicit device ID. (patchset #1 id:1 of https://codereview.chromium.org/2813543005/ ) > > Reason for revert: > Will attempt to reland by reverting changes in MSM and updating extensions test. > > Original issue's description: > > Revert of Initialize default audio device ID with explicit device ID. (patchset #2 id:20001 of https://codereview.chromium.org/2812903002/ ) > > > > Reason for revert: > > Patchset 2 restores the behavior I wanted to eliminate. > > > > Original issue's description: > > > Initialize default audio device ID with explicit device ID. > > > > > > This is more consistent with how video device IDs are specified and is > > > also a small first step towards implementing the standard constraints > > > algorithm for audio. > > > This CL disables a misleading selector that allows switching the > > > user-preferred device in the middle of a getUserMedia call. > > > Since that selector does not affect the current getUserMedia call, it > > > is better to have it disabled, which is already the case with video > > > devices. > > > > > > BUG=708081 > > > > > > Review-Url: https://codereview.chromium.org/2812903002 > > > Cr-Commit-Position: refs/heads/master@{#463624} > > > Committed: https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d > > > > TBR=hbos@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=708081 > > > > Review-Url: https://codereview.chromium.org/2813543005 > > Cr-Commit-Position: refs/heads/master@{#463634} > > Committed: https://chromium.googlesource.com/chromium/src/+/cf8ea8d590f1c89c2633c793a41bd31a85b3fe72 > > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=708081 > > Review-Url: https://codereview.chromium.org/2809043004 > Cr-Commit-Position: refs/heads/master@{#463710} > Committed: https://chromium.googlesource.com/chromium/src/+/be26518ed4e8a2966c919a93b488689374b17d42 TBR=mek@chromium.org BUG=708081,714386 Review-Url: https://codereview.chromium.org/2829403002 Cr-Commit-Position: refs/heads/master@{#466550} (cherry picked from commit 18633fc) Review-Url: https://codereview.chromium.org/2837873004 . Cr-Commit-Position: refs/branch-heads/3071@{#194} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…id:60001 of https://codereview.chromium.org/2838023002/ ) Reason for revert: Null pointer crash http://crbug.com/715526 BUG=715526 Original issue's description: > Only do Smart Select if one word is selected. > > There is a bug where after "Select All" Smart Select will suggest a different > (smaller) selection. This CL checks if the selection only has one word. Since > longpress/double tap only selects one word, if we have multiple words we can assume > it comes from "Select All" and not do Smart Select. > > BUG=714106 > > Review-Url: https://codereview.chromium.org/2838023002 > Cr-Commit-Position: refs/heads/master@{#466856} > Committed: https://chromium.googlesource.com/chromium/src/+/03f5058e764e8b2b01d571f29426075a83f6049b TBR=timav@chromium.org,amaralp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714106 Review-Url: https://codereview.chromium.org/2848793002 Cr-Commit-Position: refs/heads/master@{#467870} (cherry picked from commit 4bceb98) Review-Url: https://codereview.chromium.org/2844933004 . Cr-Commit-Position: refs/branch-heads/3071@{#282} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…ers (patchset #4 id:60001 of https://codereview.chromium.org/2919533003/ ) Reason for revert: This breaks nyan (see crbug.com/734074) so let's revert to hopefully have a green PFQ run today. Original issue's description: > ozone/drm: Only reuse ScanoutBuffers with compatible modifiers > > Now that we have modifiers, we need to make sure that not just the > format, but also the format modifer is compatible with the > HardwareDisplayController where we want to use the buffer. > > BUG=b/38217940 > TEST=Plug in external monitor that supports same resolution as internal > panel with mirror mode enabled > > Review-Url: https://codereview.chromium.org/2919533003 > Cr-Commit-Position: refs/heads/master@{#479813} > Committed: https://chromium.googlesource.com/chromium/src/+/9947afe90294ff5ad902e2cc02f8064506f7f0a4 TBR=dcastagna@chromium.org,reveman@chromium.org,dnicoara@chromium.org,hoegsberg@google.com,hoegsberg@chromium.org BUG=b/38217940 Review-Url: https://codereview.chromium.org/2948513003 Cr-Original-Commit-Position: refs/heads/master@{#480683} Review-Url: https://codereview.chromium.org/2951083003 . Cr-Commit-Position: refs/branch-heads/3071@{#812} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…ers (patchset #4 id:60001 of https://codereview.chromium.org/2919533003/ ) Reason for revert: This breaks nyan (see crbug.com/734074) so let's revert to hopefully have a green PFQ run today. Original issue's description: > ozone/drm: Only reuse ScanoutBuffers with compatible modifiers > > Now that we have modifiers, we need to make sure that not just the > format, but also the format modifer is compatible with the > HardwareDisplayController where we want to use the buffer. > > BUG=b/38217940 > TEST=Plug in external monitor that supports same resolution as internal > panel with mirror mode enabled > > Review-Url: https://codereview.chromium.org/2919533003 > Cr-Commit-Position: refs/heads/master@{#479813} > Committed: https://chromium.googlesource.com/chromium/src/+/9947afe90294ff5ad902e2cc02f8064506f7f0a4 TBR=dcastagna@chromium.org,reveman@chromium.org,dnicoara@chromium.org,hoegsberg@google.com,hoegsberg@chromium.org BUG=b/38217940 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2948513003 Cr-Original-Commit-Position: refs/heads/master@{#480683} Review-Url: https://codereview.chromium.org/2946343002 Cr-Commit-Position: refs/branch-heads/3112@{#425} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

TBR=dimu@chromium.org Change-Id: Icd24c9b3024200e901e1b527fc8002701e5814f0 Reviewed-on: https://chromium-review.googlesource.com/581909 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#4} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

We defer event callback list modification until the outermost Wait() unwinds, but we need to ensure that the internal WaitSet has events removed immediately within UnregisterEvent if the event has no more valid callbacks registered. This allows callers to make the assumption that exclusively registered events are not referenced beyond a call to UnregisterEvent, which is an assumption made by production code. Adds tests for SyncHandleRegistry event watching too. BUG=761097 TBR=rockot@chromium.org (cherry picked from commit 018ebce) Change-Id: Ibbf6eee335879bba6b732637944338f046bf37cb Reviewed-on: https://chromium-review.googlesource.com/646491 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499116} Reviewed-on: https://chromium-review.googlesource.com/647335 Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#4} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

TBR=dimu@chromium.org Change-Id: I685fd90e209efeb38ded3a71ee933ba8fcb05011 Reviewed-on: https://chromium-review.googlesource.com/719857 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#4} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

Integrating cross-site document blocking with 2 new content_features.h: - kCrossSiteDocumentBlockingIfIsolating - kill switch for cross-site document blocking. This feature is enabled by default. - kCrossSiteDocumentBlockingAlways - a way to force cross-site document blocking even if no isolation mode is turned on (e.g. even if there is no site-per-process or isolate-origins). This feature is disabled by default. Bug: 786505, 793881 TBR=nasko@chromium.org Change-Id: Id0c9a69025fc20f7659b97a96fe70402cc933113 Reviewed-on: https://chromium-review.googlesource.com/818388 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#522981} Reviewed-on: https://chromium-review.googlesource.com/820673 Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3239_84@{#4} Cr-Original-Branched-From: 8f51ed0-refs/branch-heads/3239@{#643} Cr-Original-Branched-From: adb61db-refs/heads/master@{#508578} Reviewed-on: https://chromium-review.googlesource.com/823564 Cr-Commit-Position: refs/branch-heads/3239@{#669} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

TBR=dimu@chromium.org Change-Id: I743c15f0e6b8382bc8d9ff608789d1e7c40a1e89 Reviewed-on: https://chromium-review.googlesource.com/877084 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#4} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

TBR=dimu@chromium.org Change-Id: I8f09d04365d5e69ea46b242035d3befd85850188 Reviewed-on: https://chromium-review.googlesource.com/947862 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#4} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

TBR=dimu@chromium.org Change-Id: I2fd9a684f7a9c4c7fe1d2e6039f24a1c8240ac1b Reviewed-on: https://chromium-review.googlesource.com/1013297 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#4} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

TBR=mmoss@chromium.org Change-Id: Ice9abcd35a88568b85fa32306b6cf2419870c794 Reviewed-on: https://chromium-review.googlesource.com/1073049 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#4} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

Change-Id: Ib0f928021d95d7e7eb0654f7ae7de7d8986252c6 Reviewed-on: https://chromium-review.googlesource.com/1145591 Reviewed-by: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#4} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

…rash. The situation should never happen, but nevertheless seems to. Bug: 880930 TBR=chrishtr@chromium.org (cherry picked from commit e7d0bfae65eea619183a186eaf1e8887260cb965) Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1dec6cdb3cb2c004511646a7133c4564a5a4f4ca Reviewed-on: https://chromium-review.googlesource.com/1211872 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#589424}(cherry picked from commit ab3d057) Reviewed-on: https://chromium-review.googlesource.com/1212355 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3545@{#4} Cr-Original-Branched-From: a2bbe9d-refs/heads/master@{#589377} Reviewed-on: https://chromium-review.googlesource.com/1214263 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#907} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

Bug: 873588 Change-Id: I089aa1919242effd05ad753a2f21ef3293320e36 Reviewed-on: https://chromium-review.googlesource.com/1197337 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587830}(cherry picked from commit 6fd4390) Reviewed-on: https://chromium-review.googlesource.com/1198494 Reviewed-by: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#4} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

…rash. The situation should never happen, but nevertheless seems to. Bug: 880930 TBR=chrishtr@chromium.org (cherry picked from commit e7d0bfae65eea619183a186eaf1e8887260cb965) Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1dec6cdb3cb2c004511646a7133c4564a5a4f4ca Reviewed-on: https://chromium-review.googlesource.com/1211872 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#589424}(cherry picked from commit ab3d057) Reviewed-on: https://chromium-review.googlesource.com/1212355 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3545@{#4} Cr-Original-Branched-From: a2bbe9d-refs/heads/master@{#589377} Reviewed-on: https://chromium-review.googlesource.com/1214071 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#165} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

Change-Id: I43def4ae15a51d0cb18ec106864469ffa81f7a93 Reviewed-on: https://chromium-review.googlesource.com/c/1277794 Reviewed-by: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#4} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

…:OnItemUpdated Bug: 894583 Change-Id: I7c1011ab2f8acffbe93b7523c6839f481f733ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1279203 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#599371}(cherry picked from commit 4d5af77) Reviewed-on: https://chromium-review.googlesource.com/c/1279348 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3575@{#4} Cr-Original-Branched-From: 16ca0c3-refs/heads/master@{#597882}(cherry picked from commit 16f1dabf14796c11b1f767bf412b3351dd9d1b16) Reviewed-on: https://chromium-review.googlesource.com/c/1294839 Cr-Commit-Position: refs/branch-heads/3578@{#249} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

This is a partial re-land of: https://chromium-review.googlesource.com/c/1344097 "Read master preferences before create variations to allow to migrate variations from master preferences to Local State" That CL's diff is in patchset 1. However, that CL caused a crash on first run in official builds due to official build first run logic relying on ResourceBundle being initialized. That CL tried to move all first run master prefs import logic to be earlier. This CL partially reverts that and only moves the logic specific to variations' first run (which does not depend on ResourceBundle) earlier, while keeping the rest of first run import in the same place as before. Confirmed that this fixes the crash on official builds while still fixing variations first run. Also adds a CHECK about ResourceBundle being initialized in the non-official build codepath too, to match what official build does. TBR=asvitkine@chromium.org, cpu@chromium.org (cherry picked from commit c52155f062cf65270868e7c278d61389cf7b0b65) Bug: 907434 Change-Id: I6ae4be40e376d61dd043e37fc4e35bce59473af0 Reviewed-on: https://chromium-review.googlesource.com/c/1351090 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#610973}(cherry picked from commit 1ac2b95) Reviewed-on: https://chromium-review.googlesource.com/c/1352029 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3622@{#4} Cr-Original-Branched-From: bcc2457-refs/heads/master@{#610746} Reviewed-on: https://chromium-review.googlesource.com/c/1354269 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#847} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

TBR=mmoss@chromium.org Change-Id: Id1403d9a069674e12d9b209814794532a407e120 Reviewed-on: https://chromium-review.googlesource.com/c/1357333 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#4} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

TBR=govind@chromium.org Change-Id: If216a33428c46b9daae035e6ab119404070e7676 Reviewed-on: https://chromium-review.googlesource.com/c/1437258 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#4} Cr-Branched-From: e510299-refs/heads/master@{#625896}

R=abdulsyed@chromium.org Change-Id: Ibcd201c796393d4b13880f6a0a627416ab1bab1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512671 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#4} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

Report a DevTools protocol error instead. This is a temporary fix until provisional frames concept is removed. BUG=897816,578349 TBR=alph@chromium.org (cherry picked from commit 3c490ea6b4bd63c6ca68e46cda7499d03bbd6340) Change-Id: I88005df96d3aa31743d8aa543aec0e34516cb9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529871 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#642056}(cherry picked from commit 10268bd0cf3c118c33e4f784679c75a59ba3b661) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531162 Reviewed-by: Abdul Syed <abdulsyed@google.com> Cr-Original-Commit-Position: refs/branch-heads/3738@{#4} Cr-Original-Branched-From: ddf870ba8d01cd04357db9ae6a480d75a7e2f398-refs/heads/master@{#641783} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532992 Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#322} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

rogerwang and others added 2 commits March 7, 2016 10:18

nwjs master

3edfd64

rogerwang force-pushed the nw13 branch from 3edfd64 to 2c53f2b Compare March 7, 2016 12:25

rogerwang closed this Mar 7, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mac] Really hide app when pressing `Cmd+H` #4

[mac] Really hide app when pressing `Cmd+H` #4

ghostoy commented Mar 7, 2016

rogerwang commented Mar 7, 2016

[mac] Really hide app when pressing Cmd+H #4

[mac] Really hide app when pressing Cmd+H #4

Conversation

ghostoy commented Mar 7, 2016

rogerwang commented Mar 7, 2016

[mac] Really hide app when pressing `Cmd+H` #4

[mac] Really hide app when pressing `Cmd+H` #4