DEPS issue fix #1

janRucka · 2016-02-05T14:05:22Z

Updating NW.js with glient sync uses local branch (=no update). DEPS file updated to use remote branch.

…(patchset #1 id:1 of https://codereview.chromium.org/1689013004/ ) Reason for revert: Reverting this and https://codereview.chromium.org/1693663002 because these changes failed to pass the M48 Chrome PFQ Log Snippet : chromeos-chrome-48.0.2564.110_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ash/touch/touchscreen_util.cc:47:41: error: 'class ash::DisplayInfo' has no member named 'sys_path' chromeos-chrome-48.0.2564.110_rc-r1: if (!IsDeviceConnectedViaUsb(display->sys_path()) || Full log: https://uberchromegw.corp.google.com/i/chromeos_release/builders/lumpy%20pre-flight%20release-R48-7647.B/builds/153/steps/BuildPackages/logs/stdio Original issue's description: > Restore previous input device to display pairing behavior. > > We want to always associate a input device so that we don't accidentally break > anyone who is depending on this behavior. > > BUG=582516 > > patch from issue 1652513002 at patchset 20001 (http://crrev.com/1652513002#ps20001) > > (cherry picked from commit d5c1e3b0b0a7b5b960ef16062d5722f24a1ea698) > > Committed: https://chromium.googlesource.com/chromium/src/+/bcd23e6e5da41158189a6e371e1834e4aac3bbc4 NOTRY=true NOPRESUBMIT=true TBR=jdufault@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=582516 Review URL: https://codereview.chromium.org/1701103003 Cr-Commit-Position: refs/branch-heads/2564@{#693} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…ys. (patchset #1 id:1 of https://codereview.chromium.org/1693663002/ ) Reason for revert: This broke M48 Chrome PFQ Log Snippet : chromeos-chrome-48.0.2564.110_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ash/touch/touchscreen_util.cc:47:41: error: 'class ash::DisplayInfo' has no member named 'sys_path' chromeos-chrome-48.0.2564.110_rc-r1: if (!IsDeviceConnectedViaUsb(display->sys_path()) || Full log: https://uberchromegw.corp.google.com/i/chromeos_release/builders/lumpy%20pre-flight%20release-R48-7647.B/builds/153/steps/BuildPackages/logs/stdio NOTRY=true NOPRESUBMIT=true Original issue's description: > Associate UDL input devices with their corresponding displays. > > This CL completely rewrites display/touchscreen association code. There were a > lot of hidden/tricky gotchas and the rewrite calls them out. The association > logic is also significantly easier to extend. > > UDL assocation logic is added using the path to the input/display devices. The > code that exposes the device paths is in two dependent CLs. > > BUG=543209 > > Review URL: https://codereview.chromium.org/1508203002 > > Cr-Commit-Position: refs/heads/master@{#368773} > (cherry picked from commit 10215fd) > > Committed: https://chromium.googlesource.com/chromium/src/+/05a1e94ef976f7e065a0e7b350f6cb566b839010 TBR=jdufault@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=543209 Review URL: https://codereview.chromium.org/1709453002 Cr-Commit-Position: refs/branch-heads/2564@{#694} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…ng This patch fixes a regression where t… (patchset #1 id:1 of https://codereview.chromium.org/1706873002/ ) Reason for revert: Build failures on compile bots. Original issue's description: > Fix reference time implementation in blink DocumentLoadTiming This patch fixes a regression where the reference time in blink was not accurately updated when the embedder calls setNavigationStart before markNavigationStart is called. > > BUG=585373 > > Review URL: https://codereview.chromium.org/1685853003 > > Cr-Commit-Position: refs/heads/master@{#375001} > (cherry picked from commit 7b8afa1) > > Committed: https://chromium.googlesource.com/chromium/src/+/57ec749400076cfe0024cc0518135aadc9c27b2a TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585373 Review URL: https://codereview.chromium.org/1702373003 Cr-Commit-Position: refs/branch-heads/2564@{#700} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

… them. (patchset #1 id:1 of https://codereview.chromium.org/1752533002/ ) Reason for revert: rebase error. missing a template declaration... https://bugs.chromium.org/p/chromium/issues/detail?id=590950 Original issue's description: > [Merge to 2623] Clear IOSurfaces immediately after creating them. > > Calling IOSurfaceLock() followed by IOSurfaceUnlock() appears sufficient. > > BUG=584760 > TBR=reveman@chromium.org, kbr@chromium.org, avi@chromium.org > > Review URL: https://codereview.chromium.org/1709443002 > > Cr-Commit-Position: refs/heads/master@{#376054} > (cherry picked from commit c789639) > > Committed: https://chromium.googlesource.com/chromium/src/+/f3c181bd45aa0f79041ab2b79aece0021423aee5 TBR=avi@chromium.org,kbr@chromium.org,reveman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584760 Review URL: https://codereview.chromium.org/1754513002 Cr-Commit-Position: refs/branch-heads/2623@{#547} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

Cr-Commit-Position: refs/branch-heads/2564@{#1} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…https://codereview.chromium.org/1491043004/ ) Reason for revert: No approval for this cherry-pick. Reverting. Original issue's description: > Fixes document type detection on iOS 9. > > On iOS 9, evaluating '' + document always results in [object > HTMLDocument], even for PDFs. This introduces another way of checking > document type on iOS 9. Unfortunately, it doesn't work on iOS 8, so the > old implementation needs to stay too. > > BUG=549604 > > Review URL: https://codereview.chromium.org/1458703004 > > Cr-Commit-Position: refs/heads/master@{#361095} > (cherry picked from commit 704def3) > > Committed: https://chromium.googlesource.com/chromium/src/+/f5f194b3efbdfc92886eebe0b359a25518061fe0 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549604 Review URL: https://codereview.chromium.org/1491263002 Cr-Commit-Position: refs/branch-heads/2564@{#202} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…itten at ENCRYPTION_NONE. Flag protected… (patchset #1 id:1 of https://codereview.chromium.org/1509673002/ ) Reason for revert: broke the build Original issue's description: > Close the QUIC connection when non-crypto stream data is written at ENCRYPTION_NONE. Flag protected by gfe2_reloadable_flag_quic_never_write_unencrypted_data. > > Merge internal change: 109493807 > > BUG=109446528 > > Review URL: https://codereview.chromium.org/1505563002 > > Cr-Commit-Position: refs/heads/master@{#363395} > (cherry picked from commit 2945a59) > > Committed: https://chromium.googlesource.com/chromium/src/+/2c1b6f0e4aa9ec45e4a7d6d558fd769699286eba TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=109446528 Review URL: https://codereview.chromium.org/1502363003 Cr-Commit-Position: refs/branch-heads/2564@{#265} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…ot established. (patchset #1 id:1 of https://codereview.chromium.org/1505893002/ ) Reason for revert: broke th ebuild Original issue's description: > Prevent QUIC streams from writing data when encryption is not established. > > Merge internal change: 109446528 > > BUG= > > Review URL: https://codereview.chromium.org/1508433002 > > Cr-Commit-Position: refs/heads/master@{#363354} > (cherry picked from commit 94e52bc) > > Committed: https://chromium.googlesource.com/chromium/src/+/d77c488844121c13f51ce887be3344a589d53cb8 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1511473002 Cr-Commit-Position: refs/branch-heads/2564@{#266} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…ttps://codereview.chromium.org/1576113006/ ) Reason for revert: The change broke beta builds. Original issue's description: > Fix null dereference on MemoryCache. > > Usually a valid MemoryCacheEntry holds a non-null Resource as |m_resource|. But > when we hold a valid MemoryCacheEntry beyond destructive statements, it may be > evicted from the cache and get stale. That means |m_resource| can be null in > such cases. This CL checks it in order to avoid null dereference. > > BUG=488373 > > Review URL: https://codereview.chromium.org/1537343002 > > Cr-Commit-Position: refs/heads/master@{#367802} > (cherry picked from commit 843010f) > > Committed: https://chromium.googlesource.com/chromium/src/+/9f80eae6508185f7aed39f1f91a301d9ca18978a TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488373 Review URL: https://codereview.chromium.org/1576423005 Cr-Commit-Position: refs/branch-heads/2564@{#549} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…ms (patchset #1 id:1 of https://codereview.chromium.org/1603253002/ ) Reason for revert: Navigation item has not been changed to entry on branch Original issue's description: > Close page on native app load if page has no navigation items > > Previously, pages were only able to close themselves if they were > renderer initiated. We now have some cases where they should be able > to close when not renderer initiated, e.g. when opening a link that > redirects to the AppStore from an external application. > > BUG=574572 > > Review URL: https://codereview.chromium.org/1595683002 > > Cr-Commit-Position: refs/heads/master@{#370222} > (cherry picked from commit 90a24fe) > > Committed: https://chromium.googlesource.com/chromium/src/+/e9aa94bc3a2a526a9ea063ad0679246da08431d2 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=574572 Review URL: https://codereview.chromium.org/1602353003 Cr-Commit-Position: refs/branch-heads/2564@{#589} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…O_TOPLEVEL. (patchset #1 id:1 of https://codereview.chromium.org/1397673004/ ) Reason for revert: This CL breaks the tab focus stack for new tabs. This patch should account for this and add a test for the existing behavior. Original issue's description: > Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL. > > This CL changes the page transition type for opening the NTP from > PAGE_TRANSITION_TYPED to PAGE_TRANSITION_AUTO_TOPLEVEL. Semantically, > this makes sense because the new tab is content automatically loaded > into a top level frame and the user did not 'type' chrome://newtab. > > This change was made to distinguish between actual direct URL navigations > and opening a new tab when considering whether the Site Engagement Service > should award the origin engagement points. > > BUG=543358 > > Committed: https://crrev.com/d0cdbbbf6653a1ff04dba51558d582035555992b > Cr-Commit-Position: refs/heads/master@{#354404} TBR=msw@chromium.org BUG=543358,582249 Review URL: https://codereview.chromium.org/1650923002 Cr-Commit-Position: refs/heads/master@{#372583} (cherry picked from commit 272612b) Review URL: https://codereview.chromium.org/1653973004 . Cr-Commit-Position: refs/branch-heads/2564@{#651} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

Previously, any time the webview plugin needed to schedule animation, it dirtied layout in the containing frame. This was because it used to be the case that LayoutEmbeddedObject would run the webview plugin's lifecycle as part of layout. However, this is not right, for two reasons: 1. A lifecycle update for later phases may be needed for the plugin due to changes in the parent, even if layout is not dirty. This can lead to not running the webview lifecyle in some cases. https://codereview.chromium.org/1708923002 fixed this by always running the lifecycle of the webview plugin when the parent does. 2. Animation is scheduled for two reasons: lifecyle update, and actual animations, such as issuing resize events to script. It is valid to queue up async script events during a lifecycle update. (In one case in the referenced bug, FrameView:: sendResizeEventIfNeeded does this when it notices that layout changed the size of the frame). This CL fixes cases such as that, and builds up on the one fixing issue #1, by scheduling animation of the parent frame but not dirtying layout. BUG=590856 TBR=tommycli,fsamuel Review URL: https://codereview.chromium.org/1774653002 Cr-Commit-Position: refs/heads/master@{#379694} (cherry picked from commit 78ea22a) Review URL: https://codereview.chromium.org/1770913004 . Cr-Commit-Position: refs/branch-heads/2623@{#594} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

…(patchset #1 id:1 of https://codereview.chromium.org/2834163002/ ) Reason for revert: The introduced SerializeDictionaryForestTest.Stubs is failing on Win, Mac and Linux builders for yet unknown reason. Original issue's description: > Introduce SerializeDictionaryForest for devtools_target_ui > > Currently, LocalTargetsUIHandler::SendTargets contains a very succinct code to > create a base::Value description of a forest of DevToolsAgentHost instances. > One property of base::ListValue which made this code possible was that Values > were stored in unique_ptrs inside ListValue. In particular, passing a value to > ListValue::Append left the previously owning pointer still useful as a weak > pointer. > > That property no longer holds true, because ListValue has been converted to > store Values directly in > https://crrev.com/a5676c607e107238b2d0cdd55e626c93669a92f1. This results in use > of values which have been std::moved, i.e., a kind of use-after-free. What's > worse -- this code is not tested enough for sanitizers to have caught this, and > was already seen in the wild by users of Chrome 59 and 60 as crashes. > > This CL wants to achieve these goals: > * Fix the code to not to rely on implementation details of ListValue. > * Increase unit test coverage of the new code. > * Make the code more explicit and clearer. > > The CL does the following to achieve the above goals: > * It introduces an explicit topological sort of the forest of > DevToolsAgentHosts. This allows to do changes to base::Values before passing > them inside a ListValue, so after calling ListValue::Append it does not > matter what happens to the passed Values. > * The CL also separates the topological sort into a helper function, and adds a > unit test for that. > > The touched code also seemed to create too many scoped_refptr<DevToolsAgentHost> > instances: in cases where there is already a scoped_refptr holding an object > alive outside of the current context, it is better to use just raw pointers in > for loops and argument passing, to avoid unnecessary churn with AddRef/Release > calls. > > Therefore this CL also changed for loops inside of > LocalTargetsUIHandler::SendTargets to use const scoped_refptr& (still avoids > the AddRef/Release churn when raw pointer is not an option) as well as the > argument of DevToolsTargetsUIHandler::Serialize to just a raw pointer. > > BUG=712119 > > Review-Url: https://codereview.chromium.org/2825533002 > Cr-Commit-Position: refs/heads/master@{#465948} > (cherry picked from commit 6681597) > > Review-Url: https://codereview.chromium.org/2834163002 . > Cr-Commit-Position: refs/branch-heads/3071@{#126} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/c8aa0761034792f6739e6b3a1b581231a2ea436a TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=712119 Review-Url: https://codereview.chromium.org/2833283002 Cr-Commit-Position: refs/branch-heads/3071@{#143} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…s deadline." (patchset #1 id:1 of https://codereview.chromium.org/2832503005/ ) Reason for revert: Didn't cause the test failures (see crbug.com/713740) Original issue's description: > Revert "cc: Make scheduler run incoming frame after previous deadline." > > This reverts commit d920c93. > (Reupload from https://chromium-review.googlesource.com/c/482780/ > due to merge conflicts during rebase.) > > Reason for revert: > > Seems to have caused test failures: > https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/9549/layout-test-results/fast/events/pointerevents/pointer-event-consumed-touchstart-in-slop-region-actual.txt > and > https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/9549/layout-test-results/fast/spatial-navigation/snav-z-index-pretty-diff.html > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9549 > > Original change's description: > > cc: Make scheduler run incoming frame after previous deadline. > > > > When removing retro frames I made the incoming frame run the previous > > frame's deadline synchronously. This is believed to have regressed > > Event.Latency.OS.TOUCH_MOVED UMA metric. This CL changes the scheduler > > to queue the incoming frame and post a task for it after the previous > > deadline runs. This is a speculative fix for the UMA regression. > > > > R=enne > > BUG=702372 > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > > > Change-Id: I0d8b0a5df90186b2158e4249540929b9b5ecc70b > > Reviewed-on: https://chromium-review.googlesource.com/478852 > > Reviewed-by: enne <enne@chromium.org> > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#465769} > > TBR=enne@chromium.org,sunnyps@chromium.org,chromium-reviews@chromium.org,cc-bugs@chromium.org,scheduler-bugs@chromium.org > # Not skipping any steps as this is a manual revert. > BUG=702372 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2832503005 > Cr-Commit-Position: refs/heads/master@{#465972} > Committed: https://chromium.googlesource.com/chromium/src/+/95f34789951a95ea306db1b8e9b568696a3cacaa TBR=cc-bugs@chromium.org,chromium-reviews@chromium.org,enne@chromium.org,scheduler-bugs@chromium.org,fhorschig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702372 Review-Url: https://codereview.chromium.org/2828873006 Cr-Commit-Position: refs/heads/master@{#466122} (cherry picked from commit b0fa121) Review-Url: https://codereview.chromium.org/2842583002 . Cr-Commit-Position: refs/branch-heads/3071@{#176} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

… (patchset #4 id:170001 of https://codereview.chromium.org/2809043004/ ) Reason for revert: Causes http://crbug.com/714386 Original issue's description: > Reland of Initialize default audio device ID with explicit device ID. (patchset #1 id:1 of https://codereview.chromium.org/2813543005/ ) > > Reason for revert: > Will attempt to reland by reverting changes in MSM and updating extensions test. > > Original issue's description: > > Revert of Initialize default audio device ID with explicit device ID. (patchset #2 id:20001 of https://codereview.chromium.org/2812903002/ ) > > > > Reason for revert: > > Patchset 2 restores the behavior I wanted to eliminate. > > > > Original issue's description: > > > Initialize default audio device ID with explicit device ID. > > > > > > This is more consistent with how video device IDs are specified and is > > > also a small first step towards implementing the standard constraints > > > algorithm for audio. > > > This CL disables a misleading selector that allows switching the > > > user-preferred device in the middle of a getUserMedia call. > > > Since that selector does not affect the current getUserMedia call, it > > > is better to have it disabled, which is already the case with video > > > devices. > > > > > > BUG=708081 > > > > > > Review-Url: https://codereview.chromium.org/2812903002 > > > Cr-Commit-Position: refs/heads/master@{#463624} > > > Committed: https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d > > > > TBR=hbos@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=708081 > > > > Review-Url: https://codereview.chromium.org/2813543005 > > Cr-Commit-Position: refs/heads/master@{#463634} > > Committed: https://chromium.googlesource.com/chromium/src/+/cf8ea8d590f1c89c2633c793a41bd31a85b3fe72 > > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=708081 > > Review-Url: https://codereview.chromium.org/2809043004 > Cr-Commit-Position: refs/heads/master@{#463710} > Committed: https://chromium.googlesource.com/chromium/src/+/be26518ed4e8a2966c919a93b488689374b17d42 TBR=mek@chromium.org BUG=708081,714386 Review-Url: https://codereview.chromium.org/2829403002 Cr-Commit-Position: refs/heads/master@{#466550} (cherry picked from commit 18633fc) Review-Url: https://codereview.chromium.org/2837873004 . Cr-Commit-Position: refs/branch-heads/3071@{#194} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…machines without TPM. (patchset #1 id:1 of https://codereview.chromium.org/2871673002/ ) Reason for revert: M58 build break. ../../components/login/secure_module_util_chromeos.cc -o obj/components/login/login/secure_module_util_chromeos.o ../../components/login/secure_module_util_chromeos.cc:43:25: error: no member named 'MayBlock' in namespace 'base' FROM_HERE, {base::MayBlock(), base::TaskPriority::BACKGROUND}, Original issue's description: > [Merge to M58]cros: Replace "TPM" with "secure module" for machines without TPM. > > The new reef devices have a chip that is not a TPM so for these we do not want to display TPM strings. For now duplicate the strings since we need to merge to M58 & M59, but a follow up CL should use placeholders in the strings. There are two locations, adding supervised user and OOBE EULA screen. > > TEST=manual > BUG=716671 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2856683002 > Cr-Commit-Position: refs/heads/master@{#469826} > (cherry picked from commit 6dfb54f) > > Review-Url: https://codereview.chromium.org/2871673002 . > Cr-Commit-Position: refs/branch-heads/3029@{#816} > Cr-Branched-From: 939b32e-refs/heads/master@{#454471} > Committed: https://chromium.googlesource.com/chromium/src/+/cb8fbf78eefbcbf4843a4eaded90ce29d2fe5dad TBR=sammiequon@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=716671 Review-Url: https://codereview.chromium.org/2867883002 Cr-Commit-Position: refs/branch-heads/3029@{#820} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

…lt (patchset #1 id:1 of https://codereview.chromium.org/2847633002/ ) Reason for revert: Adjustable large cursor will be enabled by default from M60. Original issue's description: > Merge to M59: Make adjustable large cursor enabled by default > > - Remove flag to enable adjustable large cursor and make it enabled by > default. > > BUG=591493,700256,700260 > TEST=Go to accessibility section of settings, and confirm that > adjustable large cursor is enabled by default. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2814743009 > Cr-Commit-Position: refs/heads/master@{#466271} > (cherry picked from commit 92daff5) > > Review-Url: https://codereview.chromium.org/2847633002 . > Cr-Commit-Position: refs/branch-heads/3071@{#254} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/7908a4575fa95708e3f27724838e9e58bd64b90e TBR=oshima@chromium.org,dbeam@chromium.org,dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591493,700256,700260 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2863413005 Cr-Commit-Position: refs/branch-heads/3071@{#445} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…oSettings dictionary (patchset #1 id:1 of https://codereview.chromium.org/2866053002/ ) Reason for revert: This breaks build ../../third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:570:61: error: function definition is not allowed here media::mojom::blink::PhotoCapabilitiesPtr capabilities) { Sorry, Miguel Original issue's description: > Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary > > This CL: > - Adds an optional PhotoSettings arg to takePhoto(), > > - cleanup: the 3 private methods used to receive mojo callbacks > (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo > prefix, for clarity. > > - adds a |trigger_take_photo| argument to setOptions() and a few > others that pass it along; takePhoto() uses it to setOptions() when > appropriate. The sequence of method calls in ImageCapture.cpp then > would be: > - without options > takePhoto() -> OnMojoTakePhoto() > - with options: > takePhoto(options) -> setOptions(trigger_take_photo == true) --> OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto() > > - methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal() > (which are essentially the same thing) are merged and the resulting > method renamed to UpdateMediaTrackCapabilities() to make more > evident what it does. > > BUG=718632 > > Review-Url: https://codereview.chromium.org/2865563002 > Cr-Commit-Position: refs/heads/master@{#469766} > (cherry picked from commit 3fd00a5) > > Review-Url: https://codereview.chromium.org/2866053002 . > Cr-Commit-Position: refs/branch-heads/3071@{#451} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/dcc52283947a13edbd756eb739ee55a372fa5483 TBR=mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=718632 Review-Url: https://codereview.chromium.org/2872713002 Cr-Commit-Position: refs/branch-heads/3071@{#457} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…hset #1 id:1 of https://codereview.chromium.org/2839083002/ ) Reason for revert: The patch has noting to do with the failing test. In fact if you look at the flakiness dashboard the test is very flaky there: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Finspector%2Ftracing%2Ftimeline-js%2Ftimeline-runtime-stats.html Original issue's description: > Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ ) > > Reason for revert: > Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644 > > Original issue's description: > > DevTools: fix aggregated donut chart cache population > > > > The check for stats cache availablity was made on the first task in the main thread > > tasks list. If the first task happens to be filtered out, it never gets cache built for > > it. Later the cache presence check would look for a cache on the first task, never find > > it and forces recaching. > > > > BUG=714934 > > > > Review-Url: https://codereview.chromium.org/2840463003 > > Cr-Commit-Position: refs/heads/master@{#467114} > > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2 > > TBR=pfeldman@chromium.org,alph@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=714934 > > Review-Url: https://codereview.chromium.org/2839083002 > Cr-Commit-Position: refs/heads/master@{#467223} > Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f TBR=pfeldman@chromium.org,sashab@chromium.org BUG=714934 Review-Url: https://codereview.chromium.org/2851823002 Cr-Commit-Position: refs/heads/master@{#468119} (cherry picked from commit 2e2708b) Review-Url: https://codereview.chromium.org/2867873002 . Cr-Commit-Position: refs/branch-heads/3071@{#460} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…on (patchset #1 id:1 of https://codereview.chromium.org/2853213002/ ) Reason for revert: Hmm, interestingly enough, the tests were still broken in the build which had the revert: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/1512 So I am relanding it. Original issue's description: > Revert of Make InsertTextCommand not to apply style for empty selection (patchset #1 id:1 of https://codereview.chromium.org/2847763004/ ) > > Reason for revert: > Speculative revert, this seems to have broken some virtual/gpu/fast/canvas/ tests. More info on the associated bug. > > BUG=717389 > > Original issue's description: > > Make InsertTextCommand not to apply typing style for empty selection > > > > This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for > > applying typing style when selection after inserting text is empty since > > |ApplyStyle()| doesn't work with empty selection. > > > > The issue 714311 and the attached test case insert text into OPTION element to > > get empty selection after insertion, since we can't place selection inside > > OPTION element. > > > > BUG=714311 > > TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle > > > > Review-Url: https://codereview.chromium.org/2847763004 > > Cr-Commit-Position: refs/heads/master@{#468080} > > Committed: https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b015232663b4fcd87 > > TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=714311 > > Review-Url: https://codereview.chromium.org/2853213002 > Cr-Commit-Position: refs/heads/master@{#468590} > Committed: https://chromium.googlesource.com/chromium/src/+/5c9d124ac2131f4765f86902ff4cf711ed96c37e TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717389 Review-Url: https://codereview.chromium.org/2854123002 Cr-Commit-Position: refs/heads/master@{#468642} (cherry picked from commit 6192661) Review-Url: https://codereview.chromium.org/2872243002 . Cr-Commit-Position: refs/branch-heads/3071@{#499} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…https://codereview.chromium.org/2867363002/ ) Reason for revert: We want to reenable the feature by default on M59. Original issue's description: > 📺 Disable Video Persistence by default. > > BUG= > NOTRY=true > NOPRESUBMIT=true > TBR=mlamour@chromium.org > > Review-Url: https://codereview.chromium.org/2869773002 > Cr-Commit-Position: refs/heads/master@{#469986} > (cherry picked from commit 458ebb2) > > Review-Url: https://codereview.chromium.org/2867363002 > Cr-Commit-Position: refs/branch-heads/3071@{#477} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/51168ad0a8daa37fabcbded38ef7c3a40c9ca493 TBR=mlamouri@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOTRY=true NOPRESUBMIT=true TBR=mlamour@chromium.org Review-Url: https://codereview.chromium.org/2873973003 Cr-Commit-Position: refs/branch-heads/3071@{#500} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…egative. (patchset #1 id:1 of https://codereview.chromium.org/2876033004/ ) Reason for revert: Didn't handle a merge conflict well. Original issue's description: > TabManager: Do not overkill when target memory to free is negative. > > BUG=chrome:713944 > TEST=samus > > Review-Url: https://codereview.chromium.org/2843633002 > Cr-Original-Commit-Position: refs/heads/master@{#467044} > Review-Url: https://codereview.chromium.org/2876033004 . > Cr-Commit-Position: refs/branch-heads/3071@{#530} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/fca840d27869f026f8b31657c4853c8b9ee2fbd7 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chrome:713944 Review-Url: https://codereview.chromium.org/2876243003 Cr-Commit-Position: refs/branch-heads/3071@{#533} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…ve fullscreen. (patchset #1 id:1 of https://codereview.chromium.org/2900593003/ ) Reason for revert: Breaks build ../../chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java:621: error: cannot find symbol if (mBrandColor != null && mWebappInfo.displayMode() != WebDisplayMode.FULLSCREEN) { Original issue's description: > Don't use the manifest brand color when a PWA is in immersive fullscreen. > > When in display: fullscreen, the status and navigation bars on Android > are hidden, and can be swiped in by users if desired. The bars also > appear if the on-screen keyboard is triggered. However, the bars > sometimes appear as completely transparent, which hurts their usability. > > This CL explicitly sets the status bar color to black if a PWA is launched > in display: fullscreen, and ignores the brand color specified in the web > app manifest. This ensures that the status and navigation bars always > have a solid black background and do not appear as transparent. Since > PWAs that are open in display: fullscreen have the bars hidden most of > the time, having a black color does not overly affect the native fit and > feel too much. > > BUG=714704,716686 > > Review-Url: https://codereview.chromium.org/2871103002 > Cr-Original-Commit-Position: refs/heads/master@{#470762} > Review-Url: https://codereview.chromium.org/2900593003 . > Cr-Commit-Position: refs/branch-heads/3071@{#646} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/8fc052bc58d3adbc8c6f6e13109da6e733f8ee20 TBR=dominickn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714704,716686 Review-Url: https://codereview.chromium.org/2893413002 Cr-Commit-Position: refs/branch-heads/3071@{#657} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…widget.MediaController. (patchset #1 id:1 of https://codereview.chromium.org/2888273002/ ) Reason for revert: Caused https://bugs.chromium.org/p/chromium/issues/detail?id=725028 and is not needed for 59 yet. NOTRY=true NOPRESUBMIT=true Original issue's description: > [Cast,Android] Replace custom MediaController with android.widget.MediaController. > > BUG=722688 > TEST=manual (cast a video from Chrome and tap on the notification, test the fullscreen controls) > > Review-Url: https://codereview.chromium.org/2888653002 > Cr-Original-Commit-Position: refs/heads/master@{#472583} > Review-Url: https://codereview.chromium.org/2888273002 . > Cr-Commit-Position: refs/branch-heads/3071@{#613} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/eda6f4cf4ff69bea98350b37c43609fae020175c TBR= # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=722688 Review-Url: https://codereview.chromium.org/2899033002 Cr-Commit-Position: refs/branch-heads/3071@{#673} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…in. (patchset #1 id:1 of https://codereview.chromium.org/2910253002/ ) Reason for revert: Looks this broke the stable builder. https://bugs.chromium.org/p/chromium/issues/detail?id=727996 Original issue's description: > M59: Linux: Make manual libnss3 version dependency work again. > > When libnss3 is specified as a dependency both manually and via > dpkg-shlibdeps, only the dpkg-shlibdeps dependency actually makes it > into the .deb file's Depends section. To work around this, remove the > entry generated by dpkg-shlibdeps, after comparing it to expectations. > > This used to work, but something changed during the Jessie sysroot > update. > > BUG=691261,726858 > > Review-Url: https://codereview.chromium.org/2903253005 > Cr-Original-Commit-Position: refs/heads/master@{#475215} > Review-Url: https://codereview.chromium.org/2910253002 . > Cr-Commit-Position: refs/branch-heads/3071@{#722} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/ce1be06c2ea023c7a41852a9002fdb5cc690bc80 TBR=thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691261,726858 Review-Url: https://codereview.chromium.org/2913103003 Cr-Commit-Position: refs/branch-heads/3071@{#728} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…ry. (patchset #1 id:1 of https://codereview.chromium.org/2922993003/ ) Reason for revert: Compile failure for build 59.0.3071.92 Original issue's description: > [merge to m59]cros: Push messaging service impl crash fix try. > > It seems that notification related crash is fixed, I do not see notification > manager in the stack traces anymore. For push messaging impl I believe something > similar is happening, that is the chrome OS keep alive is being released, > then push message is coming in before the browser starts to shutdown. This CL > adds a flag if the application has started to terminate, and does not allow > processing of messages that come in after chrome OS keep alive is released. > > TEST=browser_tests --gtest_filter="PushMessagingBrowserTest.PushEventOnShutdown" > BUG= 722948 > > Review-Url: https://codereview.chromium.org/2859093005 > Cr-Original-Commit-Position: refs/heads/master@{#473126} > Review-Url: https://codereview.chromium.org/2922993003 . > Cr-Commit-Position: refs/branch-heads/3071@{#746} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/34f4b2eac62969d22571674e6512b5a27153d64e TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 722948 Review-Url: https://codereview.chromium.org/2928613002 Cr-Commit-Position: refs/branch-heads/3071@{#751} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…hset #1 id:1 of https://codereview.chromium.org/2919973003/ ) Reason for revert: The original patch does fix the bug. Original issue's description: > Revert of Change default minimum screencast frame rate to zero. (patchset #1 id:1 of https://codereview.chromium.org/2918113002/ ) > > Reason for revert: > Does not properly fix the bug. > > Original issue's description: > > Change default minimum screencast frame rate to zero. > > > > This is causing issues with refresh-interval computations that > > treat zero as a special value and expect zero as the default > > minimum, as it was with the old constraints algorithm. > > > > BUG=725696 > > > > Review-Url: https://codereview.chromium.org/2918113002 > > Cr-Commit-Position: refs/heads/master@{#476728} > > Committed: https://chromium.googlesource.com/chromium/src/+/9d5685faf6178778aaec42384e4c3f81890799b5 > > TBR=hbos@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=725696 > > Review-Url: https://codereview.chromium.org/2919973003 > Cr-Commit-Position: refs/heads/master@{#476836} > Committed: https://chromium.googlesource.com/chromium/src/+/56ed98a48e61f1ba075a5352939155379f21b2c2 TBR=hbos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=725696 Review-Url: https://codereview.chromium.org/2921123002 Cr-Original-Original-Commit-Position: refs/heads/master@{#476899} Review-Url: https://codereview.chromium.org/2929573002 . Cr-Original-Commit-Position: refs/branch-heads/3112@{#218} Cr-Original-Branched-From: b6460e2-refs/heads/master@{#474897} Review-Url: https://codereview.chromium.org/2935013002 . Cr-Commit-Position: refs/branch-heads/3071@{#781} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

…eateKeyboard. (patchset #1 id:1 of https://codereview.chromium.org/2964083002/ ) Reason for revert: I resolved a merge conflict in a wrong way, and it wouldn't compile. Original issue's description: > Ash: Inline InitKeyboard, and make the caller of it call CreateKeyboard. > > InitKeyboard creates a keyboard controller but doesn't associate it with any > root window controller. It's potentially problematic if > keyboard::ShowKeyboard is called before RootWindowController::ActivateKeyboard. > > Bug: 712873 > > Change-Id: I5b34cd6f8b9e1b0736b5d91880e3aedc9d57970c > Reviewed-on: https://chromium-review.googlesource.com/535221 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Keigo Oka <oka@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#480313} > Review-Url: https://codereview.chromium.org/2964083002 . > Cr-Commit-Position: refs/branch-heads/3112@{#492} > Cr-Branched-From: b6460e2-refs/heads/master@{#474897} > Committed: https://chromium.googlesource.com/chromium/src/+/9d3867c09566a7e9f3eae92524db0237c14b0c94 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2969483002 Cr-Commit-Position: refs/branch-heads/3112@{#493} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

…incognito. (patchset #1 id:1 of https://codereview.chromium.org/2972443002/ ) Reason for revert: breaking build BUG=738764 TEST=build with revert for caroline. NOTRY=true NOPRESUBMIT=true Original issue's description: > Merge M60: Remove incognito advice from Sad Tab if already incognito. > > Also, simplify string generation code to use a vector rather than > const array and special case. > > BUG=735532 > TEST=Repeat crashes when not in Incognito mode show the advice to try > Incognito mode. However the same test performed when in Incognito mode > should not offer this advice as one of the bullet points. > > Review-Url: https://codereview.chromium.org/2959723002 > Cr-Original-Commit-Position: refs/heads/master@{#482945} > Review-Url: https://codereview.chromium.org/2972443002 . > Cr-Commit-Position: refs/branch-heads/3112@{#504} > Cr-Branched-From: b6460e2-refs/heads/master@{#474897} > Committed: https://chromium.googlesource.com/chromium/src/+/d91f244b3ced94b3dc82f9e8f4237cbbdb8c0876 TBR=wfh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=735532 Review-Url: https://codereview.chromium.org/2969033002 Cr-Commit-Position: refs/branch-heads/3112@{#510} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

…https://codereview.chromium.org/2959193002/ ) Reason for revert: One platform check was still in place which causes the current Beta to fail compilation. In order to keep the history intact, we revert the disabling, fix the bug and disable again. Original issue's description: > Disable baked-in popular sites for iOS. > > The launch of this feature has been postponed. > As Finch does not guarantee that this feature is disabled, > disable it in the code. > (Reenabling this feature will happen after disabling was merged to M60). > > BUG=737607 > > Review-Url: https://codereview.chromium.org/2959193002 > Cr-Commit-Position: refs/heads/master@{#483677} > Committed: https://chromium.googlesource.com/chromium/src/+/61b617a08bebd805857faae0eaefed7315b5fdcd TBR=fhorschig@chromium.org, sfiera@chromium.org BUG=737607 (cherry picked from commit 0380078) Review-Url: https://codereview.chromium.org/2962363002 Cr-Original-Commit-Position: refs/heads/master@{#483963} Change-Id: I8b5baa7629c87d5c4bded8d1e70a4eb60b41fe20 Reviewed-on: https://chromium-review.googlesource.com/566858 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#577} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}

TBR=dimu@chromium.org Change-Id: I18a5540ba1531b300a9c0026ab19c1c681599a34 Reviewed-on: https://chromium-review.googlesource.com/579850 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

changes: new specs require removing suggested apps indicator, specs: peeking: https://screenshot.googleplex.com/QNw4VjLHD5e fullscreen page #1: https://screenshot.googleplex.com/OT0NmfnByWg fullscreen page #2: https://screenshot.googleplex.com/7PC0iytVXHq fullscreen page#01: https://screenshot.googleplex.com/NJiyTFFzqKW fullscreen page#02: https://screenshot.googleplex.com/8Dh1Z1YC3aA TBR=warx@chromium.org (cherry picked from commit dce53c5) screenshot: peeking: https://screenshot.googleplex.com/tMxgChqhrSm Test: test with fullscreen app list flag enabled Bug: 750292 Change-Id: I841342e95101e54ae7e022383ecbfbe56c503e2d Reviewed-on: https://chromium-review.googlesource.com/606997 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492775} Reviewed-on: https://chromium-review.googlesource.com/611300 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#468} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

It's possible for BrowserAssociatedInterface's InternalState to have Initialize invoked after ClearBindings, which can in turn lead to a violation of the assumption that ClearBindings ensures no future message dispatches to the bound implementation. This can occur in the following rare but plausible scenario for a type X which inherits BrowserAssociatedInterface<T>: 1. Post task to IO thread which may destroy some yet-uncreated instance x of type X (e.g. maybe it posts a render process ID and we'll later have an X associated with that RPH) 2. Create x as an instance of type X (posts an IO thread task to Initialize x's Internal State) 3. Interface request is received, posting an IO thread task to bind a handle to x. 3. Task from #1 executes, locating and deleting x; resetting InternalState bindings (not yet initialized anyway). 4. Task from #2 executes, initializing the InternalState bindings. 5. Task from #3 executes, bindings a handle to the InternalState 6. Message is received on the bound handle, dispatched to deleted x 7. UAF! As it turns out, AssociatedBindingSet does not own any thread-affine state upon default construction; therefore it can be created on any thread as long as it's subsequently used and destroyed from a single thread. Since InternalState already guarantees those conditions, this CL simply removes the async Initialize step. BUG=753672 R=jam@chromium.org TBR=rockot@chromium.org (cherry picked from commit 201a233) Change-Id: Id603fb57d412daf3741b61f7857a29edeaac5443 Reviewed-on: https://chromium-review.googlesource.com/610924 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493797} Reviewed-on: https://chromium-review.googlesource.com/617516 Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#606} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

TBR=dimu@chromium.org Change-Id: I68f20700013b59a429ab17d0675e9f94a5532259 Reviewed-on: https://chromium-review.googlesource.com/646294 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#1} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

TBR=dimu@chromium.org Change-Id: Ia5195776131003828a884c13f606c2fd295bf0f8 Reviewed-on: https://chromium-review.googlesource.com/717977 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#1} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

TBR=dimu@chromium.org Change-Id: Ia42d50498714698752b115a2e252e5fd0b3a0935 Reviewed-on: https://chromium-review.googlesource.com/874901 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#1} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

TBR=dimu@chromium.org Change-Id: I30a5d107b3fa0b3189a292ec7ccc2d89fe855136 Reviewed-on: https://chromium-review.googlesource.com/945490 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#1} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

TBR=dimu@chromium.org Change-Id: Iec13ac1d4a2554533c532228da9bdfc0b0d8ba18 Reviewed-on: https://chromium-review.googlesource.com/1011802 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#1} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

…cted" This is a reland of 4a696ac Patch #1 contains the patch originally landed, please check the diff against it to review the fix. The original patch broke interactive UI tests on ChromeOS, because of a mouse exit event being fired when the dropdown was closed; event handling could happen after Hide() set the delegate to false. TBR=groby@chromium.org Original change's description: > This fixes crbug.com/835019, in which the current suggestion may not > be cleared when the mouse exits the popup area, by reusing the > OnMouseExited handler implemented by AutofillPopupBaseView and > overriden by AutofillPopupViewNativeViews as empty. > > The current implementation posts a task that will be a no-op if the > mouse leaves the popup and there is no suggestion selected, so this > is a safe change. > > Bug: 835019 > Change-Id: I99339d377090721719ed6c7d026f7832a0503e4d > Reviewed-on: https://chromium-review.googlesource.com/1070788 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564070} (cherry picked from commit 360d661) Bug: 835019 Change-Id: I99339d377090721719ed6c7d026f7832a0503e4d Reviewed-on: https://chromium-review.googlesource.com/1087008 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#564549} Reviewed-on: https://chromium-review.googlesource.com/1092314 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#259} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

There are two ways Chrome detects the presence of assistive technology in order to enable accessibility support on Windows: 1. We fire an EVENT_SYSTEM_ALERT event on a "honeypot" window, if it's queried we enable accessibility. 2. We check for QueryService to be called with IID_IAccessible2, since that's only used by screen readers. Option #1 seems to be catching many users who don't actually need accessibility enabled. This change skips enabling accessibility unless get_accName is also called. Bug: 878072,877208 TBR: jochen@chromium.org Change-Id: I5f36c632822faa607d301d543b7ed8d630e835fe Reviewed-on: https://chromium-review.googlesource.com/1192062 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#586470}(cherry picked from commit 641225c) Reviewed-on: https://chromium-review.googlesource.com/1193852 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#830} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

Pressing the skip button leads to two LoginDisplayHost::Finalize() calls, which causes a double deletion eventually leading to a crash. The PIN setup skip button triggers two 'discover-done' events (fired in discover_ui.js::end_), and the observer in screen_discover.js sends a finished user action whenver it receives a discover-done event. Discover should not be sending discover-done twice. This CL just prevents the crash. Finalize #1 at HTMLElement.end_ at HTMLElement.fire at HTMLElement.onSkipButton_ at HTMLElement.onAuthTokenChanged_ at HTMLElement._observerEffect at HTMLElement._effectEffects at HTMLElement._propertySetter at HTMLElement.setter at HTMLElement.onSkipButton_ at HTMLElement.handler Finalize #2 at HTMLElement.end_ at HTMLElement.fire at HTMLElement.onSkipButton_ at HTMLElement.handler at HTMLElement.fire at Object.fire at Object.forward at Object.click at HTMLElement.handleNative TBR=jdufault@google.com (cherry picked from commit 41254eb) Bug: 895250 Change-Id: I784ee5ef0ecfc5bffad515973451331bfc0aee3f Reviewed-on: https://chromium-review.googlesource.com/c/1299145 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602880} Reviewed-on: https://chromium-review.googlesource.com/c/1308414 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#409} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

rogerwang force-pushed the nw13 branch 2 times, most recently from 54b3d11 to 2665eb5 Compare February 11, 2016 05:41

rogerwang force-pushed the nw13 branch 8 times, most recently from 8fcc75f to db92456 Compare February 19, 2016 03:01

rogerwang force-pushed the nw13 branch 2 times, most recently from ec121b9 to 954f9e5 Compare February 22, 2016 09:28

rogerwang force-pushed the nw13 branch 2 times, most recently from d77fa71 to 4bbe944 Compare February 24, 2016 08:54

rogerwang force-pushed the nw13 branch 2 times, most recently from 85293a8 to 9285daa Compare March 2, 2016 04:52

janRucka closed this Mar 2, 2016

janRucka force-pushed the nw13 branch from c214384 to 9285daa Compare March 2, 2016 15:44

jtg-gg referenced this pull request in jtg-gg/chromium.src Mar 7, 2016

Incrementing VERSION to 48.0.2564.1

b2364d7

Cr-Commit-Position: refs/branch-heads/2564@{#1} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPS issue fix #1

DEPS issue fix #1

janRucka commented Feb 5, 2016

DEPS issue fix #1

DEPS issue fix #1

Conversation

janRucka commented Feb 5, 2016