Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mac] Use dsymutil to generate real .dSYM file #8

Closed
wants to merge 2 commits into from
Closed

[mac] Use dsymutil to generate real .dSYM file #8

wants to merge 2 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Mar 15, 2016

By default, Chrome will generate a fake .dSYM file which doesn't
contain well-formed debugging info.

Fixed nwjs/nw.js#4450

rogerwang and others added 2 commits March 15, 2016 07:33
@rogerwang
nwjs master
35715c5
[mac] Use dsymutil to generate real .dSYM file
7b6b784 
By default, Chrome will generate a fake .dSYM file which doesn't
contain well-formed debugging info.

Fixed nwjs/nw.js#4450
@ghostoy
Copy link
Member Author

ghostoy commented Mar 15, 2016

This patch will slow down the building time of release target.

@rogerwang
Copy link
Member

This is now done by setting mac_breakpad = 1

@rogerwang rogerwang closed this Mar 18, 2016
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
ChromeOS OOBE: switch from iron-dropdown to <select>.
b597dbf 
To fix several issues with polymer dropdown menu by switching to native select.

BUG=604119,663267
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2502773003
Cr-Commit-Position: refs/heads/master@{#433137}
(cherry picked from commit 076cf8a)

Review URL: https://codereview.chromium.org/2512393002 .

Cr-Commit-Position: refs/branch-heads/2924@{#8}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
Fix fullscreen browser overrides when no tab is present.
4431066 
If a client requests the top controls be made visible via
the BrowserStateBrowserControlsVisibilityDelegate but no
tabs are available, the fullscreen manager should force
the controls to be visible anyway.

This fixes an issue where you only have a single incognito
tab, scroll off the top controls, then hit the close all
incognito tabs notification.  At this point, you are jumped
back to the tab switcher but the controls were not being
shown without this additional logic.

BUG=675518

Review-Url: https://codereview.chromium.org/2647943002
Cr-Original-Commit-Position: refs/heads/master@{#445157}
Review-Url: https://codereview.chromium.org/2642263005 .
Cr-Commit-Position: refs/branch-heads/2987@{#8}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
Incrementing VERSION to 58.0.3029.4
1a6ab94 
Cr-Commit-Position: refs/branch-heads/3029@{#8}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Incrementing VERSION to 59.0.3071.6
efe1a7b 
Cr-Commit-Position: refs/branch-heads/3071@{#8}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
rogerwang pushed a commit that referenced this pull request Jul 20, 2017
Revert "Listen to changes to touch input devices"
6b860e9 
This reverts commit 1b60006.

Reason for revert:
Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash.

Failing build (chromeos-side waterfall):
https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205

Stack (from running manually with chrome --mash on Linux):

[60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created.
#0 0x7f06a03468bc base::debug::StackTrace::StackTrace()
#1 0x7f06a036a121 logging::LogMessage::~LogMessage()
#2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance()
#3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl()
#4 0x55f1834066ad chromeos::ShowLoginWizard()
#5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize()
#6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit()
#7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun()
#9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun()
#11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow()
#12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks()
#13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize()
#14 0x7f069d9e0b57 content::BrowserMain()
#15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run()
#16 0x7f06a0890d39 service_manager::Main()
#17 0x7f069e1e7384 content::ContentMain()
#18 0x55f182e8132f ChromeMain
#19 0x7f069454af45 __libc_start_main
#20 0x55f182e81194 <unknown>

Original change's description:
> Listen to changes to touch input devices
>
> In https://codereview.chromium.org/2964823002 the OobeDisplayChooser
> started using the DeviceDataManager to look for touchscreen devices when
> searching for a good primary display to use during OOBE.
>
> On device cold boot the DeviceDataManager has not yet found any
> touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely
> due to lower level systems not being fully initialized).
>
> This CL make LoginDisplayHostImpl an observer of changes to connected
> touchscreen devices, re-triggering the OobeDisplayChooser when the
> DeviceDataManager is notified of the connected touchscreens. This
> overcomes the timing issues on cold boot.
>
> Bug: 738885
> Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd
> Reviewed-on: https://chromium-review.googlesource.com/569958
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487007}

TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

(cherry picked from commit 0cd134a)

Bug: 738885
Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4
Reviewed-on: https://chromium-review.googlesource.com/574731
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#487191}
Signed-off-by: Bernie Thompson <bhthompson@google.com>
Reviewed-on: https://chromium-review.googlesource.com/575149
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#623}
Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Incrementing VERSION to 61.0.3163.8
83419ea 
TBR=dimu@chromium.org

Change-Id: Ica643e264a7fb6be736758a0278acac8af9bf38b
Reviewed-on: https://chromium-review.googlesource.com/582394
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#8}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
[Merge M62] android: Trim instead of reset program cache on background
5228eb8 
Deleting the program cache is not safe because not all channels are
closed before hand. There's specific check for leaving webgl context
behind. Those context would be using a dangling program cache pointer
after that.

Bug: 756497
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I28b23f66049a92dae9fe4490f0850d2207f07f9f
Reviewed-on: https://chromium-review.googlesource.com/646238
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499112}(cherry picked from commit d65c983)
Reviewed-on: https://chromium-review.googlesource.com/648227
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#8}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@chrishtr
Allow for paint offset roots that don't have PaintLayers.
264b84e 
LayoutSVGRoot is not always a stacking context at present,
so it does not always have a PaintLayer.

TBR=chrishtr@chromium.org

(cherry picked from commit 68c4cdb)

Bug: 773198
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia146f3a90512b98de961bd1f243b9e8439c6d382
Reviewed-on: https://chromium-review.googlesource.com/717564
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508817}
Reviewed-on: https://chromium-review.googlesource.com/719586
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#8}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
Incrementing VERSION to 65.0.3325.7
6437276 
TBR=dimu@chromium.org

Change-Id: Ie09cee4b6e864c8d64bd99fe8b7f414cbf725bc4
Reviewed-on: https://chromium-review.googlesource.com/877089
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#8}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
Incrementing VERSION to 66.0.3359.8
244f71a 
TBR=dimu@chromium.org

Change-Id: Ica075166dde668c0fa2027e1653df619010969d1
Reviewed-on: https://chromium-review.googlesource.com/947774
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#8}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Create a new extension API for enterprise browser reporting.
8e87f21 
It introduces new permission, IDL and skeleton of implementation.

This privacy API is used to upload browsers and devices status that
are collected by extension to the admin console.


Bug: 832887
Change-Id: I60780d76c9e7680843acef38ce906e9cbe150025
Reviewed-on: https://chromium-review.googlesource.com/976819
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550521}(cherry picked from commit fdada01)
Reviewed-on: https://chromium-review.googlesource.com/1013340
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#8}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Incrementing VERSION to 68.0.3440.5
3cba819 
TBR=mmoss@chromium.org

Change-Id: I874a2f876dff1f03cf649f795df697523b9807e6
Reviewed-on: https://chromium-review.googlesource.com/1074533
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#8}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
Incrementing VERSION to 69.0.3497.5
d50da19 
TBR=mmoss@chromium.org

Change-Id: I37d7747b525ad4a2f6628f628828b163cae90b5a
Reviewed-on: https://chromium-review.googlesource.com/1146204
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#8}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
Incrementing VERSION to 70.0.3538.3
08f0d12 
TBR=govind@chromium.org

Change-Id: I760b8b198e1e49a692c451ca8be96dedecf45be2
Reviewed-on: https://chromium-review.googlesource.com/1200589
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#8}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Incrementing VERSION to 71.0.3578.5
f925b64 
TBR=abdulsyed@chromiue.org

Change-Id: I05d1740eb1eab049f858c089393dff94bf93729e
Reviewed-on: https://chromium-review.googlesource.com/c/1279369
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#8}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@sebsg
Merge-72 [AF] Check comp.name flag when showing address in settings ios
5928de1 
  Before this CL, when autofilling addresses, the company name was always
filled in if it was specified as part of a country's address fields.

  However, we want to remove the company field from autofill. This is being
rolled out via a Flag and finch config.

  The initial CL that addressed this in https://crrev.com/c/1315536 did not
change to IOS settings, but this CL updates the IOS code to
filter out the company field in settings addresses based on the flag.


TBR=jeffreycohen@chromium.org

(cherry picked from commit 7125779)

Bug: 890972
Change-Id: I179ccfd9cf0cef9eaa9f80cd0c2b7353dd5c8f9a
Reviewed-on: https://chromium-review.googlesource.com/c/1351282
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612729}
Reviewed-on: https://chromium-review.googlesource.com/c/1358699
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#8}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@mohamedamir
[Sync] Fix for Password Sync on Linux
8a6e672 
This is partial revert for the https://crrev.com/c/1424941 that broke
Passwords Sync on Liux.

Bug: 925302
Change-Id: I8c19a1c8507cb9ec57f32012aad7e99e8e8b9b0d
Reviewed-on: https://chromium-review.googlesource.com/c/1436364
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626064}(cherry picked from commit 4467d74)
Reviewed-on: https://chromium-review.googlesource.com/c/1437207
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#8}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
[M74 merge] app_list: Handle stylus in embedded Assistant Ui
0facb2c 
This patch adds the support to handle stylus in embedded Assistant Ui.
Because this attempt is temporary and no UX is specified, we will show a
toast instead implementing a mini view for embedded mode.

TBR=xiyuan@chromium.org,xiaohuic@chromium.org

Bug: 924624
Test: manual
Change-Id: I7a6c971d1ef49a1b759ddab5a0f6962195805662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507119
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#638957}(cherry picked from commit 63b7ec453380483702fd357dfff2152560c4ca03)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513041
Cr-Commit-Position: refs/branch-heads/3729@{#8}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghostoy @rogerwang