Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups #5

Closed
wants to merge 3 commits into from
Closed

Fixups #5

wants to merge 3 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Mar 8, 2016

  • use nw.Window.open to create first window
  • fix crash of chrome.app.window.create(url) without 2nd argument

chrome-tpm and others added 3 commits March 1, 2016 17:37
Publish DEPS for Chromium 49.0.2623.75
9909a1c
@rogerwang
nwjs master
43cb767
Fixups
50b7450 
* use `nw.Window.open` to create first window
* fix crash of `chrome.app.window.create(url)` without 2nd argument
@ghostoy
Copy link
Member Author

ghostoy commented Mar 15, 2016

I'm closing it and split into two patches.

@ghostoy ghostoy closed this Mar 15, 2016
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@sunnyps
Revert of WebFonts cache-aware timeout adaptation (patchset #15 id:27…
8dd4d6d 
…0001 of https://codereview.chromium.org/2453813004 )

Reason for revert:
Top canary crasher
https://bugs.chromium.org/p/chromium/issues/detail?id=666227

Original issue's description:
> WebFonts cache-aware timeout adaptation
>
> This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
> of Unstyled Text (FOUT) if webfont is already available in disk cache. This is
> available as a experimental Web Platform feature.
>
> In webfont display, fallback font will be used if webfont loading time exceeds
> certain timeout values in slow network. However it's observed that disk cache
> RTT may also hit the timeout regardless of network speed. In such cases we would
> like to block display until disk cache misses and actual network request is
> being sent.
>
> BUG=570205
> Committed: https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e
> Cr-Commit-Position: refs/heads/master@{#432425}

TBR=shaochuan@chromium.org,tkent@chromium.org,ksakamoto@chromium.org,isherman@chromium.org,yhirano@chromium.org
BUG=666227,570205

Review-Url: https://codereview.chromium.org/2512773002
Cr-Commit-Position: refs/heads/master@{#433067}
(cherry picked from commit 9112036)

Review URL: https://codereview.chromium.org/2511783004 .

Cr-Commit-Position: refs/branch-heads/2924@{#5}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@estark37
Reland of Post tasks for sensitive input visibility notifications (pa…
f2d5322 
…tchset #1 id:1 of https://codereview.chromium.org/2531683002/ )

Reason for revert:
Fixing SecuritySTateTabHelperTests

Original issue's description:
> Revert of Post tasks for sensitive input visibility notifications (patchset #5 id:80001 of https://codereview.chromium.org/2515373003/ )
>
> Reason for revert:
> Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10
>
> E.g.
> SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
> SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch
>
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/24682
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/9716
>
> Errors like
>
> ../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
> Value of: security_info.security_level
>   Actual: 0
> Expected: security_state::HTTP_SHOW_WARNING
> Which is: 1
> ../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
> Value of: entry->GetSSL().content_status & content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
>   Actual: false
> Expected: true
>
> Original issue's description:
> > Post tasks for sensitive input visibility notifications
> >
> > If password inputs are hidden and shown multiple times in the same task
> > (as apparently happens when processing a stylesheet), we don't want to
> > the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> > input visibility notifications to the end of the task queue, so that the
> > omnibox warning updates get coalesced.
> >
> > BUG=664194
> > TEST=Visit http://http-password.badssl.com and observe that the omnibox
> > warning does not flicker in and out twice.
> >
> > Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> > Cr-Commit-Position: refs/heads/master@{#434340}
>
> TBR=dcheng@chromium.org,haraken@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664194
>
> Committed: https://crrev.com/e0c7eb5a36b45db9a17c75715a99b3a547c45974
> Cr-Commit-Position: refs/heads/master@{#434400}

TBR=dcheng@chromium.org,haraken@chromium.org,tapted@chromium.org
BUG=664194

Review-Url: https://codereview.chromium.org/2538473002
Cr-Commit-Position: refs/heads/master@{#434820}
(cherry picked from commit d262a0e)

Review URL: https://codereview.chromium.org/2536203004 .

Cr-Commit-Position: refs/branch-heads/2924@{#195}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
rogerwang pushed a commit that referenced this pull request Dec 15, 2016
Revert of Support margin-top for legend in fieldset. (patchset #5 id:…
57e2b1d 
…80001 of https://codereview.chromium.org/2396813002/ )

Reason for revert:
need to revert the previously landed patch http://crrev.com/415577 that blocks the release

Original issue's description:
> Support margin-top for legend in fieldset.
>
> The implementation aligns with Edge, Gecko centers the legend+margins, which
> looks undesirable to me.  The specs say nothing about this.
>
> The new behaviour causes two tests to change, both have been rebaselined. One
> was additionally modified to not trigger the scrollbar, which in turn would
> render differently on various platforms.
>
> BUG=554077
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/462e2f8e1a0f0a09efa7c8bcc34da36fd7b532ca
> Cr-Commit-Position: refs/heads/master@{#425127}

TBR=eae@chromium.org,karlo@opera.com
BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2558683002
Review-Url: https://codereview.chromium.org/2567543002 .
Cr-Original-Commit-Position: refs/heads/master@{#436891}
Cr-Commit-Position: refs/branch-heads/2924@{#425}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
Revert of [Sync] Make directory types registration explicit in ModelT…
6170942 
…ypeRegistry (patchset #3 id:40001 of https://codereview.chromium.org/2641523004/ )

Reason for revert:
This change causes crashes in sync: http://crbug.com/682998

Original issue's description:
> [Sync] Make directory types registration explicit in ModelTypeRegistry
>
> The goal of this change is to make registration of directory types with
> ModelTypeRegistry to be driven by individual data type controllers. Today set of
> directory data types are registered with single call to
> SetEnabledDirectoryTypes, they are derived from routing info passed through
> sync manager and scheduler.
>
> Since datatype registration will be performed as separate posts to sync thread
> it is important to switch scheduler to configuration mode at the beginning of
> configuration.
>
> In this change I:
> - Added Register/UnregisterDirectoryType to ModelTypeConnector and
>   ModelTypeRegistry.
> - Removed SetEnabledDirectoryTypes form ModelTypeRegistry as it is no longer
>   needed.
> - Added StartConfiguration to SyncEngine. This method needs to be called before
>   RegisterDirectoryDataType are called so that normal sync cycle doesn't get
>   executed on sync thread and doesn't include new datatypes before their
>   services are ready to receive updates.
> - Added BeforeLoadModels method to DataTypeController. This method is called
>   right before LoadModels and allows directory datatypes to register with sync
>   engine before initial data downloading begins.
>
> BUG=647505
> R=maxbogue@chromium.org
>
> Review-Url: https://codereview.chromium.org/2641523004
> Cr-Commit-Position: refs/heads/master@{#444846}
> Committed: https://chromium.googlesource.com/chromium/src/+/1c7af89ea2d8e6e5e31be9d1f7bfa6c306584f5d

TBR=maxbogue@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647505

Review-Url: https://codereview.chromium.org/2644373003
Cr-Commit-Position: refs/heads/master@{#445105}
(cherry picked from commit 5c363ea)

Review-Url: https://codereview.chromium.org/2641253004 .
Cr-Commit-Position: refs/branch-heads/2987@{#5}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
GnorTech pushed a commit that referenced this pull request Feb 2, 2017
[Merge M56] Revert "Revert of Don't offer to translate between Simpli…
788ef3c 
…fied and Traditional Chinese (patchset #5 id:80001 of https://codereview.chromium.org/2650003004/ )"

This reverts commit fc1f65c.
And removes offending <iostream> header from translate_manager.cc.

BUG=683164
NOTRY=true
TBR=groby

patch from issue 2655173003 at patchset 1 (http://crrev.com/2655173003#ps1)

Review-Url: https://codereview.chromium.org/2660573002 .
Cr-Commit-Position: refs/branch-heads/2924@{#874}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
rogerwang pushed a commit that referenced this pull request Feb 22, 2017
@eaenet
Revert of Avoid pathological layout on nested percent height tables (…
f3b0f9b 
…patchset #5 id:80001 of https://codereview.chromium.org/2670603002/ )

Reason for revert:
Broke Google Hangouts.

BUG=693722

Original issue's description:
> Avoid unnecessary cell layout on nested percent height tables
>
> In the test, the nested percent height tables mean that each cell will get at
> least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(), layoutRows())
> during the layout of the section - and this cascades down the tree with the lowest
> children getting hundreds of repeated layouts.
>
> This inefficiency has always been there, we've just introduced it for the
> percent height situation with crrev.com/2441373002.
>
> To avoid this don't bother computing the height of the section based on row sizes (calcRowLogicalHeight()),
> unless the section itself needed a layout - the previously calculated value will do.
>
> The only complication this introduces is: any extra logical height from the
> table that we previously discarded when distributing to the rows we will now
> try to distribute again. This can change the size of the section and cause extra
> paints.
>
>
> BUG=687061
>
> Review-Url: https://codereview.chromium.org/2670603002
> Cr-Commit-Position: refs/heads/master@{#449101}
> Committed: https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362d6221cb72302

TBR=mstensho@opera.com,robhogan@gmail.com
BUG=687061
NOTRY=true

Review-Url: https://codereview.chromium.org/2700183003
Cr-Commit-Position: refs/heads/master@{#451451}
(cherry picked from commit 91d8afa)

Review-Url: https://codereview.chromium.org/2709863002 .
Cr-Commit-Position: refs/branch-heads/2987@{#618}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@sebsg
[Payments] For normalization in java, pass profile instead of GUID.
84e1508 
This makes it so that new profiles can be normalized. Whereas before the
guid would not lead to the profile (not refreshed) and caused to get a
null profile.

BUG=697762

Review-Url: https://codereview.chromium.org/2727813005
Cr-Commit-Position: refs/heads/master@{#454625}
(cherry picked from commit 19a4aac)

Review-Url: https://codereview.chromium.org/2729903004 .
Cr-Commit-Position: refs/branch-heads/3029@{#5}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
rogerwang pushed a commit that referenced this pull request Apr 7, 2017
[Merge M58] Fix crash on drag attemp when view is not available.
986fc24 
BUG=704832
TEST=Manually as desribed in comment #5. content tests extended
TBR=avi@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2787583002
Cr-Commit-Position: refs/heads/master@{#461265}
(cherry picked from commit fb9dbe9)

Review-Url: https://codereview.chromium.org/2796103003
Cr-Commit-Position: refs/branch-heads/3029@{#579}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@wangxianzhu
Adjust visual overflow rect for rounded/shifted ascent/descent
40094f4 
For now we round and/or shift ascent and descent to integers in some cases,
and we may layout using ascent/descent smaller than the original, causing that
painted text at the laid-out position may overflow the visual overflow
calculated based on layout geometries.

Now record the loss in FontMetrics and adjust visual overflow rect to cover
the overflows.

BUG=706298
TBR=wangxianzhu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2803483002
Cr-Original-Commit-Position: refs/heads/master@{#464689}
Review-Url: https://codereview.chromium.org/2816243004
Cr-Commit-Position: refs/branch-heads/3071@{#5}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
rogerwang pushed a commit that referenced this pull request May 2, 2017
Revert of Immediately handle user-recoverable auth errors for child a…
2f0bd3a 
…ccounts. (patchset #5 id:80001 of https://codereview.chromium.org/2724023002/ )

Reason for revert:
Causes an UnsatisfiedLinkError: https://crbug.com/697979

Original issue's description:
> Immediately handle user-recoverable auth errors for child accounts.
>
> This will open a reauth activity e.g. when the password has changed. For child
> accounts, that is preferable to letting the user use Chrome unauthenticated.
>
> BUG=697412
>
> Review-Url: https://codereview.chromium.org/2724023002
> Cr-Commit-Position: refs/heads/master@{#453981}
> Committed: https://chromium.googlesource.com/chromium/src/+/94af3b0124e78f1f5f00a515e1f569a194c6b1dc

TBR=gogerald@google.com,msarda@chromium.org,bsazonov@chromium.org,rogerta@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697412

(cherry picked from commit 2e588c4)

Review-Url: https://codereview.chromium.org/2729203002
Cr-Original-Commit-Position: refs/heads/master@{#454642}
Cr-Commit-Position: refs/branch-heads/3029@{#753}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
rogerwang pushed a commit that referenced this pull request Jul 20, 2017
Revert "Listen to changes to touch input devices"
6b860e9 
This reverts commit 1b60006.

Reason for revert:
Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash.

Failing build (chromeos-side waterfall):
https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205

Stack (from running manually with chrome --mash on Linux):

[60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created.
#0 0x7f06a03468bc base::debug::StackTrace::StackTrace()
#1 0x7f06a036a121 logging::LogMessage::~LogMessage()
#2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance()
#3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl()
#4 0x55f1834066ad chromeos::ShowLoginWizard()
#5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize()
#6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit()
#7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun()
#9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun()
#11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow()
#12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks()
#13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize()
#14 0x7f069d9e0b57 content::BrowserMain()
#15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run()
#16 0x7f06a0890d39 service_manager::Main()
#17 0x7f069e1e7384 content::ContentMain()
#18 0x55f182e8132f ChromeMain
#19 0x7f069454af45 __libc_start_main
#20 0x55f182e81194 <unknown>

Original change's description:
> Listen to changes to touch input devices
>
> In https://codereview.chromium.org/2964823002 the OobeDisplayChooser
> started using the DeviceDataManager to look for touchscreen devices when
> searching for a good primary display to use during OOBE.
>
> On device cold boot the DeviceDataManager has not yet found any
> touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely
> due to lower level systems not being fully initialized).
>
> This CL make LoginDisplayHostImpl an observer of changes to connected
> touchscreen devices, re-triggering the OobeDisplayChooser when the
> DeviceDataManager is notified of the connected touchscreens. This
> overcomes the timing issues on cold boot.
>
> Bug: 738885
> Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd
> Reviewed-on: https://chromium-review.googlesource.com/569958
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487007}

TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

(cherry picked from commit 0cd134a)

Bug: 738885
Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4
Reviewed-on: https://chromium-review.googlesource.com/574731
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#487191}
Signed-off-by: Bernie Thompson <bhthompson@google.com>
Reviewed-on: https://chromium-review.googlesource.com/575149
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#623}
Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Incrementing VERSION to 61.0.3163.5
b635428 
TBR=dimu@chromium.org

Change-Id: Ic603bcd5bd8af8e54fb6d2eaede30e6b57e49898
Reviewed-on: https://chromium-review.googlesource.com/581800
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#5}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@erikchen
[Merge to 3202] Revert "Fix bug in ResourceCoordinatorWebContentsObse…
8c311d3 
…rver."

This reverts commit 50ce88d.

Missing nullptr checks.
https://bugs.chromium.org/p/chromium/issues/detail?id=761234#c2

Original change's description:
> Fix bug in ResourceCoordinatorWebContentsObserver.
>
> ProcessMemoryMetricsEmitterBrowserTest was failing to catch the null case -
> where no UKM sources were being created. This allowed a bug in
> ResourceCoordinatorWebContentsObserver sneak through which caused no URL to be
> emitted for sources.
>
> Bug: 760733
> Change-Id: Ib59139d88763156d2b8dbe18b24416bd711d5cb0
> Reviewed-on: https://chromium-review.googlesource.com/644388
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Zhen Wang <zhenw@chromium.org>
> Reviewed-by: lpy <lpy@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#499059}

TBR=bmcquade@chromium.org, erikchen@chromium.org, holte@chromium.org, lpy@chromium.org, zhenw@chromium.org

(cherry picked from commit ba0aeef)

Change-Id: I9901d0a4b6bb4a4f131d977365cc072cec09c7ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 760733
Reviewed-on: https://chromium-review.googlesource.com/647906
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499195}
Reviewed-on: https://chromium-review.googlesource.com/647770
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#5}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
Updating XTBs based on .GRDs from branch 3239
10291a8 
TBR=mmoss@chromium.org

Change-Id: If5e991891c79a594e52daad88858fb78afa595b4
Reviewed-on: https://chromium-review.googlesource.com/719732
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#5}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
Updating XTBs based on .GRDs from branch 3325
d7d51ac 
R=cmasso@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I307b42a86aaeb4212de309449910981d6f165da7
Reviewed-on: https://chromium-review.googlesource.com/877381
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#5}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
Incrementing VERSION to 66.0.3359.5
e3241c6 
TBR=dimu@chromium.org

Change-Id: Iacec3122524d5afbee94336f9eb918fdcbcd53fe
Reviewed-on: https://chromium-review.googlesource.com/947831
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#5}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
drm_util: correct initial value of |display_id|
bff9e2d 
This CL corrects the initialization value of |display_id| from -1
(which is bad) to what it used to have before the CL reviewed in

https://chromium-review.googlesource.com/c/chromium/src/+/970085/23/ui/ozone/platform/drm/common/drm_util.cc#b385

The -1 it breaks (at least) amd64-generic-tot-chromium-pfq-informational
(see bug).

TBR=dnicoara@chromium.org since it's a trivial fix and has been verified., mcasas@chromium.org

(cherry picked from commit 8f8853c)

Bug: 832136
Change-Id: I3c1db741979f20877483880b87f2d052b2a02cf9
Reviewed-on: https://chromium-review.googlesource.com/1010517
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550495}
Reviewed-on: https://chromium-review.googlesource.com/1013386
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#5}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request May 5, 2018
@progers
[RLS] Do not apply scroll when clipping fixed-position visual rects
60e9494 
With root layer scrolling the layout view clips and we need to ensure
the clip occurs in the correct (un)scrolled space for fixed position.
This patch changes the fixed position case: we stop applying the layout
view scroll, clip, and then do not counter-scroll. There is a similar
codepath for the !RLS case which has not been changed in this patch.

Here's a summarized description of where scroll offsets apply:
1) MapToVisualRectInAncestorSpaceInternal calls MapVisualRectToContainer
2) MapVisualRectToContainer calls MapContentsRectToBoxSpace
3) MapContentsRectToBoxSpace applies the layout view scroll offset
4) MapContentsRectToBoxSpace clips
5) MapToVisualRectInAncestorSpaceInternal un-applies the scroll offset

This patch removes #3 and #5 for fixed position.

Bug: 831380

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3437d3933155960abfcbebd437ddb6cb606ea37e
Reviewed-on: https://chromium-review.googlesource.com/1025329
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553455}(cherry picked from commit e931d2a)
Reviewed-on: https://chromium-review.googlesource.com/1030871
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#333}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Update 3440 DEPS for M68 branching
0ec0a17 
Change-Id: I031fc19b05343ca72cb4a5641274174bfd069448
Reviewed-on: https://chromium-review.googlesource.com/1073660
Reviewed-by: Abdul Syed <abdulsyed@google.com>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#5}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
Updating XTBs based on .GRDs from branch 3497
68ed177 
R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I796dd6eb21204da71a70f8a85c37cb3222c5715a
Reviewed-on: https://chromium-review.googlesource.com/1145765
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#5}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
Incrementing VERSION to 70.0.3538.2
f3b1b14 
TBR=govind@chromium.org

Change-Id: I3f12f14f52fdf855e05866c21058553e9fbedc53
Reviewed-on: https://chromium-review.googlesource.com/1198316
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#5}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Incrementing VERSION to 71.0.3578.3
4d570ae 
TBR=cmasso@chromium.org

Change-Id: Id60f556e014a391a1501feec3465ab7515665f22
Reviewed-on: https://chromium-review.googlesource.com/c/1279209
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#5}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Merge to M71: Fix DCHECK failure in AppListView::GetAppListTransition…
feea0d9 
…Progress()

Bug: 894582

Change-Id: I08b1740c9e653bb6f3aa5c57653643888d13e630
Reviewed-on: https://chromium-review.googlesource.com/c/1279239
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#599402}(cherry picked from commit 39face3)
Reviewed-on: https://chromium-review.googlesource.com/c/1279299
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3575@{#5}
Cr-Original-Branched-From: 16ca0c3-refs/heads/master@{#597882}(cherry picked from commit 55b93a05865ed6848d4e85ec7f84c2cda1ee4098)
Reviewed-on: https://chromium-review.googlesource.com/c/1294837
Cr-Commit-Position: refs/branch-heads/3578@{#248}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@edx246
[ios] [BVC refactor] Prevent crash in BrowserCoordinator |-stop|
435152f 
A coordinator's |-stop| should not crash if called multiple times.

Bug: 910652
Change-Id: I5a2998726ad3390a8b1c98afbc753f093a4a8986
Reviewed-on: https://chromium-review.googlesource.com/c/1357001
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612706}(cherry picked from commit e2c30b8)
Reviewed-on: https://chromium-review.googlesource.com/c/1357671
Cr-Commit-Position: refs/branch-heads/3626@{#5}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 7, 2019
@xiaochengh
Ensure text control entrance when generating clipboard text
f15c682 
Blink uses TextIteratorInFlatTree for generating clipboard text, which
used to enter text controls by default. The TextIterator behavior was
changed crrev.com/c/1327962, causing an unexpected behavior change.

This patch explicitly sets the EntersTextControls flag when computing
clipboard text to recover the original behavior.

Bug: 927394
Change-Id: I1e8d30cc73e14d5695b985b2e5afa1591e019663
Reviewed-on: https://chromium-review.googlesource.com/c/1450445
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#628682}(cherry picked from commit c6bb24c)
Reviewed-on: https://chromium-review.googlesource.com/c/1452342
Reviewed-by: Krishna Govind <govind@chromium.org>
Reviewed-by: Abdul Syed <abdulsyed@google.com>
Cr-Original-Original-Commit-Position: refs/branch-heads/3693@{#5}
Cr-Original-Original-Branched-From: 58322e3-refs/heads/master@{#628647}(cherry picked from commit 38219800a60ad4fe47d4032bfbb76bb0d444ee4b)
Reviewed-on: https://chromium-review.googlesource.com/c/1455338
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3683@{#224}
Cr-Original-Branched-From: e510299-refs/heads/master@{#625896}(cherry picked from commit 845a970)
Reviewed-on: https://chromium-review.googlesource.com/c/1455314
Cr-Commit-Position: refs/branch-heads/3626@{#835}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
Update 3683 DEPS for M73 branching
84430ce 
Change-Id: I8fe21575cbcdf7868b85d653982099bafca85dde
Reviewed-on: https://chromium-review.googlesource.com/c/1437478
Reviewed-by: Abdul Syed <abdulsyed@google.com>
Cr-Commit-Position: refs/branch-heads/3683@{#5}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@xiaochengh
Ensure text control entrance when generating clipboard text
845a970 
Blink uses TextIteratorInFlatTree for generating clipboard text, which
used to enter text controls by default. The TextIterator behavior was
changed crrev.com/c/1327962, causing an unexpected behavior change.

This patch explicitly sets the EntersTextControls flag when computing
clipboard text to recover the original behavior.

Bug: 927394
Change-Id: I1e8d30cc73e14d5695b985b2e5afa1591e019663
Reviewed-on: https://chromium-review.googlesource.com/c/1450445
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#628682}(cherry picked from commit c6bb24c)
Reviewed-on: https://chromium-review.googlesource.com/c/1452342
Reviewed-by: Krishna Govind <govind@chromium.org>
Reviewed-by: Abdul Syed <abdulsyed@google.com>
Cr-Original-Commit-Position: refs/branch-heads/3693@{#5}
Cr-Original-Branched-From: 58322e3-refs/heads/master@{#628647}(cherry picked from commit 38219800a60ad4fe47d4032bfbb76bb0d444ee4b)
Reviewed-on: https://chromium-review.googlesource.com/c/1455338
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#224}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Feb 19, 2019
Omnibox: Add back vertical margin field trial
1eb6047 
This CL is a partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/1257806

It adds back the vertical margin trial, but it no longer ties it to
kExperimentalUi. It's just set to 2 by default, to match the
pre-Refresh look as closely as possible.

This can be manually tested like this:

chrome
  --force-fieldtrials=FakeStudy/FakeGroup
  --force-fieldtrial-params=FakeStudy.FakeGroup:UIVerticalMargin/12
  --enable-features="OmniboxUIExperimentVerticalMargin<FakeStudy"

Bug: 931332
Change-Id: Ic590f736b141a20bb10ee1e4d4f688d18d68910f
Reviewed-on: https://chromium-review.googlesource.com/c/1467345
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#631521}(cherry picked from commit c89a1ba)
Reviewed-on: https://chromium-review.googlesource.com/c/1470993
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3704@{#5}
Cr-Original-Branched-From: f725794-refs/heads/master@{#631506}(cherry picked from commit 05d7b89fa30f767e8614765a7d4ed2ffa97564aa)
Reviewed-on: https://chromium-review.googlesource.com/c/1471342
Cr-Commit-Position: refs/branch-heads/3683@{#411}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Feb 25, 2019
[Merge 72] Omnibox: Add back vertical margin field trial
6586dec 
This CL is a partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/1257806

It adds back the vertical margin trial, but it no longer ties it to
kExperimentalUi. It's just set to 2 by default, to match the
pre-Refresh look as closely as possible.

This can be manually tested like this:

chrome
  --force-fieldtrials=FakeStudy/FakeGroup
  --force-fieldtrial-params=FakeStudy.FakeGroup:UIVerticalMargin/12
  --enable-features="OmniboxUIExperimentVerticalMargin<FakeStudy"

TBR=tommycli@chromium.org

(cherry picked from commit 1eb6047)

Bug: 931332
Change-Id: Ic590f736b141a20bb10ee1e4d4f688d18d68910f
Reviewed-on: https://chromium-review.googlesource.com/c/1467345
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#631521}(cherry picked from commit c89a1ba)
Reviewed-on: https://chromium-review.googlesource.com/c/1470993
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Original-Original-Commit-Position: refs/branch-heads/3704@{#5}
Cr-Original-Original-Branched-From: f725794-refs/heads/master@{#631506}(cherry picked from commit 05d7b89fa30f767e8614765a7d4ed2ffa97564aa)
Reviewed-on: https://chromium-review.googlesource.com/c/1471342
Cr-Original-Commit-Position: refs/branch-heads/3683@{#411}
Cr-Original-Branched-From: e510299-refs/heads/master@{#625896}
Reviewed-on: https://chromium-review.googlesource.com/c/1474288
Cr-Commit-Position: refs/branch-heads/3626@{#862}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Incrementing VERSION to 74.0.3729.2
4a4b5a7 
TBR=kariah@chromium.org

Change-Id: Iea2d5bd98c7225a89c51dd2e3032b9ee09fff1cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512710
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#5}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghostoy @rogerwang