pass keyboard events to menubar for AppWindow #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Resource() In loadRequest(), setResource() can call clear() synchronously: DocumentThreadableLoader::clear() DocumentThreadableLoader::handleError() Resource::didAddClient() RawResource::didAddClient() and thus |m_client| can be null while resource() isn't null after setResource(), causing crashes (Issue 595964). This CL checks whether |*this| is destructed and whether |m_client| is null after setResource(). BUG=595964 Review-Url: https://codereview.chromium.org/1902683002 Cr-Commit-Position: refs/heads/master@{#391001} (cherry picked from commit 2571533) Review URL: https://codereview.chromium.org/1954833003 . Cr-Commit-Position: refs/branch-heads/2704@{#410} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
…descriptive." This reverts commit 9281cb6. Reason for revert is: bad merge. TBR=imcheng@chromium.org BUG=609333 Review URL: https://codereview.chromium.org/1955703003 . Cr-Commit-Position: refs/branch-heads/2704@{#411} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
…ive. Initially landed at https://codereview.chromium.org/1873013002 BUG=609333 Review URL: https://codereview.chromium.org/1961443002 . Cr-Commit-Position: refs/branch-heads/2704@{#412} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
This merge required some manual, but fairly straightforward changes. BUG=607615 Review-Url: https://codereview.chromium.org/1934583002 Cr-Commit-Position: refs/heads/master@{#390648} (cherry picked from commit c1bd1f1) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1949923003 Cr-Commit-Position: refs/branch-heads/2704@{#413} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
This involves moving the Recent Tabs signin method to showing a button that summons a Signin Activity (previously the Signin Activity was integrated in the Recent Tabs page) - this is the SigninAndSyncView. This also provides a Settings link to the Bookmarks and Recent Tabs signin flows. Additionally, it replaces the BookmarkSigninActivity with the AccountSigninActivity. BUG=583774, 598868, 599736 Review-Url: https://codereview.chromium.org/1901623002 Cr-Commit-Position: refs/heads/master@{#390356} (cherry picked from commit d830894) TBR=bauerb@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1956673002 Cr-Commit-Position: refs/branch-heads/2704@{#414} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
The fix has two parts. Blacklisting the federated credential now works. The password bubble doesn't pop up for a federated credential when the site is blacklisted. BUG=607945 TBR=vabr@chromium.org Review-Url: https://codereview.chromium.org/1946563003 Cr-Commit-Position: refs/heads/master@{#391260} (cherry picked from commit 60883bf) Review URL: https://codereview.chromium.org/1960653002 . Cr-Commit-Position: refs/branch-heads/2704@{#415} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
BUG=583774 Review-Url: https://codereview.chromium.org/1943343002 Cr-Commit-Position: refs/heads/master@{#391250} (cherry picked from commit 3127911) TBR=bauerb@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1956683002 Cr-Commit-Position: refs/branch-heads/2704@{#416} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Inflate SigninAndSyncView directly instead of having it inflate and then include signin_and_sync_view.xml. BUG=607799 Review-Url: https://codereview.chromium.org/1948463002 Cr-Commit-Position: refs/heads/master@{#391472} (cherry picked from commit 58d4f0a) TBR=bauerb@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1955883002 Cr-Commit-Position: refs/branch-heads/2704@{#417} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
This propagates damage stored in property tree nodes to descendants, when damage is copied over from old property trees to new ones. This ensures that damage is up-to-date even if there are no other reasons to do a full tree update. BUG=607423 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1948163002 Cr-Commit-Position: refs/heads/master@{#391667} (cherry picked from commit 2da9a21) Review URL: https://codereview.chromium.org/1949253006 . Cr-Commit-Position: refs/branch-heads/2704@{#418} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
…ten script,this patch includes a check that if the user is reloading the same page then do not consider the document.written scripts on this page for blocking. BUG=602644 Review URL: https://codereview.chromium.org/1883873002 Cr-Commit-Position: refs/heads/master@{#389480} (cherry picked from commit f6ea16a) Review URL: https://codereview.chromium.org/1955043003 . Cr-Commit-Position: refs/branch-heads/2704@{#419} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
This CL plumbs feature flags from the browser process to the gpu process. This CL moves FeatureList initialization into content_main_runner.cc, for the gpu, utility and ppapi plugin processes. Eventually, all non-browser FeatureList initialization should live in content_main_runner.cc. This CL sets the entropy provider to NULL, and creates trials from kForceFieldTrials for the gpu, utility, and ppapi plugin processes. BUG=606850, 563705 Review-Url: https://codereview.chromium.org/1928863002 Cr-Commit-Position: refs/heads/master@{#391403} (cherry picked from commit 55edbff) Review URL: https://codereview.chromium.org/1953933003 . Cr-Commit-Position: refs/branch-heads/2704@{#420} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
The current color is between paper grey 500 and paper grey 600. This darkens the color to paper grey 600 to fix the AX_COLOR_01 warnings for the subtext. BUG=609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1946823003 Cr-Commit-Position: refs/heads/master@{#391630} (cherry picked from commit e7e4e8b) Review URL: https://codereview.chromium.org/1959723002 . Cr-Commit-Position: refs/branch-heads/2704@{#421} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Clearing IOSurfaces may cause a performance regression on OS X 10.10. This CL creates an experiment that will let us determine whether this is the case. BUG=606850 Review-Url: https://codereview.chromium.org/1946693003 Cr-Commit-Position: refs/heads/master@{#391708} (cherry picked from commit b8d3f7e) Review URL: https://codereview.chromium.org/1955953002 . Cr-Commit-Position: refs/branch-heads/2704@{#422} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
…s elements (patchset nwjs#2 id:20001 of https://codereview.chromium.org/1383003002/ ) Reason for revert: This is breaking how percentages work in Flexbox and Grid compared to regular Blocks. There're some discussion ongoing on the CSS WG to verify the expected behavior, so we're reverting this for now until we've a final resolution. Original issue's description: > [css-grid] Fix definite/indefinite size detection for abspos elements > > We were considering that any abspos element has a definite size, and > that's not true. That's only true if the offset properties in that > dimension (left and right or top and bottom) are non-auto. > Fixed LayoutBox::hasDefiniteLogicalWidth|Height() to check this > properly. > > This has been confirmed by the CSS WG in the following thread: > https://lists.w3.org/Archives/Public/www-style/2015Nov/0074.html > > BUG=538513 > TEST=fast/css-grid-layout/positioned-grid-container-percentage-tracks.html > > Committed: https://crrev.com/b75b9bdaa3ede6fe0230ae822885d6fb38ed514b > Cr-Commit-Position: refs/heads/master@{#386045} TBR=cbiesinger@chromium.org,svillar@igalia.com,mstensho@opera.com BUG=538513,603854,604346,608783 Review-Url: https://codereview.chromium.org/1954683002 Cr-Commit-Position: refs/heads/master@{#391789} (cherry picked from commit 83e8000) Review URL: https://codereview.chromium.org/1957693002 . Cr-Commit-Position: refs/branch-heads/2704@{#423} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Currently, paper blue 500 and white do not have enough contrast. This change replaces all usages of paper blue 500 with 700, which is the next darkest paper blue color that passes the accessibility audit. This fixes the AX_COLOR_01 warnings related to the blue color. BUG=609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1950563003/ Cr-Commit-Position: refs/heads/master@{#391633} (cherry picked from commit 8c672ef) Review URL: https://codereview.chromium.org/1956583003 . Cr-Commit-Position: refs/branch-heads/2704@{#424} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
…locking feature. The metrics are specifically for pages that have a blockable document.written script. The CL also has a metric to count the number of reloads for such pages to check if there is any increase in number of reloads possibly implying page breaks. BUG=603152 Review-Url: https://codereview.chromium.org/1918373002 Cr-Commit-Position: refs/heads/master@{#391526} (cherry picked from commit e6340ed) BUG=603152 Review URL: https://codereview.chromium.org/1957703002 . Cr-Commit-Position: refs/branch-heads/2704@{#425} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Previously, in OverlayFullscreenVideo mode, the video GraphicsLayer contents
was set to invisible because the video frames were rendered directly to an
underlay without involving the cc::VideoLayer.
With this change the video layer contents is changed to visible to give
WebMediaPlayer implementations more control. Previously only
WebMediaPlayerAndroid needed to use OverlayFullscreenVideo mode, but a
future CL will enable it for WebMediaPlayerImpl too. WMPA and WMPI have
different requirements for OverlayFullscreenVideo, but they both use the
fact that the LayerTreeView background is made transparent.
WMPA will continue to make the whole LayerTreeView transparent, but it now
does so by setting the layer's current VideoFrame to a transparent frame.
WMPI will not make the video frame transparent, but will let it be
composited as usual. With WMPI we need to composite the frames because:
a) In hardware underlay mode the ui compositor is responsible for timing
the release of video frames to the underlay surface by scheduling them
as overlay planes. So we need the ui compositor to see every new video
frame.
b) With WMPI we can have software decoded frames for which we currently
have no way of rendering to the underlay surface. As a result,
they will be rendered by the compositor to the main surface.
BUG=603521
Review-Url: https://codereview.chromium.org/1907753002
Cr-Commit-Position: refs/heads/master@{#391728}
(cherry picked from commit e779e5a)
Review URL: https://codereview.chromium.org/1959673003 .
Cr-Commit-Position: refs/branch-heads/2704@{#426}
Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
OverlayFullscreenVideo mode was previously only used by WebMediaplayerAndroid, but as we move to using WebMediaPlayerImpl on Android, it's enabled there too. OverlayFullscreenVideo sets the cc root layer to be the video layer and makes the LayerTreeView background transparent. The result is much smoother fullscreen orientation changes. BUG=603521 Review-Url: https://codereview.chromium.org/1952133003 Cr-Commit-Position: refs/heads/master@{#392141} (cherry picked from commit 9c87c6f) Review URL: https://codereview.chromium.org/1956473005 . Cr-Commit-Position: refs/branch-heads/2704@{#427} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
BUG=609003 Review-Url: https://codereview.chromium.org/1955443002 Cr-Commit-Position: refs/heads/master@{#391880} (cherry picked from commit c518abf) Review URL: https://codereview.chromium.org/1952663007 . Cr-Commit-Position: refs/branch-heads/2704@{#428} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Changes the computation of the margin between main text and caption to use a portion of the extra space in the bar instead of a portion of the text size. BUG=606725 Review-Url: https://codereview.chromium.org/1944233002 Cr-Commit-Position: refs/heads/master@{#391732} (cherry picked from commit 6bab8be) Review URL: https://codereview.chromium.org/1959793002 . Cr-Commit-Position: refs/branch-heads/2704@{#429} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
BUG=608914 Review-Url: https://codereview.chromium.org/1952543002 Cr-Commit-Position: refs/heads/master@{#392104} (cherry picked from commit b2b3fcd) Review URL: https://codereview.chromium.org/1953373002 . Cr-Commit-Position: refs/branch-heads/2704@{#430} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
BUG=606299 Review-Url: https://codereview.chromium.org/1954223002 Cr-Commit-Position: refs/heads/master@{#392149} (cherry picked from commit b8d9f34) Review URL: https://codereview.chromium.org/1956703006 . Cr-Commit-Position: refs/branch-heads/2704@{#431} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
…wrapper scripts It was co-incidentally working for me previously because I had my CWD=output-dir. Original CL: https://codereview.chromium.org/1891863002 BUG=609575 R=agrieve@chromium.org Review URL: https://codereview.chromium.org/1956463002 . Cr-Commit-Position: refs/branch-heads/2704@{#432} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
The browser process has no kProcessType swtich when created. So this CL makes sure that we only create DownloadManagerService in browser. If still see crash report after this CL, then something else is wrong. TBR=tedchoc@chromium.org BUG=606309 Review URL: https://codereview.chromium.org/1923723002 Cr-Commit-Position: refs/heads/master@{#389939} (cherry picked from commit 6597c39) Review URL: https://codereview.chromium.org/1953343003 . Cr-Commit-Position: refs/branch-heads/2704@{#433} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Ubuntu Glibc's sem_post is race-y and potentially makes futex(2) system calls with totally bogus op arguments. Instead of crashing when this happens, simply return EINVAL. This isn't very satisfying, but the extra security protection from crashing is minimal, and there don't appear to be any better workarounds. BUG=598471 Review URL: https://codereview.chromium.org/1900233003 Cr-Commit-Position: refs/heads/master@{#388429} (cherry picked from commit 3fbc468) Review URL: https://codereview.chromium.org/1957683003 . Cr-Commit-Position: refs/branch-heads/2704@{#434} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
IOSurface texures can't be reused because the compositor returns them while they are still in use by the Window Server, and the SyncToken isn't relevant. BUG=608026 Review-Url: https://codereview.chromium.org/1932393002 Cr-Commit-Position: refs/heads/master@{#391043} (cherry picked from commit 64d59f6) Review URL: https://codereview.chromium.org/1953293005 . Cr-Commit-Position: refs/branch-heads/2704@{#435} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
As a prelude to removal of these methods, slip a deprecation warning in. Intent Thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoeyBwAJ BUG=604951 R=rbyers@chromium.org,mpearson@chromium.org Review-Url: https://codereview.chromium.org/1938183002 Cr-Commit-Position: refs/heads/master@{#391951} (cherry picked from commit 0ac9602) Review URL: https://codereview.chromium.org/1953413002 . Cr-Commit-Position: refs/branch-heads/2704@{#436} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Cr-Commit-Position: refs/branch-heads/2704@{#437}
Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
TBR=peconn BUG= Review URL: https://codereview.chromium.org/1954373002 . Cr-Commit-Position: refs/branch-heads/2704@{#438} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Cr-Commit-Position: refs/branch-heads/2704@{#439}
Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
…, ensure any disabled windows are enabled. BUG=612117 Review-Url: https://codereview.chromium.org/1978163003 Cr-Commit-Position: refs/heads/master@{#394861} (cherry picked from commit 3972b0e) Review URL: https://codereview.chromium.org/2008103002 . Cr-Commit-Position: refs/branch-heads/2704@{#654} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
We ran into interoperability issues on Mac OS X clients and MIT Kerberos servers. (See bug for details). Out of an abundance of caution, we are reverting to pre M51 behavior for Posix platforms. R=rsleevi@chromium.org BUG=611728 Review-Url: https://codereview.chromium.org/2002063005 Cr-Commit-Position: refs/heads/master@{#395675} (cherry picked from commit ccb5d4f) Review URL: https://codereview.chromium.org/2009633002 . Cr-Commit-Position: refs/branch-heads/2704@{#655} Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
Cr-Commit-Position: refs/branch-heads/2704@{#656}
Cr-Branched-From: 6e53600-refs/heads/master@{#386251}
rogerwang
force-pushed
the
nw14
branch
2 times, most recently
from
d030cc4
to
078615d
Compare
fixed #4837
|
close for rebase |
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
Increasing number of saved destinations caused a bug on Chrome OS - destination always reverted to Save as PDF. Also caused random "PDF failed to load" preview errors. This occurred since the destinations were modified one after the other too quickly, which caused a race condition that crashed PDF preview. This error occurred ~1 in 10 times. BUG=665455,666426,666595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2516523002 Cr-Commit-Position: refs/heads/master@{#433408} (cherry picked from commit b12aba7) Review URL: https://codereview.chromium.org/2514303002 . Cr-Commit-Position: refs/branch-heads/2924@{#19} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
This CL makes sure that when the user edits entries the "Delete Read" button gets updated accordingly. BUG=683128 Review-Url: https://codereview.chromium.org/2651583003 Cr-Commit-Position: refs/heads/master@{#445340} (cherry picked from commit f9f960b) Review-Url: https://codereview.chromium.org/2651623002 . Cr-Commit-Position: refs/branch-heads/2987@{#19} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
…check This fixes crashes occurring when pre- JB MR1 devices receive a web notification. A version check was removed in 04b8a54* after migration from Notification.Builder to ChromeNotificationBuilder meant setPublicVersion became safe to call pre-L. However, the createPublicNotification call, also within the version check, did *not* become safe to call pre-L, as it calls setShowWhen which was introduced in API 17 (Jelly Bean MR1). Putting back the version check for L is the sensible fix here. (We could just check for JB-MR1, but there's no point building a public version of the notification before L as it wouldn't be used). * see https://codereview.chromium.org/2702023002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java BUG=678670,698251 Review-Url: https://codereview.chromium.org/2734463002 Cr-Commit-Position: refs/heads/master@{#454600} (cherry picked from commit c45f71b) Review-Url: https://codereview.chromium.org/2735723002 . Cr-Commit-Position: refs/branch-heads/3029@{#19} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
… it. Becoming first responder isn't how Mac UI elements ususally show that they can accept a drag. Some have special states for dragging (e.g. Finder windows, Dock tiles), and others just use the cursor type (e.g. Safari's omnibox and web content areas). Not selecting the omnibox at all feels better to me and, as a bonus, fixes crbug/356887, which was caused by ZeroSuggest triggering on the Omnibox becoming first responder. BUG=356887, 30809 Review-Url: https://codereview.chromium.org/2812383002 Cr-Commit-Position: refs/heads/master@{#464726} (cherry picked from commit 7905926) Review-Url: https://codereview.chromium.org/2820113003 . Cr-Commit-Position: refs/branch-heads/3071@{#19} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
rogerwang
pushed a commit
that referenced
this pull request
Jul 20, 2017
This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
TBR=tsergeant@chromium.org (cherry picked from commit f51ed49) Bug: 658980 Change-Id: I6b8bb4d75ac2bf5b122405765a4a4e95d3a7e0d5 Reviewed-on: https://chromium-review.googlesource.com/580009 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488529} Reviewed-on: https://chromium-review.googlesource.com/583948 Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#19} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
paper-slider v2.0.2 has a breaking change. PolymerElements/paper-slider#194 |ratio| property used to return a value in [0, 1], but now it returns a value in [0, 100]. Making video player to catch up this change by dividing |ratio| property by 100. TBR=fukino@chromium.org (cherry picked from commit 81d2a76) Bug: 752283 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iad994a2dd7f8a6e5b77698a0deec0812c70fb045 Reviewed-on: https://chromium-review.googlesource.com/646153 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499126} Reviewed-on: https://chromium-review.googlesource.com/650186 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#19} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
If GattServicesDiscovered event is fired but the characteristics have not been found CharacteristicsFinder should call the error callback. Otherwise timeout will occur and it's hard to realize that the characteristics are not found in the first place. BUG=773062 TEST=Try to find non-existent characteristics and check that error callback is called instead of timing out. TBR=sonnysasaka@chromium.org (cherry picked from commit 83ffa24) Change-Id: I645e3470d7dff1c7c9e6c0a1fa4efa34c81ca254 Reviewed-on: https://chromium-review.googlesource.com/714528 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508842} Reviewed-on: https://chromium-review.googlesource.com/721972 Cr-Commit-Position: refs/branch-heads/3239@{#19} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
I made the mistake of believing a DCHECK that was in the code… TBR=dcheng@chromium.org (cherry picked from commit eb8a5f9) Bug: 803811 Change-Id: I536ff17c7bbb2ff23f199c9b51637f184d08966d Reviewed-on: https://chromium-review.googlesource.com/876649 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530625} Reviewed-on: https://chromium-review.googlesource.com/879345 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#19} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
TBR=tedchoc@chromium.org Bug: 818236 Change-Id: Ib7e74015c6cebb368bf9efdf8307ed13c1db8e4f Reviewed-on: https://chromium-review.googlesource.com/946649 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540603}(cherry picked from commit d269a1b) Reviewed-on: https://chromium-review.googlesource.com/949982 Cr-Commit-Position: refs/branch-heads/3359@{#19} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
Bug: 832770 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ifb3474a2b250c5a1ac8606e3a9cffbfaa9aa92aa Reviewed-on: https://chromium-review.googlesource.com/1012564 Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550788}(cherry picked from commit c7c6e31) Reviewed-on: https://chromium-review.googlesource.com/1013680 Cr-Commit-Position: refs/branch-heads/3396@{#19} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
This is a partial revert for https://chromium.googlesource.com/chromium/src/+/87d0207fea94e8f64ca053c813b96e2ddcd3da27 Tabs not only get restored from tab entities (which is usually the case) but can also be restored directly when processing a header entity. For cases where a header references a tab that doesn't have a corresponding tab entity (e.g. was unsyncable), we need to simply skip the reasociation step. Bug: 846480 Change-Id: I5d534645a42e4e660bf2cd110a7a4ee0f57b9c25 Reviewed-on: https://chromium-review.googlesource.com/1073328 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561838}(cherry picked from commit 90e9c23) Reviewed-on: https://chromium-review.googlesource.com/1076241 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#19} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
Bug: 865157 TBR=jochen@chromium.org (cherry picked from commit fe951b0) Change-Id: I6d04148640812e4a2de80866fee1545bd2ef1868 Reviewed-on: https://chromium-review.googlesource.com/1141874 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577091} Reviewed-on: https://chromium-review.googlesource.com/1147220 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#19} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
When bookmark apps aren't locally installed, they should be dimmed out and they should have the launch type, app info and create shortcuts menus removed. This change also cleans up the logic that shows these menus and moved it to C++ where it is easier to reason about. TBR=benwells@chromium.org (cherry picked from commit 72ecaf0) Bug: 874841 Change-Id: Ia6af16a383c6f4434ac9da9e49882186c2c20015 Reviewed-on: https://chromium-review.googlesource.com/1195124 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587920} Reviewed-on: https://chromium-review.googlesource.com/1203751 Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#19} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
Add an optional callback to proxy override methods introduced in change https://chromium-review.googlesource.com/c/chromium/src/+/1148384 This adds an optional callback developers can use to know when the changes have been made to the network settings, since the methods are not synchronous with the UI thread. Bug: 851995 Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217 Reviewed-on: https://chromium-review.googlesource.com/c/1258770 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599166}(cherry picked from commit e2dd9b1) Reviewed-on: https://chromium-review.googlesource.com/c/1280604 Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#19} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
…kExecutor." This reverts commit acde6a7. Reason for revert: Causing crashes, see https://crbug.com/907720. Original change's description: > Remove RefCountedThreadSafe from CommandBufferTaskExecutor. > > CommandBufferTaskExecutor needs to be created and destroyed on the GPU > thread. To ensure it's destroyed on the GPU thread we hold onto a > scoped_refptr there and destroy it last. Owning the object there and > passing around a raw pointer accomplishes the same thing with less > complexity. > > Bug: none > Change-Id: I7c2d4f22044d28799c04144729c03d273abe7592 > Reviewed-on: https://chromium-review.googlesource.com/c/1340907 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609557} TBR=boliu@chromium.org,sunnyps@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907720 Change-Id: Ia85f08ce16a674525be9378e44b3535d037fdf24 Reviewed-on: https://chromium-review.googlesource.com/c/1351477 Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612651}(cherry picked from commit 03a441c) Reviewed-on: https://chromium-review.googlesource.com/c/1359321 Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#19} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
This CL updates the GlobalShortcutListenerMac to properly use the MediaKeysListenerManager when enabled. This also consolidates the logic for checking whether or not to use the MediaKeysListenerManager into a static method on the public MediaKeysListener API. Bug: 925178 Change-Id: I0b32ff9c7893743c3b413fda2e78c063a3909731 Reviewed-on: https://chromium-review.googlesource.com/c/1436143 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#625957}(cherry picked from commit e801b6c) Reviewed-on: https://chromium-review.googlesource.com/c/1439942 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#19} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
… layer Previously, we always allocated a render surface for non-kSrcOver blend modes. However, there is now a fast path in the compositor for kDstIn blend mode with only one layer under the blend. The fast path is already enabled for rounded-corner masks; this patch enables it for all cases. (In practice, the only way to trigger it is via clip-path or mask CSS, since mix-blend-mode does not support kDstIn). Bug: 939170 Change-Id: Ida95b21dfbbf42afd1be284cdbdafc24612dc30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509355 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#639079}(cherry picked from commit 39ef5b9694d63665a4e5b41c6e0ca03e746c26b9) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515234 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#19} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed nwjs/nw.js#4837