Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4852: disable tray icon "NW.js is using your microphone" #18

Closed
wants to merge 3 commits into from
Closed

fix #4852: disable tray icon "NW.js is using your microphone" #18

wants to merge 3 commits into from

Conversation

jtg-gg
Copy link
Member

@jtg-gg jtg-gg commented May 16, 2016

No description provided.

@jtg-gg jtg-gg mentioned this pull request May 16, 2016
Closed
@jtg-gg jtg-gg mentioned this pull request May 18, 2016
Closed
@rogerwang
Copy link
Member

thanks. The patches were merged into the master patch.

@rogerwang rogerwang closed this May 18, 2016
@jtg-gg jtg-gg deleted the fix#4852 branch May 18, 2016 08:10
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@JinsukKim
Calling clearSelection instead of unselect
cce756e 
crrev.com/2407303005 introduced a bug by having |onDestroyActionMode| call |mWebContents.unselect()| instead of |clearSelection()|. This CL fixes that.

BUG=666979
TBR=aelias@chromium.org

Review-Url: https://codereview.chromium.org/2513203002
Cr-Commit-Position: refs/heads/master@{#433427}
(cherry picked from commit 4ff3e57)

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2520803002
Cr-Commit-Position: refs/branch-heads/2924@{#18}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
Initially load new_tab.css with a timestamp for chrome://apps.
1db7914 
This is what incognito_tab.html already does. Changing the url to add a
timestamp query on DOMContentLoaded caused a FoUC.

BUG=681495
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2647653002
Cr-Commit-Position: refs/heads/master@{#445285}
(cherry picked from commit babe852)

Review-Url: https://codereview.chromium.org/2650683002 .
Cr-Commit-Position: refs/branch-heads/2987@{#18}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
Handle null callbacks in OnFaviconDownloaded
0a83673 
All callback are now optional for the IconFetcher.
(This fixes a regression and enables the proper background fetching of
large icons for new NTPs.)

BUG=698159,694270

Review-Url: https://codereview.chromium.org/2725293002
Cr-Commit-Position: refs/heads/master@{#454565}
(cherry picked from commit f2dcc90)

Review-Url: https://codereview.chromium.org/2736673002 .
Cr-Commit-Position: refs/branch-heads/3029@{#18}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@hiroshige-g
Revert of Split PendingScript into PendingScript and ClassicPendingSc…
f41274d 
…ript (patchset #37 id:720001 of https://codereview.chromium.org/2653923008/ )

Reason for revert:
Suspected to cause CHECK() failure (crbug.com/711703)
inside PendingScript's prefinalizer.

BUG=711703

Original issue's description:
> Split PendingScript into PendingScript and ClassicPendingScript
>
> This is preparation for introducing ModulePendingScript.
>
> BUG=594639, 686281
>
> Review-Url: https://codereview.chromium.org/2653923008
> Cr-Commit-Position: refs/heads/master@{#464494}
> Committed: https://chromium.googlesource.com/chromium/src/+/d512803299c01324b92ffd8c962da97e3bc8ccff

TBR=kouhei@chromium.org,sigbjornf@opera.com,japhet@chromium.org,haraken@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594639, 686281

Review-Url: https://codereview.chromium.org/2820753002
Cr-Commit-Position: refs/heads/master@{#464768}
(cherry picked from commit 56f27b6)

Review-Url: https://codereview.chromium.org/2827473002 .
Cr-Commit-Position: refs/branch-heads/3071@{#18}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
rogerwang pushed a commit that referenced this pull request Jul 20, 2017
Revert "Listen to changes to touch input devices"
6b860e9 
This reverts commit 1b60006.

Reason for revert:
Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash.

Failing build (chromeos-side waterfall):
https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205

Stack (from running manually with chrome --mash on Linux):

[60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created.
#0 0x7f06a03468bc base::debug::StackTrace::StackTrace()
#1 0x7f06a036a121 logging::LogMessage::~LogMessage()
#2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance()
#3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl()
#4 0x55f1834066ad chromeos::ShowLoginWizard()
#5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize()
#6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit()
#7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun()
#9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun()
#11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow()
#12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks()
#13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize()
#14 0x7f069d9e0b57 content::BrowserMain()
#15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run()
#16 0x7f06a0890d39 service_manager::Main()
#17 0x7f069e1e7384 content::ContentMain()
#18 0x55f182e8132f ChromeMain
#19 0x7f069454af45 __libc_start_main
#20 0x55f182e81194 <unknown>

Original change's description:
> Listen to changes to touch input devices
>
> In https://codereview.chromium.org/2964823002 the OobeDisplayChooser
> started using the DeviceDataManager to look for touchscreen devices when
> searching for a good primary display to use during OOBE.
>
> On device cold boot the DeviceDataManager has not yet found any
> touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely
> due to lower level systems not being fully initialized).
>
> This CL make LoginDisplayHostImpl an observer of changes to connected
> touchscreen devices, re-triggering the OobeDisplayChooser when the
> DeviceDataManager is notified of the connected touchscreens. This
> overcomes the timing issues on cold boot.
>
> Bug: 738885
> Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd
> Reviewed-on: https://chromium-review.googlesource.com/569958
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Commit-Queue: Felix Ekblom <felixe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487007}

TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

(cherry picked from commit 0cd134a)

Bug: 738885
Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4
Reviewed-on: https://chromium-review.googlesource.com/574731
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#487191}
Signed-off-by: Bernie Thompson <bhthompson@google.com>
Reviewed-on: https://chromium-review.googlesource.com/575149
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#623}
Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Updating XTBs based on .GRDs from branch 3163
0692c33 
TBR=dimu@chromium.org

Change-Id: Ie58d4159b4ca49bec647b3bce92a3b087a537e76

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Change-Id: Ie58d4159b4ca49bec647b3bce92a3b087a537e76
Reviewed-on: https://chromium-review.googlesource.com/583483
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#18}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
Incrementing VERSION to 62.0.3202.8
f90adb4 
TBR=dimu@chromium.org

Change-Id: Iaf732ce4f858f774ef6ed863844f58009589465f
Reviewed-on: https://chromium-review.googlesource.com/650046
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#18}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@sdefresne
Enable JsTranslateManagerTest.PerformancePlaceholder test.
49d1046 
Rewrite the test to check that the time delta measured with javascript
performance.now() is at least greater than the sleep timeout and also
smaller than the delta measured in process with NSDate.

Bug: 690607
Change-Id: I4295aa80b69701b56774b3f9d2006b2b9c76b755
Reviewed-on: https://chromium-review.googlesource.com/716230
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508664}(cherry picked from commit f08a9a2)
Reviewed-on: https://chromium-review.googlesource.com/721243
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#18}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@kenrussell
Fix condition for setting PremultipliedAlpha flag on WebGL layer.
8442507 
It wasn't matching the allocation of the premultiplied_alpha_false_texture_,
leading to rendering errors on ChromeOS.

Note: an attempt was made to test this code path on macOS but there appear to be
bugs in the non-CoreAnimation code path. Will add a test for this and debug
further in a follow-on CL.

TBR=kbr@chromium.org

(cherry picked from commit 49172e4)

Bug: 800993
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9a9d648df9d21026288256dbf19797e35d8fe4f3
Reviewed-on: https://chromium-review.googlesource.com/877505
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530747}
Reviewed-on: https://chromium-review.googlesource.com/879164
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#18}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@stevenjb
ONC: Allow VPN.OpenVPN.UserAuthenticationType to be unspecified
0752d34 
Currently if a policy does not specify UserAuthenticationType,
Password and OTP will be stripped from merged ONC. Insead we
should allow both if unspecified.

TBR=stevenjb@chromium.org

(cherry picked from commit 1a36c69)

Bug: 817617
Change-Id: I2c4a47fb5aa0faaba10d4a76e53bb54671e7f450
Reviewed-on: https://chromium-review.googlesource.com/944617
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540669}
Reviewed-on: https://chromium-review.googlesource.com/949976
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#18}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@steimelchrome
Enable Modern Media Controls and fix layout tests
81fd66a 
This CL enables the modern media controls by default and also fixes all
the layout tests.

Bug: 775534
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b5209f8a6b6d2151bde8a766eccb33f66861660
Reviewed-on: https://chromium-review.googlesource.com/1006520
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550806}(cherry picked from commit 0fade57)
Reviewed-on: https://chromium-review.googlesource.com/1014202
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#18}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Updating XTBs based on .GRDs from branch 3440
a2a61e0 
R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie88fb0e42baa18b8531b67d519e52cd2ed8b0a5c
Reviewed-on: https://chromium-review.googlesource.com/1075817
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#18}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@chrishtr
Re-land: only compute intersection observations if any property tree …
6f559fb 
…state has changed.

The refactoring aspect re-landed earlier; this is a re-land of the core logic in [1]
with a bugfix for the case when a lifecycle update to PrePaintClean intervened
after property tree dirty bit mutation.

[1] https://chromium.googlesource.com/chromium/src/+/cdea59c0db145f8e85ea00e9f6d31642929e2397

Bug: 831762

TBR=chrishtr@chromium.org

(cherry picked from commit e8856dd)

Change-Id: I3cea18ee7b6ef8865e8db6733de90197451f9589
Reviewed-on: https://chromium-review.googlesource.com/1144630
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577001}
Reviewed-on: https://chromium-review.googlesource.com/1147206
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#18}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
Don't treat bookmark apps that aren't locally installed as PWAs.
04d5152 
This means if a PWA is installed on one machine and synced to another
machine such that it isn't locally installed (i.e. it is synced to a
non-Chrome OS machine), it won't be treated as an installed PWA. This
affects features such as the navigation options available.

TBR=benwells@chromium.org

(cherry picked from commit e13d316)

Bug: 874841
Change-Id: I42667edbd7d9ac7dbe2a088d4b11bda422beee8b
Reviewed-on: https://chromium-review.googlesource.com/1195382
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587874}
Reviewed-on: https://chromium-review.googlesource.com/1203750
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#18}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
CrOS Shelf: Decrease space between back & app list buttons
f3e3481 
Decrease it by the equivalent of the spacing between two buttons
(8 px in the new UI).

(See the attached bug, comment #18 for the UX request for this)

TBR=manucornet@chromium.org

(cherry picked from commit d853529)

Bug: 874161
Change-Id: I1b309f9fbc3c0c9cc7882fe70177ad9c052455d6
Reviewed-on: https://chromium-review.googlesource.com/1200945
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588540}
Reviewed-on: https://chromium-review.googlesource.com/1213966
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#166}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Remove chrome://flags/#enable-ephemeral-flash-permission.
4395f04 
Bug: 892156
Change-Id: I2daa27782f4765d7f770505b0a198b5632678cc6
Reviewed-on: https://chromium-review.googlesource.com/c/1264660
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599317}(cherry picked from commit 6374c9b)
Reviewed-on: https://chromium-review.googlesource.com/c/1280263
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#18}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
[cherry-pick M72] Fix issue where translate retries were broken.
de317d5 
This was because I was overriding XMLHttpRequest's open and send
functions a second time when reinjecting the scripts. The fix is to
ensure those functions are only overriden once.

TBR=jzw@chromium.org

(cherry picked from commit d8cb404)

Bug: 910284
Change-Id: I1bf203b45865275ec2cbf5e52ab388a5064de16e
Reviewed-on: https://chromium-review.googlesource.com/c/1356014
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612708}
Reviewed-on: https://chromium-review.googlesource.com/c/1359309
Reviewed-by: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#18}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@steimelchrome
[Global Media Controls] Add HardwareMediaKeyHandling flag to Mac OS
ffca5c1 
This CL allows the HardwareMediaKeyHanding flag show up in
chrome://flags on Mac OS.

Bug: 925178
Change-Id: Ibccd349ec273fdca1ed5ee798f64803ee0649018
Reviewed-on: https://chromium-review.googlesource.com/c/1436151
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#625949}(cherry picked from commit 424f820)
Reviewed-on: https://chromium-review.googlesource.com/c/1439941
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#18}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@rkgibson2
[iOS] Remove omnibox popup animations
626580e 
This CL removes the omnibox popup animations. They were very short and
difficult to notice. This also fixes a bug that comes from when the
close animation is triggered twice in the same runloop.

Bug: 938676
Change-Id: I06f3b34f7be70ed2d40b8100adb6a43f4c1c9629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511078
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639011}(cherry picked from commit 31873b8402a0ad6a10f7abd8c6def0d62c74e614)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514058
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#18}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
pdigennaro pushed a commit to washezium/chromium.src that referenced this pull request May 14, 2019
@longsleep @pdigennaro
translate: disable fetching of translate languages from server
6c67070 
GH issue nwjs#18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtg-gg @rogerwang @jefry-vcube