Fix CMake for GLFW_Vulkan and add CMake for SDL_Vulkan on Linux#4386
Open
ProfFan wants to merge 1 commit intoocornut:dockingfrom
Open
Fix CMake for GLFW_Vulkan and add CMake for SDL_Vulkan on Linux#4386ProfFan wants to merge 1 commit intoocornut:dockingfrom
ProfFan wants to merge 1 commit intoocornut:dockingfrom
Conversation
Contributor
|
Thank you for PR @ProfFan. This however breaks builds in multiple occasions. pkg-config is not available on windows if not using msys2 or similar environment so that would break example_glfw_vulkan build. Similarly |
Author
|
Hi @rokups , thanks for the suggestions! I can change the CMake to fallback to the original method if the new method does not succeed. |
|
damn, which I checked here first, took me awhile to figure this out myself. +1 for "Should be helpful for anyone getting started in IMGUI." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the GLFW and SDL2 Vulkan examples so they build cleanly on any modern Linux OS.
Should be helpful for anyone getting started in IMGUI.