Skip to content

Comments

Fix CMake for GLFW_Vulkan and add CMake for SDL_Vulkan on Linux#4386

Open
ProfFan wants to merge 1 commit intoocornut:dockingfrom
ProfFan:add_cmake
Open

Fix CMake for GLFW_Vulkan and add CMake for SDL_Vulkan on Linux#4386
ProfFan wants to merge 1 commit intoocornut:dockingfrom
ProfFan:add_cmake

Conversation

@ProfFan
Copy link

@ProfFan ProfFan commented Aug 1, 2021

This fixes the GLFW and SDL2 Vulkan examples so they build cleanly on any modern Linux OS.

Should be helpful for anyone getting started in IMGUI.

@rokups
Copy link
Contributor

rokups commented Aug 2, 2021

Thank you for PR @ProfFan. This however breaks builds in multiple occasions. pkg-config is not available on windows if not using msys2 or similar environment so that would break example_glfw_vulkan build. Similarly example_sdl2_vulkan would not build with older cmake versions because FindVulkan was introduced in cmake v3.7 while build script requires only v3.0.

@ProfFan
Copy link
Author

ProfFan commented Aug 4, 2021

Hi @rokups , thanks for the suggestions! I can change the CMake to fallback to the original method if the new method does not succeed.

@smellymoo
Copy link

damn, which I checked here first, took me awhile to figure this out myself.

+1 for "Should be helpful for anyone getting started in IMGUI."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants