Skip to content

[5 of 7] Add queued core turn context op#22508

Open
etraut-openai wants to merge 6 commits into
etraut/next-turn-state-remove-override-contextfrom
etraut/next-turn-state-core
Open

[5 of 7] Add queued core turn context op#22508
etraut-openai wants to merge 6 commits into
etraut/next-turn-state-remove-override-contextfrom
etraut/next-turn-state-core

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented May 13, 2026

Stack position: [5 of 7]

Summary

This PR adds Op::TurnContext, which provides a queued update mechanism for updating the turn context without starting a new turn.

Changes

  • Add Op::TurnContext for context-only queued updates.
  • Emit TurnContextApplied with the effective turn-context snapshot after core applies an update.
  • Route context-only updates through the same submission queue as user input.

This stack addresses #20656 and #22090.

Stack

  1. [1 of 7] Add turn context to UserInput
  2. [2 of 7] Remove UserInputWithTurnContext
  3. [3 of 7] Remove UserTurn
  4. [4 of 7] Remove core OverrideTurnContext op
  5. [5 of 7] Add queued core turn context op (this PR)
  6. [6 of 7] Add app-server next-turn state API
  7. [7 of 7] Sync TUI next-turn state

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63a3a26013

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/codex_thread.rs
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3105be32a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/protocol/src/protocol.rs
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a46e9baa4b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/protocol/src/protocol.rs
Comment thread codex-rs/protocol/src/protocol.rs
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34263f13ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/codex_thread.rs Outdated
@etraut-openai etraut-openai changed the title [1 of 3] Add core next-turn state plumbing [2 of 4] Add queued core turn context op May 16, 2026
@etraut-openai etraut-openai changed the base branch from main to etraut/next-turn-state-input-op-consolidation May 16, 2026 20:29
@etraut-openai etraut-openai changed the title [2 of 4] Add queued core turn context op [4 of 6] Add queued core turn context op May 16, 2026
@etraut-openai etraut-openai force-pushed the etraut/next-turn-state-core branch from b2fa7ac to 9393c26 Compare May 16, 2026 22:50
@etraut-openai etraut-openai changed the title [4 of 6] Add queued core turn context op [5 of 7] Add queued core turn context op May 16, 2026
@etraut-openai etraut-openai changed the base branch from etraut/next-turn-state-input-op-consolidation to etraut/next-turn-state-remove-override-context May 16, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants