Skip to content

[3 of 7] Remove UserTurn#23075

Open
etraut-openai wants to merge 6 commits into
etraut/next-turn-state-remove-user-input-with-contextfrom
etraut/next-turn-state-input-op-consolidation
Open

[3 of 7] Remove UserTurn#23075
etraut-openai wants to merge 6 commits into
etraut/next-turn-state-remove-user-input-with-contextfrom
etraut/next-turn-state-input-op-consolidation

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented May 16, 2026

Stack position: [3 of 7]

Summary

This PR finishes the input-op consolidation by moving the remaining Op::UserTurn callers onto Op::UserInput and deleting Op::UserTurn. This touches a lot of files, but it's a low-risk mechanical migration.

Stack

  1. [1 of 7] Add turn context to UserInput
  2. [2 of 7] Remove UserInputWithTurnContext
  3. [3 of 7] Remove UserTurn (this PR)
  4. [4 of 7] Remove core OverrideTurnContext op
  5. [5 of 7] Add queued core turn context op
  6. [6 of 7] Add app-server next-turn state API
  7. [7 of 7] Sync TUI next-turn state

@etraut-openai etraut-openai requested a review from a team as a code owner May 16, 2026 20:19
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30f6ab2372

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/protocol/src/protocol.rs
…into etraut/next-turn-state-input-op-consolidation

# Conflicts:
#	codex-rs/app-server/src/request_processors/turn_processor.rs
#	codex-rs/core/src/session/handlers.rs
#	codex-rs/protocol/src/protocol.rs
@etraut-openai etraut-openai changed the title [1 of 4] Consolidate core input ops [3 of 6] Remove UserTurn May 16, 2026
@etraut-openai etraut-openai changed the base branch from main to etraut/next-turn-state-remove-user-input-with-context May 16, 2026 21:25
@etraut-openai etraut-openai changed the title [3 of 6] Remove UserTurn [3 of 7] Remove UserTurn May 16, 2026
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db6e9bfaa9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/protocol/src/protocol.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant