Skip to content

[4 of 7] Remove core OverrideTurnContext op#23087

Open
etraut-openai wants to merge 6 commits into
etraut/next-turn-state-input-op-consolidationfrom
etraut/next-turn-state-remove-override-context
Open

[4 of 7] Remove core OverrideTurnContext op#23087
etraut-openai wants to merge 6 commits into
etraut/next-turn-state-input-op-consolidationfrom
etraut/next-turn-state-remove-override-context

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented May 16, 2026

Stack position: [4 of 7]

Summary

This PR removes the legacy Op::OverrideTurnContext which has no production callers. The next PR will introduce a new Op::TurnCodex which has similar, but not identical, semantics to the legacy op.

Changes

  • Delete Op::OverrideTurnContext from the core protocol and submission loop.
  • Move tests that used that op onto the existing thread-level turn-context override shape.
  • Keep the new queued context-only op out of this PR; that is introduced in the next stack layer.

This stack addresses #20656 and #22090.

Stack

  1. [1 of 7] Add turn context to UserInput
  2. [2 of 7] Remove UserInputWithTurnContext
  3. [3 of 7] Remove UserTurn
  4. [4 of 7] Remove core OverrideTurnContext op (this PR)
  5. [5 of 7] Add queued core turn context op
  6. [6 of 7] Add app-server next-turn state API
  7. [7 of 7] Sync TUI next-turn state

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 875b846721

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/tests/suite/override_updates.rs
Comment thread codex-rs/core/tests/suite/override_updates.rs
@etraut-openai
Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b47db287d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/codex_thread.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant