Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252695: Shenandoah: clean up Graal enabled/disabled filter in tests #51

Closed
wants to merge 2 commits into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 7, 2020

Drop !vm.graal.enabled since it is not required after JDK-8249000.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252695: Shenandoah: clean up Graal enabled/disabled filter in tests

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/51/head:pull/51
$ git checkout pull/51

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 7, 2020

/issue add JDK-8252695

@bridgekeeper bridgekeeper bot added the oca label Sep 7, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2020

Hi @shipilev, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user shipilev" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@shipilev The following labels will be automatically applied to this pull request: hotspot-gc shenandoah.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@bridgekeeper bridgekeeper bot removed the oca label Sep 7, 2020
@openjdk openjdk bot added the rfr label Sep 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@shipilev This issue is referenced in the PR title - it will now be updated.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2020

Webrevs

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Sep 8, 2020

There are a few more tests, I believe, need to be fixed as well:

gcbasher/TestGCBasherWithShenandoah.java
gclocker/TestGCLockerWithShenandoah.java
gcold/TestGCOldWithShenandoah.java
compiler/c2/aarch64/TestVolatilesShenandoah.java

@openjdk openjdk bot added hotspot and removed hotspot-gc labels Sep 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252695: Shenandoah: clean up Graal enabled/disabled filter in tests

Reviewed-by: zgu
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 14 commits pushed to the master branch:

  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • bf5da0c: 8252897: Minor .jcheck/conf update
  • 7600274: 8252859: Inconsistent use of alpha in class AbsSeq
  • 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
  • 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
  • 2cceeed: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
  • 188b0bc: 8252868: Clean up unused function from G1MMUTracker
  • 891886b: 8252887: Zero VM is broken after JDK-8252661
  • 7686e87: 8250968: Symlinks attributes not preserved when using jarsigner on zip files
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/e0c8d4420c8e1a84581927cf77314498b8e5aa52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 704f784c88ee282837c980948167e741e7227f27.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 8, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 8, 2020

/integrate

@openjdk openjdk bot closed this Sep 8, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@shipilev Since your change was applied there have been 14 commits pushed to the master branch:

  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • bf5da0c: 8252897: Minor .jcheck/conf update
  • 7600274: 8252859: Inconsistent use of alpha in class AbsSeq
  • 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
  • 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
  • 2cceeed: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
  • 188b0bc: 8252868: Clean up unused function from G1MMUTracker
  • 891886b: 8252887: Zero VM is broken after JDK-8252661
  • 7686e87: 8250968: Symlinks attributes not preserved when using jarsigner on zip files
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/e0c8d4420c8e1a84581927cf77314498b8e5aa52...master

Your commit was automatically rebased without conflicts.

Pushed as commit 91a20ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Parth-Pandya1606
Copy link

@Parth-Pandya1606 Parth-Pandya1606 commented Sep 8, 2020

Hi @Parth-Pandya1606, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user Parth-Pandya1606 for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

@shipilev shipilev deleted the shipilev:JDK-8252695 branch Sep 8, 2020
dankm pushed a commit to dankm/openjdk that referenced this pull request Oct 27, 2020
* On versions of FreeBSD with PROC_STACKGAP_CTL, disable the placing of
  stack guard pages by the kernel.

  This fixes issue openjdk#51 on those versions of FreeBSD

Sponsored by:	The FreeBSD Foundation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants