Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252868: Clean up unused function from G1MMUTracker #58

Closed
wants to merge 2 commits into from

Conversation

kstefanj
Copy link
Contributor

@kstefanj kstefanj commented Sep 7, 2020

Please review this cleanup to remove a few unused functions from the G1MMUTracker interface.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252868: Clean up unused function from G1MMUTracker

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/58/head:pull/58
$ git checkout pull/58

@kstefanj kstefanj changed the title Jdk 8252868 8252868: Clean up unused function from G1MMUTracker Sep 7, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back sjohanss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@kstefanj The following label will be automatically applied to this pull request: hotspot-gc.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Mailing list message from Thomas Schatzl on hotspot-gc-dev:

Hi Stefan,

On 07.09.20 16:09, Stefan Johansson wrote:

lgtm and trivial.

Thomas

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@kstefanj This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252868: Clean up unused function from G1MMUTracker

Reviewed-by: tschatzl
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 6 commits pushed to the master branch:

  • 891886b: 8252887: Zero VM is broken after JDK-8252661
  • 7686e87: 8250968: Symlinks attributes not preserved when using jarsigner on zip files
  • 8d6d43c: 8251193: bin/idea.sh is generating wrong folder definitions for JVMCI modules
  • 70d5cac: 8251152: ARM32: jtreg c2 Test8202414 test crash
  • e0d5b5f: 8252627: Make it safe for JFR thread to read threadObj
  • e29c3f6: 8252661: Change SafepointMechanism terminology to talk less about "blocking"

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 891886b622af73107cd55aae68aeb08d9928a637.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2020
@kstefanj
Copy link
Contributor Author

kstefanj commented Sep 8, 2020

/integrate

@openjdk openjdk bot closed this Sep 8, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@kstefanj Since your change was applied there have been 6 commits pushed to the master branch:

  • 891886b: 8252887: Zero VM is broken after JDK-8252661
  • 7686e87: 8250968: Symlinks attributes not preserved when using jarsigner on zip files
  • 8d6d43c: 8251193: bin/idea.sh is generating wrong folder definitions for JVMCI modules
  • 70d5cac: 8251152: ARM32: jtreg c2 Test8202414 test crash
  • e0d5b5f: 8252627: Make it safe for JFR thread to read threadObj
  • e29c3f6: 8252661: Change SafepointMechanism terminology to talk less about "blocking"

Your commit was automatically rebased without conflicts.

Pushed as commit 188b0bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kstefanj kstefanj deleted the JDK-8252868 branch September 8, 2020 15:48
cushon pushed a commit to cushon/jdk that referenced this pull request Apr 2, 2021
caojoshua pushed a commit to caojoshua/jdk that referenced this pull request Jul 26, 2023
* JVM-1515: PEA supports object composition

* Update comments.

---------

Co-authored-by: Xin Liu <xxinliu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
2 participants