Skip to content

setup assisted-installer version v2.55#82233

Closed
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-21ce98cb-b259-4ff5-82eb-5beeac35bebf
Closed

setup assisted-installer version v2.55#82233
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-21ce98cb-b259-4ff5-82eb-5beeac35bebf

Conversation

@danmanor

@danmanor danmanor commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Adds OpenShift CI configurations for the v2.55 branches of the assisted-installer ecosystem:

  • assisted-installer
  • assisted-service
  • assisted-installer-agent
  • assisted-image-service

The configurations define v2.55-based image builds, edge-infrastructure image promotion, nightly OCP 5.0 release inputs, resource defaults, and generated metadata. They also add linting, unit/subsystem tests, Codecov integration, image mirroring, and comprehensive assisted-installation e2e coverage across bare metal, IPv6, SNO, CNV, LVM, ODF, OCI, vSphere, Day 2, upgrade, and external-provider scenarios.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 24d6a77f-95da-480e-be85-d3bc7dfeac94

📥 Commits

Reviewing files that changed from the base of the PR and between 243455e and 57ecc4d.

⛔ Files ignored due to path filters (8)
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml
  • ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml

Walkthrough

Adds v2.55 CI/operator configurations for assisted-image-service, assisted-installer-agent, assisted-installer, and assisted-service, including image builds, promotion, validation jobs, and extensive end-to-end test workflows.

Changes

Assisted v2.55 CI configuration

Layer / File(s) Summary
Release and build contracts
ci-operator/config/openshift/{assisted-image-service,assisted-installer-agent,assisted-installer,assisted-service}/*v2.55.yaml
Pins component images and release candidates to v2.55/OCP 5.0, defines build outputs and promotion, applies resource defaults, and records generated metadata.
Validation and subsystem jobs
ci-operator/config/openshift/{assisted-installer-agent,assisted-installer,assisted-service}/*v2.55.yaml
Adds mirror, lint, formatting, unit-test, generated-code, and AWS subsystem jobs with cache, report, secret, and change-filter settings.
End-to-end workflow matrix
ci-operator/config/openshift/{assisted-image-service,assisted-installer-agent,assisted-installer,assisted-service}/*v2.55.yaml
Adds platform, provider, operator, architecture, day-two, upgrade-agent, virtualization, OpenShift AI, OCI, vSphere, and TNA workflow variants.
Estimated code review effort: 3 (Moderate) ~30 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main intent of setting up v2.55 assisted-installer CI configuration, though the PR also updates related assisted-service components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only adds ci-operator YAML; no Go/test files changed, and the new names are static CI job ids, not Ginkgo titles.
Test Structure And Quality ✅ Passed PASS: PR only adds ci-operator YAML/job configs; no Ginkgo .go test code or test logic changed, so this test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PASS: Only CI YAML changed; no new Ginkgo test code was added, and the referenced baremetal test step skips entirely when TEST_TYPE=none.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only CI YAML was added; no new Ginkgo test code changed, and the e2e job names already existed in v2.54 configs.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only adds ci-operator test/config YAMLs; no deployment manifests, controllers, or pod scheduling fields (affinity, nodeSelector, PDB, spread constraints) were introduced.
Ote Binary Stdout Contract ✅ Passed Only ci-operator config/job YAML changed; no process-level code or suite setup touched, so the stdout contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: v2.55 configs only bump version refs; the e2e job set is unchanged from v2.54, and the quay.io refs were preexisting, so no new IPv4/external-connectivity test code was introduced.
No-Weak-Crypto ✅ Passed Scanned all changed YAML/job manifests; found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret-comparison code.
Container-Privileges ✅ Passed Scanned all added v2.55 config/job YAMLs: no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, SYS_ADMIN, or securityContext flags found.
No-Sensitive-Data-In-Logs ✅ Passed No step logs secrets or PII; added secret use only reads Codecov tokens from mounted secrets, with no echo/trace commands or exposed values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-day2 openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-external openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-ipv4v6 openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-lvm openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-none openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-openshift-ai openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-osc openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-single-node openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-static-ip-suite openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-tna openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-metal-assisted-virtualization openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-e2e-vsphere-assisted openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-images openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-lint openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-subsystem-aws openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-unit-test openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-service-v2.55-verify-generated-code openshift/assisted-service presubmit Presubmit changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Presubmit changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-cnv openshift/assisted-installer-agent presubmit Presubmit changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-day2 openshift/assisted-installer-agent presubmit Presubmit changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-external openshift/assisted-installer-agent presubmit Presubmit changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-ipv6 openshift/assisted-installer-agent presubmit Presubmit changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-lvm openshift/assisted-installer-agent presubmit Presubmit changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-odf openshift/assisted-installer-agent presubmit Presubmit changed

A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
openshift-ci Bot requested review from giladravid16 and javipolo July 21, 2026 16:13
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2026
@danmanor

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #82358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants