setup assisted-installer version v2.55#82358
Conversation
WalkthroughAdds generated v2.55 CI/operator configurations for assisted-image-service, assisted-installer-agent, assisted-installer, and assisted-service, covering image builds, release promotion, resource requests, standard CI jobs, and parameterized E2E workflows. ChangesAssisted v2.55 CI configuration
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yamlTraceback (most recent call last): ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yamlTraceback (most recent call last): ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yamlTraceback (most recent call last):
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml`:
- Around line 190-194: Update the e2e-metal-assisted-lvm job configuration by
removing either always_run or run_if_changed so the job uses only its intended
trigger; preserve the remaining trigger and the existing job settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: fd00345f-7781-42ce-8cbc-5561f6b62cd5
⛔ Files ignored due to path filters (8)
ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yamlci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml
| - always_run: true | ||
| as: e2e-metal-assisted-lvm | ||
| capabilities: | ||
| - intranet | ||
| run_if_changed: ^(internal/operators/[^/]+\.go|internal/operators/lvm/.*|internal/operators/api/.*|internal/operators/handler/.*)$ |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🌐 Web query:
ci-operator config test always_run and run_if_changed mutually exclusive
💡 Result:
Yes, the fields always_run and run_if_changed are mutually exclusive in ci-operator configuration when always_run is set to true [1][2]. Specifically, the official documentation for ci-operator states that run_if_changed, skip_if_only_changed, and always_run: true are mutually exclusive [1][2]. To understand how these fields interact: - always_run: Defaults to true, meaning the job runs on every pull request unless configured otherwise [1][2]. - run_if_changed: Sets a regular expression to trigger the job only when a pull request changes a matching file path [1][2]. - Because run_if_changed implies conditional execution based on path changes, it cannot be combined with always_run: true, which forces unconditional execution [1][2]. - If you need to disable automatic triggering on every pull request, you should set always_run: false [1][3][2]. These constraints apply to both the tests stanza and the images stanza within the ci-operator configuration [1][2].
Citations:
- 1: https://docs.ci.openshift.org/docs/architecture/ci-operator/
- 2: https://github.com/openshift/ci-docs/blob/main/content/en/architecture/ci-operator.md
- 3: https://docs.ci.openshift.org/how-tos/contributing-openshift-release/
🏁 Script executed:
#!/bin/bash
set -euo pipefail
file="ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml"
# Show the relevant section with line numbers.
sed -n '175,205p' "$file" | cat -n
# Quickly confirm the two fields are both present in the same job stanza.
python3 - <<'PY'
from pathlib import Path
text = Path("ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml").read_text()
for marker in ["always_run: true", "run_if_changed: ^(internal/operators/[^/]+\\.go|internal/operators/lvm/.*|internal/operators/api/.*|internal/operators/handler/.*)$"]:
print(marker, "=>", marker in text)
PYRepository: openshift/release
Length of output: 1489
Drop either always_run or run_if_changed from e2e-metal-assisted-lvm. always_run: true is mutually exclusive with run_if_changed in ci-operator configs, so this job should keep only the intended trigger.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml`
around lines 190 - 194, Update the e2e-metal-assisted-lvm job configuration by
removing either always_run or run_if_changed so the job uses only its intended
trigger; preserve the remaining trigger and the existing job settings.
Source: Learnings
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing as duplicate of #82412 |
2 participants
Summary by CodeRabbit
Adds OpenShift CI configurations for the Assisted Installer v2.55 release across:
assisted-image-serviceassisted-installer-agentassisted-installerassisted-serviceThe configurations define v2.55-based image builds,
edge-infrastructurepromotion, nightly OCP 5.0 release candidates, resource defaults, and repository-based build roots. They also establish lint, unit, subsystem, image-mirroring, and broad end-to-end test coverage across bare metal, OCI, vSphere, external platforms, and operator-specific scenarios.