ci: GitHub Actions hygeine and MSRV 1.88 - #1693
Conversation
Looks in main our actual MSRV is 1.88.0 (2025-06-26). dropshot/dropshot_endpoint/src/api_trait.rs Line 234 in 9bd5107 To support 1.85, in addition to rolling back subprocess = "=0.2.9" # (2022-05-15) 0.2.10+ requires Rust 1.88
trybuild = "=1.0.119" # (2026-08-02) 1.0.120+ requires Rust 1.88
rcgen = "=0.14.7" # (2026-01-19) 0.14.8+ requires Rust 1.88So I've gone ahead and explicitly bumped MSRV to 1.88 (from 1.85). |
|
This requires adjusting the required test passage configuration in the GitHub repo settings. Remove: Add: |
|
Largely superseded by: @sunshowers: Your PRs came a few hours after I opened this one. Great minds think alike. :D I wonder whether your agent found my branch or we just did near identical work in parallel. Remaining changes have been moved to a clean PR: |
# v7.0.0)rustupis in base runner)rustup defaultto using explicitRUSTUP_TOOLCHAIN,as the former is overridden by the existence of a
rust-toolchain.tomlCARGO_INCREMENTAL=0to match the previous behavior provided by dtolnay/rust-toolchain.trybuildas a dedicated ubuntu job, rather than as part of the matrix because rustc output differs between (stable, msrv).I think it's ok to not run this on every platform as the rustc output should be (has been) identical between platforms and if not, it's a rustc bug not a dropshot issue.
Before:
build-and-test (macos-14, all, 1.85)After:
build-and-test (macos-14, all, msrv)Unchanged:
build-and-test (macos-14, all, stable)Note
Until this change we were not actually testing under our specified MSRV (1.85)
Which meant we didn't realize that our MSRV was actually 1.88.
See example run output