raise the MSRV to 1.88 - #1694
Merged
Merged
Conversation
sunshowers
marked this pull request as draft
September 2, 2026 19:48
sunshowers
changed the base branch from
main
to
jj-stack/run-trybuild-tests-in-their-own-ci-job-vynqoztq
September 2, 2026 20:08
sunshowers
force-pushed
the
jj-stack/raise-the-msrv-to-1-88-wmwvorqo
branch
from
September 2, 2026 20:08
01b7b04 to
c87c1ee
Compare
Collaborator
Author
Revision history
Generated by jj-stack from this pull request's force-push history. |
sunshowers
marked this pull request as ready for review
September 2, 2026 20:24
ahl
approved these changes
Sep 2, 2026
Base automatically changed from
jj-stack/run-trybuild-tests-in-their-own-ci-job-vynqoztq
to
main
September 2, 2026 20:51
sunshowers
force-pushed
the
jj-stack/raise-the-msrv-to-1-88-wmwvorqo
branch
from
September 2, 2026 20:51
c87c1ee to
78b4c7f
Compare
dropshot_endpoint already uses a let chain (stabilized in Rust 1.88), so the declared MSRV of 1.85 no longer builds:
error[E0658]: `let` expressions in this position are unstable
--> dropshot_endpoint/src/api_trait.rs:235:20
Specify an MSRV of 1.88 and fix CI to check for it. In upcoming commits we're going to add more let chains.
sunshowers
force-pushed
the
jj-stack/raise-the-msrv-to-1-88-wmwvorqo
branch
from
September 2, 2026 21:08
78b4c7f to
e0e2280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dropshot_endpoint already uses a let chain (stabilized in Rust 1.88), so the declared MSRV of 1.85 no longer builds:
Specify an MSRV of 1.88 and fix CI to check for it. In upcoming commits we're going to add more let chains.
After #1695 and this PR, the CI test matrix is: