Skip to content

raise the MSRV to 1.88 - #1694

Merged
sunshowers merged 1 commit into
mainfrom
jj-stack/raise-the-msrv-to-1-88-wmwvorqo
Sep 2, 2026
Merged

raise the MSRV to 1.88#1694
sunshowers merged 1 commit into
mainfrom
jj-stack/raise-the-msrv-to-1-88-wmwvorqo

Conversation

@sunshowers

@sunshowers sunshowers commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

dropshot_endpoint already uses a let chain (stabilized in Rust 1.88), so the declared MSRV of 1.85 no longer builds:

error[E0658]: `let` expressions in this position are unstable
   --> dropshot_endpoint/src/api_trait.rs:235:20

Specify an MSRV of 1.88 and fix CI to check for it. In upcoming commits we're going to add more let chains.

After #1695 and this PR, the CI test matrix is:

  • all tests except trybuild ones on MSRV and stable, and across Linux/macOS/Windows
  • trybuild tests on pinned toolchain on Linux

@sunshowers
sunshowers requested a review from ahl September 2, 2026 19:39
@sunshowers
sunshowers marked this pull request as draft September 2, 2026 19:48
@sunshowers
sunshowers changed the base branch from main to jj-stack/run-trybuild-tests-in-their-own-ci-job-vynqoztq September 2, 2026 20:08
@sunshowers
sunshowers force-pushed the jj-stack/raise-the-msrv-to-1-88-wmwvorqo branch from 01b7b04 to c87c1ee Compare September 2, 2026 20:08
@sunshowers

sunshowers commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

Revision history

Version Changes from previous version Submitted commit
4 (current) 78b4c7ff..e0e2280e e0e2280e
3 c87c1ee5..78b4c7ff 78b4c7ff
2 01b7b044..c87c1ee5 c87c1ee5
1 Initial version 01b7b044

Generated by jj-stack from this pull request's force-push history.

@sunshowers
sunshowers marked this pull request as ready for review September 2, 2026 20:24
Base automatically changed from jj-stack/run-trybuild-tests-in-their-own-ci-job-vynqoztq to main September 2, 2026 20:51
@sunshowers
sunshowers force-pushed the jj-stack/raise-the-msrv-to-1-88-wmwvorqo branch from c87c1ee to 78b4c7f Compare September 2, 2026 20:51
dropshot_endpoint already uses a let chain (stabilized in Rust 1.88), so the declared MSRV of 1.85 no longer builds:

    error[E0658]: `let` expressions in this position are unstable
       --> dropshot_endpoint/src/api_trait.rs:235:20

Specify an MSRV of 1.88 and fix CI to check for it. In upcoming commits we're going to add more let chains.
@sunshowers
sunshowers force-pushed the jj-stack/raise-the-msrv-to-1-88-wmwvorqo branch from 78b4c7f to e0e2280 Compare September 2, 2026 21:08
@sunshowers
sunshowers merged commit 8ef467e into main Sep 2, 2026
18 checks passed
@sunshowers
sunshowers deleted the jj-stack/raise-the-msrv-to-1-88-wmwvorqo branch September 2, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants