run trybuild tests in their own CI job - #1695
Merged
sunshowers merged 1 commit intoSep 2, 2026
Merged
Conversation
The trybuild tests require a pinned toolchain for output stability. By accident, we were using the pinned toolchain on all CI jobs -- the next commit fixes this, which ends up breaking the trybuild tests. Move the tests into their own job that explicitly depends on the pinned toolchain. The trybuild output doesn't depend on the OS, so we don't need to use a matrix setup for it -- just run it on Linux.
Merged
ahl
approved these changes
Sep 2, 2026
sunshowers
deleted the
jj-stack/run-trybuild-tests-in-their-own-ci-job-vynqoztq
branch
September 2, 2026 20:51
sunshowers
added a commit
that referenced
this pull request
Sep 2, 2026
dropshot_endpoint already uses a let chain (stabilized in Rust 1.88), so
the declared MSRV of 1.85 no longer builds:
error[E0658]: `let` expressions in this position are unstable
--> dropshot_endpoint/src/api_trait.rs:235:20
Specify an MSRV of 1.88 and fix CI to check for it. In upcoming commits
we're going to add more let chains.
After #1695 and this PR, the CI test matrix is:
* all tests except trybuild ones on MSRV and stable, and across
Linux/macOS/Windows
* trybuild tests on pinned toolchain on Linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trybuild tests require a pinned toolchain for output stability. By accident, we were using the pinned toolchain on all CI jobs -- the next commit fixes this, which ends up breaking the trybuild tests.
Move the tests into their own job that explicitly depends on the pinned toolchain.
The trybuild output doesn't depend on the OS, so we don't need to use a matrix setup for it -- just run it on Linux.
(After this lands we should probably mark the trybuild job required.)