Skip to content

Conversation

@zfi
Copy link
Contributor

@zfi zfi commented Jun 17, 2019

Preparing for release of the 1.2 branch into production.

Change Log to follow in the PR review.

MatzElectronics and others added 30 commits December 10, 2018 16:52
Issue #1638 - Update Help URI to point to help system hosted on learn
Address corner use case on issue #1500
textile file used in the original deployment.
name as a search key. Created new method to obtain screen name directly
from user profile.
pjewald and others added 24 commits March 7, 2019 15:19
Issue 1522 - Add support for project settings field
Corrected error in v2 REST API access level.
…L-5 but are necessary for current browsers using HTML 4.01.
Makes XML view consistent with other buttons - will match changes in CDN CSS
Correct Javascript declarations and add support for library metadata.
Fixing a conflagration
Update application version for 1.2 release
@zfi zfi requested review from MatzElectronics and PropGit June 17, 2019 17:46
<span style="color:#777; font-size:11px;" class="auth-false" data-displayas="inline"><a href="login.jsp" class="url-prefix"><span class="keyed-lang-string" data-key="editor_demonstration_mode_instructions"></span></a>&nbsp;&nbsp;&nbsp;</span>
<a id="prop-btn-find-replace" style="display: none;" onclick="findReplaceCode();" data-toggle="tooltip" title="" data-placement="bottom" class="btn btn-info btn-circle"><svg xmlns="http://www.w3.org/2000/svg" width="14" height="15"><path d="M1.5,13.25 L4.5,8.75" style="stroke:#fff;stroke-width:2px;fill:none;"/><circle cx="7" cy="5" r="3.5" style="stroke:#fff;stroke-width:1.5px;fill:none;"></circle></svg></a>
<a id="prop-btn-pretty" style="display: none;" onclick="prettyCode(null)" data-toggle="tooltip" title="" data-placement="bottom" class="btn btn-info btn-circle"><svg xmlns="http://www.w3.org/2000/svg" width="14" height="15"><path d="M1,10 L5,10 5,11 1,11 Z M2,12 L6,12 6,13 2,13 Z M1,14 5,14 5,15 1,15 Z M0.5,2.75 L2.5,0.6 5.5,3.5 3.5,5.5 Z M5,7 L7,4.75 14,12 12,14 Z M0,7 Q1.5,6.5 2,5 Q2.5,6.5 4,7 Q2.5,7.5 2,9 Q1.5,7.5 0,7 Z M7,3 Q9.5,2.5 10,0 Q10.5,2.5 13,3 Q10.5,3.5 10,6 Q9.5,3.5 7,3 Z" style="stroke-width:0;fill:#fff;"/></svg></a>
<a id="prop-btn-pretty" style="display: none;" onclick="formatWizard();" data-toggle="tooltip" title="" data-placement="bottom" class="btn btn-info btn-circle"><svg xmlns="http://www.w3.org/2000/svg" width="14" height="15"><path d="M1,10 L5,10 5,11 1,11 Z M2,12 L6,12 6,13 2,13 Z M1,14 5,14 5,15 1,15 Z M0.5,2.75 L2.5,0.6 5.5,3.5 3.5,5.5 Z M5,7 L7,4.75 14,12 12,14 Z M0,7 Q1.5,6.5 2,5 Q2.5,6.5 4,7 Q2.5,7.5 2,9 Q1.5,7.5 0,7 Z M7,3 Q9.5,2.5 10,0 Q10.5,2.5 13,3 Q10.5,3.5 10,6 Q9.5,3.5 7,3 Z" style="stroke-width:0;fill:#fff;"/></svg></a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatWizard is basically a wrapper for the prettyCode function. It adds some code to track the current line position. Not sure what problem this was supposed to address.

<%@ include file="/WEB-INF/includes/include.jsp"%>
<!DOCTYPE html!>
<html>
<!DOCTYPE html>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatzElectronics Are the updates to fix whatever breaks when the tag is used in this release?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be, if they aren't, the editor would appear to be blank (no blocks would be visible). The main fix is in the CSS file for the editor (style-editor.css I think)

/**
* Limit the number of records that can be returned in list functions
*/
final int REQUEST_LIMIT = 100;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project listings are now limited to 100 records. This is hard coded only because it is not expected to change for the foreseeable future. The calling client is expected to iterate over the selection set.

@zfi zfi merged commit 403e36e into master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants