feat(auth): add password visibility toggle

[PierreBrisorgueil]

Summary

• Add eye icon toggle on password fields in signin, signup, and reset views
• Uses Vuetify append-inner-icon with mdi-eye / mdi-eye-off

Closes #336

Test plan

• Verify eye icon appears on signin password field
• Verify eye icon appears on signup password field
• Verify eye icon appears on reset password field
• Verify clicking toggles between text/password type

Summary by CodeRabbit

• New Features

  • Password visibility toggle added to sign-in, sign-up, and password reset forms — click the eye icon to show/hide password text for easier verification.

• Tests

  • Added unit tests verifying the password visibility toggle initializes hidden and correctly toggles on/off.

[coderabbitai]

Walkthrough

Added a password visibility toggle to three auth views (reset, signin, signup) via a new showPassword data property; updated password fields to switch type and appended icon based on that state. Corresponding unit tests were added to assert the toggle behavior.

Changes

Cohort / File(s)	Summary
Auth view changes src/modules/auth/views/reset.view.vue, src/modules/auth/views/signin.view.vue, src/modules/auth/views/signup.view.vue	Added showPassword: false to component data(). Password inputs now use :type="showPassword ? 'text' : 'password'", include a conditional append-inner icon (eye / eye-slash), and toggle showPassword on @click:append-inner.
Unit tests src/modules/auth/tests/auth.reset.view.unit.tests.js, src/modules/auth/tests/auth.signin.view.unit.tests.js, src/modules/auth/tests/auth.signup.view.unit.tests.js	New tests added to verify showPassword initializes to false and toggles false → true → false on interaction.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete. It lacks key sections from the template: detailed motivation, scope (modules/cross-module impact/risk level), and validation checklist results.	Complete the PR description with template sections including: Why section explaining the motivation, Scope section identifying risk level and modules impacted, and Validation section with completed checklist items and manual test results.
Linked Issues check	⚠️ Warning	The PR adds password visibility toggle functionality, but the linked issue #336 is a Vuetify dependency bump (2.2.15 to 2.2.17). The password toggle feature is unrelated to the dependency upgrade objective.	Either replace the linked issue with the actual feature request for password visibility toggle, or move password toggle implementation to a separate PR addressing the correct issue.
Out of Scope Changes check	⚠️ Warning	The PR changes three auth view files and adds unit tests, all focused on password visibility toggle implementation. However, this feature work is out of scope for the linked Vuetify dependency bump issue #336.	Create a new issue tracking the password visibility toggle feature request and link this PR to it instead of issue #336, which is a dependency maintenance task.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title 'feat(auth): add password visibility toggle' accurately describes the primary change of adding eye icon toggles to password fields.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/password-visibility-toggle

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Adds a password visibility toggle to the auth module’s password inputs (signin, signup, reset) using Vuetify text-field appended icons and a local showPassword state.

Changes:

• Add showPassword state to each auth view.
• Toggle <v-text-field> type between password and text based on showPassword.
• Add an appended icon and click handler to toggle visibility.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
src/modules/auth/views/signup.view.vue	Adds password visibility toggle UI/state to the signup password field.
src/modules/auth/views/signin.view.vue	Adds password visibility toggle UI/state to the signin password field.
src/modules/auth/views/reset.view.vue	Adds password visibility toggle UI/state to the reset password field.

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/modules/auth/views/reset.view.vue`:
- Line 60: Add unit tests for the showPassword behavior in the Reset component:
create tests that mount the reset.view.vue component, assert the initial
reactive property showPassword is false, simulate clicking the visibility toggle
element (the icon/button that flips showPassword) and assert showPassword
toggles, and verify the password input element's type prop changes between
"password" and "text" after each toggle; use the component's public template
selectors (the password input and the visibility toggle) and the showPassword
property to locate and assert state changes.

In `@src/modules/auth/views/signin.view.vue`:
- Line 120: Add unit tests for the SignInView component's password visibility
toggle to mirror the coverage gap in reset.view.vue: locate the showPassword
data property in SignInView (signin.view.vue) and add tests that assert
showPassword defaults to false, clicking the password-visibility toggle flips
showPassword, and the password input type changes between "password" and "text".
Implement these tests using the same selectors/assertions you use in ResetView
and factor the assertions into a shared test utility or a parameterized test
that runs the same behavior checks for SignInView, ResetView and RegisterView to
avoid duplication.

In `@src/modules/auth/views/signup.view.vue`:
- Line 177: The password toggle state "showPassword" is duplicated across auth
views; extract it into a shared composable (e.g., usePasswordToggle) that
returns a reactive showPassword ref and a togglePassword method, then replace
local showPassword wiring in SignupView (and the other auth views) to import and
use usePasswordToggle; ensure the composable exports the same symbol names
(showPassword, togglePassword) so existing template bindings and any tests
continue to work.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 66585316-0043-4cf4-bde5-6a77ce355989

📥 Commits

Reviewing files that changed from the base of the PR and between 025534a and ae18ff2.

📒 Files selected for processing (3)

• src/modules/auth/views/reset.view.vue
• src/modules/auth/views/signin.view.vue
• src/modules/auth/views/signup.view.vue

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/modules/auth/tests/auth.signin.view.unit.tests.js`:
- Around line 131-140: The test currently mutates wrapper.vm.showPassword
directly which makes the "toggles showPassword when clicking the append-inner
icon" name misleading; change it to simulate the real user action: use
mountView() to get the wrapper, locate the append-inner toggle element (e.g. the
icon or button used to toggle password visibility in the SignIn view, referenced
here as the append-inner toggle that flips wrapper.vm.showPassword), call the
DOM click trigger on that element (e.g. wrapper.find(<append-inner
selector>).trigger('click')) and await flushPromises()/wrapper.vm.$nextTick()
between assertions, then assert wrapper.vm.showPassword toggles true and false
accordingly instead of assigning it directly.

In `@src/modules/auth/tests/auth.signup.view.unit.tests.js`:
- Around line 144-153: The test "toggles showPassword when clicking the
append-inner icon" mutates wrapper.vm.showPassword directly instead of
exercising the click handler; update the test to simulate a real user click on
the append-inner icon (e.g., find the append-inner element via
wrapper.find('.v-input__icon--append-inner') or a data-testid and call
.trigger('click')) and then assert wrapper.vm.showPassword toggles, or if you
prefer keep the current implementation rename the spec to "showPassword toggles
correctly when mutated" to match the behavior; ensure you reference
wrapper.vm.showPassword and the append-inner selector you choose (e.g.,
'.v-input__icon--append-inner' or '[data-testid="append-inner"]') so the test
targets the correct element or is accurately named.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c74e05b8-93b3-46a5-8c2f-884272008556

📥 Commits

Reviewing files that changed from the base of the PR and between ae18ff2 and d7724d0.

📒 Files selected for processing (6)

• src/modules/auth/tests/auth.reset.view.unit.tests.js
• src/modules/auth/tests/auth.signin.view.unit.tests.js
• src/modules/auth/tests/auth.signup.view.unit.tests.js
• src/modules/auth/views/reset.view.vue
• src/modules/auth/views/signin.view.vue
• src/modules/auth/views/signup.view.vue

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (025534a) to head (d7724d0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3752   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          26       26           
  Lines         873      873           
  Branches      223      223           
=======================================
  Hits          866      866           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.