feat(ci): skip setup-node and playwright install on self-hosted runner

[PierreBrisorgueil]

Summary

• Add if: ${{ !vars.RUNNER }} to setup-node steps in both lint-unit-build and e2e jobs
• Add if: ${{ !vars.RUNNER }} to the "Install Playwright browsers" step in the e2e job
• When vars.RUNNER is set (self-hosted), these tools are pre-installed so the steps are skipped

Closes #3802

Test plan

• CI passes on GitHub-hosted runner (vars.RUNNER unset) — all steps run normally
• CI passes on self-hosted runner (vars.RUNNER set) — setup-node and playwright install are skipped

Summary by CodeRabbit

• Chores
  • Updated CI workflow to conditionally skip Node.js setup and browser installation steps based on runner configuration, optimizing workflow execution time in certain environments.

[coderabbitai]

Walkthrough

Added conditional execution guards (if: ${{ !vars.RUNNER }}) to skip setup-node steps in the lint-unit-build and e2e jobs, and to skip Playwright browser installation in the e2e job when the vars.RUNNER variable is set, enabling use of self-hosted runners with pre-installed dependencies.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration .github/workflows/CI.yml	Added conditional guards to skip actions/setup-node@v4 in lint-unit-build and e2e jobs, and skip Playwright browser installation in e2e job when self-hosted runner is in use (vars.RUNNER set).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• build(deps): bump posthog-js from 1.255.1 to 1.256.0 #3338: Accomplishes the same conditional guard pattern for skipping setup-node when using self-hosted runners with the vars.RUNNER variable.

Possibly related PRs

• perf(ci): optimize GitHub Actions #3793: Also modifies the CI workflow to adjust setup-node and Playwright browser installation handling in the context of runner configurations.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding conditional guards to skip setup-node and playwright install steps on self-hosted runners.
Description check	✅ Passed	The description includes a clear summary, reasoning for the changes, related issue closure, and a test plan covering both GitHub-hosted and self-hosted runner scenarios.
Linked Issues check	✅ Passed	The PR fully addresses all requirements from issue #3802: conditional skip of setup-node in lint-unit-build and e2e jobs, conditional skip of playwright install in e2e job, and maintains compatibility with both GitHub-hosted and self-hosted runners.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to the requirements: only conditional execution guards were added to the specified workflow steps, with no unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/ci-skip-setup-selfhosted

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.23%. Comparing base (e384c7c) to head (1c6a0bb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3803   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          28       28           
  Lines         910      910           
  Branches      243      243           
=======================================
  Hits          903      903           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Adjusts the CI workflow to avoid redundant tool installation when running on a self-hosted runner image that already includes Node and Playwright.

Changes:

• Conditionally skip actions/setup-node@v4 in lint-unit-build when vars.RUNNER is set.
• Conditionally skip actions/setup-node@v4 and npx playwright install in e2e when vars.RUNNER is set.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/CI.yml (1)

76-81: 🧹 Nitpick | 🔵 Trivial

Consider also skipping the Playwright cache step on self-hosted runners.

The Playwright install step is correctly skipped when vars.RUNNER is set, but the cache step (lines 76-81) still runs unconditionally. On self-hosted runners where Playwright is pre-installed system-wide, caching ~/.cache/ms-playwright is redundant and wastes cache storage quota.

♻️ Proposed fix to also condition the cache step

       # Cache Playwright browsers
       - name: Cache Playwright browsers
+        if: ${{ !vars.RUNNER }}
         uses: actions/cache@v4
         id: playwright-cache
         with:
           path: ~/.cache/ms-playwright
           key: playwright-${{ hashFiles('Vue/package-lock.json') }}

Also applies to: 106-109

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/CI.yml around lines 76 - 81, The "Cache Playwright
browsers" step (id: playwright-cache) runs unconditionally; add the same
conditional used to skip the Playwright install on self-hosted runners so the
cache step is skipped when vars.RUNNER is set (e.g., add the same if: expression
used in the Playwright install step such as if: ${{ !vars.RUNNER }} or the exact
expression already in your workflow) and apply the same change to the other
Playwright cache occurrence so both cache steps are gated by the vars.RUNNER
check.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/CI.yml:
- Around line 76-81: The "Cache Playwright browsers" step (id: playwright-cache)
runs unconditionally; add the same conditional used to skip the Playwright
install on self-hosted runners so the cache step is skipped when vars.RUNNER is
set (e.g., add the same if: expression used in the Playwright install step such
as if: ${{ !vars.RUNNER }} or the exact expression already in your workflow) and
apply the same change to the other Playwright cache occurrence so both cache
steps are gated by the vars.RUNNER check.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 03d2a8e4-ad74-4e2b-a38a-f793caee5fe8

📥 Commits

Reviewing files that changed from the base of the PR and between e384c7c and 1c6a0bb.

📒 Files selected for processing (1)

• .github/workflows/CI.yml