fix(ci): remove ARC-specific conditionals from CI.yml

[PierreBrisorgueil]

Summary

• Remove three if: ${{ !vars.RUNNER }} conditionals that skipped setup-node and Playwright install on ARC self-hosted runners
• These conditions are no longer needed — all steps now run unconditionally

Closes #3805

Test plan

• CI pipeline passes on GitHub Actions (lint, unit, build, e2e all green)

Summary by CodeRabbit

• Chores
  • Updated CI workflow to ensure Node setup and Playwright browser installation always execute in the e2e job, removing conditional guards for more consistent build behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: eaa09ff9-0419-4f00-a75b-e7073d53bbcc

📥 Commits

Reviewing files that changed from the base of the PR and between 104d4f8 and c417246.

📒 Files selected for processing (1)

• .github/workflows/CI.yml

💤 Files with no reviewable changes (1)

• .github/workflows/CI.yml

---

Walkthrough

Removes conditional guards from the GitHub Actions workflow file to make Node setup and Playwright browser installation execute unconditionally, regardless of the RUNNER variable state.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration .github/workflows/CI.yml	Removed if: ${{ !vars.RUNNER }} conditional guards from three locations: actions/setup-node steps in both lint-unit-build and e2e jobs, and the "Install Playwright browsers" step. These steps now execute without conditional checks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• perf(ci): optimize GitHub Actions #3793: Modifies the same CI workflow file with changes to Playwright browser installation and Node setup caching, affecting overlapping workflow steps.
• feat(ci): skip setup-node and playwright install on self-hosted runner #3803: Implements the inverse operation by adding if: ${{ !vars.RUNNER }} conditional guards to the same workflow steps.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing ARC-specific conditional guards from the CI workflow.
Description check	✅ Passed	The description covers the essential what and why, but is missing several required template sections like Scope, Validation checklist, and Guardrails check.
Linked Issues check	✅ Passed	The PR directly addresses all three requirements from issue #3805: removing conditionals from setup-node in lint-unit-build, setup-node in e2e, and Playwright installation step.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to the stated objectives; only the three conditional guards were removed with no extraneous modifications to the workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ci-simplify

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Simplifies the repository’s GitHub Actions CI workflow by removing ARC/self-hosted runner-specific conditionals so Node setup and Playwright browser installation run consistently across all runners.

Changes:

• Removed if: ${{ !vars.RUNNER }} gating from actions/setup-node in the lint/unit/build job.
• Removed if: ${{ !vars.RUNNER }} gating from actions/setup-node in the e2e job.
• Removed if: ${{ !vars.RUNNER }} gating from the “Install Playwright browsers” step.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.23%. Comparing base (104d4f8) to head (c417246).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3806   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          28       28           
  Lines         910      910           
  Branches      243      243           
=======================================
  Hits          903      903           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.