fix(e2e): read ports from project config instead of hardcoding

[PierreBrisorgueil]

Summary

• Create shared E2E config loader (src/lib/helpers/e2e/config.js) that dynamically imports the generated project config with safe fallback defaults
• Replace all hardcoded localhost:3000 and localhost:8080 in playwright.config.js, E2E helpers (api.js, auth.js), and test files (auth.signup, billing)
• Single source of truth for BASE_URL, API_URL, API_ORIGIN, and port across all E2E infrastructure

Test plan

• Lint passes on all changed files
• Unit tests pass (730/730) with coverage thresholds met
• Production build succeeds
• E2E tests pass with API backend running (API was offline during dev; skipped gracefully)

Closes #3775

Summary by CodeRabbit

• Chores
  • Centralized end-to-end testing configuration to replace hardcoded URLs and ports with configurable runtime values.
  • Test suites and test runner now derive application base URL, API origin, and server port from shared configuration.
  • Playwright/web-server startup and all E2E API calls adapt to the configured environment for more flexible local and CI runs.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 101ef3b4-17f8-4bf7-8718-7432e036fd96

📥 Commits

Reviewing files that changed from the base of the PR and between 2506a4f and ca85710.

📒 Files selected for processing (6)

• playwright.config.js
• src/lib/helpers/e2e/api.js
• src/lib/helpers/e2e/auth.js
• src/lib/helpers/e2e/config.js
• src/modules/auth/tests/auth.signup.e2e.tests.js
• src/modules/billing/tests/billing.e2e.tests.js

---

Walkthrough

Added a centralized E2E config loader and switched Playwright, helper modules, and tests to derive dev server port and API URLs from that loader instead of hardcoded localhost values.

Changes

Cohort / File(s)	Summary
New E2E configuration src/lib/helpers/e2e/config.js	Adds module that runs npm run generateConfig (errors ignored), imports src/config/index.js, derives numeric port and API fields, and exports BASE_URL, API_URL, API_ORIGIN, and port with safe defaults.
Playwright config playwright.config.js	Replaces hardcoded baseURL and webServer.port/command with imports from the new E2E config (BASE_URL, port) and uses npx vite --port ${port} to start Vite.
E2E helpers src/lib/helpers/e2e/api.js, src/lib/helpers/e2e/auth.js	Replaced hardcoded API endpoints with API_URL/API_ORIGIN imports from the centralized config; request targets now use the runtime-derived URLs.
E2E tests src/modules/auth/tests/auth.signup.e2e.tests.js, src/modules/billing/tests/billing.e2e.tests.js	Tests updated to use API_URL/API_ORIGIN from the centralized config instead of hardcoded localhost addresses.

Sequence Diagram(s)

sequenceDiagram
  participant Runner as Playwright (runner)
  participant Gen as generateConfig
  participant E2EConfig as E2E config module
  participant DevServer as Vite dev server
  participant Tests as E2E tests/helpers
  participant API as Backend API

  Runner->>Gen: run `npm run generateConfig`
  Runner->>E2EConfig: import computed config (port, BASE_URL, API_URL, API_ORIGIN)
  Runner->>DevServer: start `npx vite --port ${port}`
  DevServer-->>Runner: dev server ready at BASE_URL
  Runner->>Tests: run tests with baseURL = BASE_URL
  Tests->>API: HTTP requests to API_URL / API_ORIGIN
  API-->>Tests: responses

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(config): add missing api section to config.test.js #3679: Adds/restores api section in test config that the new E2E loader expects to read.
• refactor(config): split monolithic config into per-module files #3622: Refactors generateConfig / produced src/config/index.js, which the new E2E module dynamically imports.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: replacing hardcoded ports with config-driven values for E2E tests.
Description check	✅ Passed	The description covers key sections: summary of changes, test plan results, and linked issue. However, the 'Scope' section (modules impacted, cross-module impact, risk level) and 'Guardrails check' section are largely missing.
Linked Issues check	✅ Passed	All core objectives from issue #3775 are met: shared E2E config loader added [#3775], hardcoded localhost:3000/8080 replaced in playwright.config.js/helpers/tests [#3775], and config-driven BASE_URL/API_URL/API_ORIGIN used throughout [#3775].
Out of Scope Changes check	✅ Passed	All changes remain within scope: E2E configuration and helper files are modified to centralize port/URL configuration. No unrelated refactoring, feature additions, or cross-module changes detected.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/e2e-ports-from-config

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.22%. Comparing base (2506a4f) to head (ca85710).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3777   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          27       27           
  Lines         898      898           
  Branches      235      235           
=======================================
  Hits          891      891           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR centralizes E2E URL/port configuration by introducing a shared loader that reads from the generated project config, and updates Playwright config + E2E helpers/tests to stop hardcoding localhost:3000/localhost:8080.

Changes:

• Add src/lib/helpers/e2e/config.js to derive BASE_URL, API_URL, API_ORIGIN, and port from generated config with fallbacks.
• Update playwright.config.js to use the shared BASE_URL/port instead of hardcoded values.
• Replace hardcoded API URLs in E2E helpers and E2E tests to use the shared config exports.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/lib/helpers/e2e/config.js	New shared E2E config module that imports generated config and exports computed URLs/ports.
playwright.config.js	Switch Playwright baseURL and webServer port/command to use shared E2E config values.
src/lib/helpers/e2e/auth.js	Use shared API_URL for signup/signin API calls.
src/lib/helpers/e2e/api.js	Use shared API_URL for authenticated API context and org creation helpers.
src/modules/auth/tests/auth.signup.e2e.tests.js	Replace hardcoded signup endpoint with config-driven API URL.
src/modules/billing/tests/billing.e2e.tests.js	Replace hardcoded API origin with config-driven origin export.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@playwright.config.js`:
- Line 2: Imports of BASE_URL and port in playwright.config.js (from
src/lib/helpers/e2e/config.js) rely on a generated config that is created by the
webServer.command generateConfig step which runs too late, so ensure
generateConfig runs before Playwright resolves imports: modify the E2E workflow
to run the generateConfig script prior to starting Playwright (e.g., change the
test:e2e npm script to run the generateConfig command first), or refactor
webServer.command/generateConfig so that src/config/index.js exists before
playwright.config.js imports BASE_URL and port; reference symbols: BASE_URL,
port, generateConfig, webServer.command, src/lib/helpers/e2e/config.js, and
test:e2e.

In `@src/lib/helpers/e2e/config.js`:
- Line 16: Replace the use of the logical OR fallback for the port constant with
nullish coalescing so intentional falsy values (like 0) aren't overridden:
update the declaration using the symbol port and the source _config.port to use
?? instead of ||; if there are other defaulting lines in the same module (e.g.,
apiBase or similar), apply the same change there for consistency.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8dbcfa24-7f0e-4789-a1d5-f41d29c78b2a

📥 Commits

Reviewing files that changed from the base of the PR and between 2506a4f and b64e4f0.

📒 Files selected for processing (6)

• playwright.config.js
• src/lib/helpers/e2e/api.js
• src/lib/helpers/e2e/auth.js
• src/lib/helpers/e2e/config.js
• src/modules/auth/tests/auth.signup.e2e.tests.js
• src/modules/billing/tests/billing.e2e.tests.js

[PierreBrisorgueil]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/lib/helpers/e2e/config.js`:
- Around line 27-32: The current fallback uses `||` which turns an intentional 0
into the default; update the parsing logic for rawPort/rawApiPort to preserve 0
by first deriving a numeric value then only replacing it when it's NaN: for
rawPort use something like const parsedPort = typeof rawPort === 'number' ?
rawPort : Number.parseInt(rawPort, 10); const port = Number.isNaN(parsedPort) ?
8080 : parsedPort; and do the same for rawApiPort -> apiPort (use
Number.isNaN(parsedApiPort) ? 3000 : parsedApiPort); keep apiProtocol/apiHost
unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 95cec566-0431-4225-9d92-871b2753400c

📥 Commits

Reviewing files that changed from the base of the PR and between b64e4f0 and ff68411.

📒 Files selected for processing (3)

• playwright.config.js
• src/lib/helpers/e2e/config.js
• src/modules/billing/tests/billing.e2e.tests.js

[PierreBrisorgueil]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.