fix(web): keep timestamp tooltip dates in English - #10256
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped timestamp-tooltip fix that explicitly formats the existing English date label in English, with regression coverage for non-English runtimes. It does not alter user-configurable timestamp defaults or introduce broader runtime behavior. You can add or adjust custom eligibility rules. Learn more. |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe chat timestamp formatter now uses the ChangesTimestamp tooltip locale
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Chat timestamp tooltips now consistently use English month names while retaining existing time and numeric-date preferences. The focused locale coverage indicates the change is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
## What's Changed * fix(web): keep timestamp tooltip dates in English by @Lucenx9 in pingdotgg/t3code#10256 * fix(web): let authorized clients scrolling reach settings by @flamboh in pingdotgg/t3code#10080 * fix(web): remember usage page selection by @extoci in pingdotgg/t3code#10189 * fix(server): keep the Antigravity Google sign-in across server restarts by @t3dotgg in pingdotgg/t3code#10244 * fix(antigravity): load user skills from ~/.gemini for every project by @t3dotgg in pingdotgg/t3code#10257 * fix(web): respect reduced motion in shared disclosures by @saphid in pingdotgg/t3code#10258 * feat(marketing): add a Windows 95 landing page by @t3dotgg in pingdotgg/t3code#10286 * refactor(web): remove unused runtime wrappers and exports by @juliusmarminge in pingdotgg/t3code#10225 * refactor(web): keep feature component helpers private by @juliusmarminge in pingdotgg/t3code#10226 * refactor(web): keep app utilities private and remove dead helpers by @juliusmarminge in pingdotgg/t3code#10227 * ci: enforce unused runtime exports in the web app by @juliusmarminge in pingdotgg/t3code#10228 * test(desktop): cover Clerk setup through the service by @juliusmarminge in pingdotgg/t3code#10284 * test(desktop): cover WSL hashes through runtime resolution by @juliusmarminge in pingdotgg/t3code#10285 * test(desktop): cover password store through startup by @juliusmarminge in pingdotgg/t3code#10287 * test(desktop): cover WSL paths through public behavior by @juliusmarminge in pingdotgg/t3code#10289 * test(desktop): exercise WSL cache safety through public scripts by @juliusmarminge in pingdotgg/t3code#10301 * test(web): cover file classification through diff ordering by @juliusmarminge in pingdotgg/t3code#10304 * test(web): focus command palette tests on search behavior by @juliusmarminge in pingdotgg/t3code#10302 * fix(web): add project settings to legacy sidebar project menu by @hwanseoc in pingdotgg/t3code#10021 * test(web): keep Markdown gutter styling private by @juliusmarminge in pingdotgg/t3code#10306 * feat(settings): add shared project defaults and scoped overrides by @maria-rcks in pingdotgg/t3code#9754 * feat(connections): balance new threads across connected machines by @maria-rcks in pingdotgg/t3code#9895 * test(web): keep settings viewport comparison private by @juliusmarminge in pingdotgg/t3code#10307 * fix(web): prevent file tree search focus ring clipping by @GuilhermeVieiraDev in pingdotgg/t3code#10175 * fix(mobile): stop the work log flickering during subagent runs and failing calls by @juliusmarminge in pingdotgg/t3code#10273 * fix(mobile): save linked media from chat by @juliusmarminge in pingdotgg/t3code#10271 * feat(markdown): show the GitHub mark for github.com links by @juliusmarminge in pingdotgg/t3code#10324 * fix(marketing): show a real preview card when t3.codes is shared by @t3dotgg in pingdotgg/t3code#10305 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1292...v0.0.39-nightly.20260906.1293 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260906.1293
What Changed
Message timestamp tooltips mix an English ordinal with a localized month, for example
4th giugno 2026in an Italian browser. Pin the month formatter toen-USso it matches the rest of the date label.Why
The existing comment explicitly calls for an English tooltip date. This one-line fix implements that intent without changing clock preferences, numeric dates, or other timestamp helpers. Regression tests cover German and Italian runtime locales.
flowchart LR A[Message timestamp] --> B[Time using existing locale and clock preference] A --> C[English ordinal day and year] A --> D[Month formatted in en-US] B --> E[Chat timestamp tooltip] C --> E D --> EUI Changes
Same seeded conversation in the running web app, Chromium with
it-ITlocale andEurope/Rometimezone. Both images are cropped PNGs at 2× density. Before uses the unchanged formatter fromeee05575eb; after uses this fix. Verified both user and assistant message tooltips. No mobile or packaged desktop run.Before:
After:
Verification
vp test run src/timestampFormat.test.ts --project unit --maxWorkers 1inapps/web: 25 passed. Both new regression cases failed before the fix.TS2554in unchangedsrc/components/files/fileEditorVirtualization.test.ts:260, which passes four arguments to a method accepting at most three. No diagnostics were suppressed.eee05575eb, scoped to web with one thread: passed with no introduced findings.Checklist
Model: GPT-5. Harness: Codex in T3 Code.
Note
Force English locale for
monthNameFormatterin timestamp tooltipsSets the module-level month formatter in timestampFormat.ts to
en-USinstead of the runtime default locale. Adds tests in timestampFormat.test.ts that mock German and Italian runtime locales and confirm the tooltip output stays in English.Macroscope summarized 1ff911d.
Summary by CodeRabbit