test(web): cover file classification through diff ordering - #10304
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained test consolidation and export-surface cleanup. It leaves file classification and ordering behavior unchanged, with no product-default, deployment, schema, or sensitive-area impact. You can add or adjust custom eligibility rules. Learn more. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 6, 2026
## What's Changed * fix(web): keep timestamp tooltip dates in English by @Lucenx9 in pingdotgg/t3code#10256 * fix(web): let authorized clients scrolling reach settings by @flamboh in pingdotgg/t3code#10080 * fix(web): remember usage page selection by @extoci in pingdotgg/t3code#10189 * fix(server): keep the Antigravity Google sign-in across server restarts by @t3dotgg in pingdotgg/t3code#10244 * fix(antigravity): load user skills from ~/.gemini for every project by @t3dotgg in pingdotgg/t3code#10257 * fix(web): respect reduced motion in shared disclosures by @saphid in pingdotgg/t3code#10258 * feat(marketing): add a Windows 95 landing page by @t3dotgg in pingdotgg/t3code#10286 * refactor(web): remove unused runtime wrappers and exports by @juliusmarminge in pingdotgg/t3code#10225 * refactor(web): keep feature component helpers private by @juliusmarminge in pingdotgg/t3code#10226 * refactor(web): keep app utilities private and remove dead helpers by @juliusmarminge in pingdotgg/t3code#10227 * ci: enforce unused runtime exports in the web app by @juliusmarminge in pingdotgg/t3code#10228 * test(desktop): cover Clerk setup through the service by @juliusmarminge in pingdotgg/t3code#10284 * test(desktop): cover WSL hashes through runtime resolution by @juliusmarminge in pingdotgg/t3code#10285 * test(desktop): cover password store through startup by @juliusmarminge in pingdotgg/t3code#10287 * test(desktop): cover WSL paths through public behavior by @juliusmarminge in pingdotgg/t3code#10289 * test(desktop): exercise WSL cache safety through public scripts by @juliusmarminge in pingdotgg/t3code#10301 * test(web): cover file classification through diff ordering by @juliusmarminge in pingdotgg/t3code#10304 * test(web): focus command palette tests on search behavior by @juliusmarminge in pingdotgg/t3code#10302 * fix(web): add project settings to legacy sidebar project menu by @hwanseoc in pingdotgg/t3code#10021 * test(web): keep Markdown gutter styling private by @juliusmarminge in pingdotgg/t3code#10306 * feat(settings): add shared project defaults and scoped overrides by @maria-rcks in pingdotgg/t3code#9754 * feat(connections): balance new threads across connected machines by @maria-rcks in pingdotgg/t3code#9895 * test(web): keep settings viewport comparison private by @juliusmarminge in pingdotgg/t3code#10307 * fix(web): prevent file tree search focus ring clipping by @GuilhermeVieiraDev in pingdotgg/t3code#10175 * fix(mobile): stop the work log flickering during subagent runs and failing calls by @juliusmarminge in pingdotgg/t3code#10273 * fix(mobile): save linked media from chat by @juliusmarminge in pingdotgg/t3code#10271 * feat(markdown): show the GitHub mark for github.com links by @juliusmarminge in pingdotgg/t3code#10324 * fix(marketing): show a real preview card when t3.codes is shared by @t3dotgg in pingdotgg/t3code#10305 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1292...v0.0.39-nightly.20260906.1293 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260906.1293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff file classifier was exported only so tests could assert its intermediate tier labels. Make it private and consolidate those tests into a check of the public file ordering result.
The ordering test retains all 16 source, test, lockfile, snapshot, and generated-path examples. Existing dependency-ordering and cycle coverage remains.
Verification: all 15 diff ordering tests pass; web typecheck and changed-file lint/format pass.
Model: gpt-6 astra. Harness: Codex in T3 Code.
Note
Cover file classification via
orderDiffFilestests and makediffFileTierprivateTests now verify file classification by checking
orderDiffFilesoutput instead of testingdiffFileTierdirectly.diffFileTieris made module-private in pullRequestFileOrder.logic.ts. Existing tests are grouped under theorderDiffFilesdescribe block.Macroscope summarized 7ab7521.