fix(web): bypass xterm for global terminal shortcuts

[AriajSarkar]

What Changed

• Plumbed the keybindings state down from ChatView.tsx into ThreadTerminalDrawer.tsx.
• Updated attachCustomKeyEventHandler on the xterm.js instance to explicitly pass the shortcut context: { terminalFocus: true, terminalOpen: true }.
• Returned false on global shortcut matches (terminal.toggle, terminal.new, terminal.split, terminal.close, diff.toggle) to bypass xterm input capture.

Why

When the terminal was focused, xterm.js eagerly captured shortcut combinations (e.g., intercepting Ctrl+J as an 0x0A Line Feed, or Ctrl+N as ^N).
This prevented the global application shortcut listeners in ChatView.tsx from ever receiving these specific keystrokes. By explicitly whitelisting these application-level combinations in the custom event handler and providing the correct when context, xterm safely ignores them and allows the keydown event to bubble up properly.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Note

Medium Risk
Changes low-level keyboard event interception in the terminal; regressions could block either terminal input or global shortcut handling depending on platform/keybinding context.

Overview
Ensures global app shortcuts still work while the xterm terminal has focus by explicitly bypassing xterm key handling for terminal.toggle/terminal.split/terminal.new/terminal.close and diff.toggle.

This threads the resolved keybindings config from ChatView down through PersistentThreadTerminalDrawer/ThreadTerminalDrawer into TerminalViewport, and updates TerminalViewport’s attachCustomKeyEventHandler to match those shortcuts with { terminalFocus: true, terminalOpen: true } context and return false so the events bubble to the app-level listener. Browser tests are updated to pass the new keybindings prop.

^{Reviewed by Cursor Bugbot for commit 973a7fd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bypass xterm key handling for global terminal shortcuts in TerminalViewport

Adds a keybindings prop (typed as ResolvedKeybindingsConfig) to TerminalViewport, ThreadTerminalDrawer, and PersistentThreadTerminalDrawer, threading the config down from ChatView.

TerminalViewport uses attachCustomKeyEventHandler to intercept key events and return false for any event matching terminal toggle, split, new, close, or diff toggle shortcuts (with terminalFocus: true, terminalOpen: true context), so xterm never consumes those keystrokes.

^{Macroscope summarized 973a7fd.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 90f4b065-951a-4173-aef7-dac04662c111

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a straightforward bug fix that threads keybindings config to the terminal component and adds a check in xterm's key event handler to let global shortcuts (terminal toggle, split, new, close, diff toggle) bubble up instead of being swallowed. The change is small, uses existing helper functions, and has clear intent.

^{You can customize Macroscope's approvability policy. Learn more.}