Show thread status in command palette#2107
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Reuse sidebar thread status indicators in palette rows - Display PR, terminal, and remote environment badges
3bf2898 to
5b7ad8f
Compare
- Remove compact rendering from the thread status pill
ApprovabilityVerdict: Approved This PR extracts existing thread status indicator components from the sidebar into a shared file and reuses them to display thread status in the command palette. The changes are purely presentational - moving existing code to enable reuse in a new UI context without changing any business logic. You can customize Macroscope's approvability policy. Learn more. |
Integrates upstream/main (9df3c64) on top of fork's main (9602c18). Upstream features adopted: - Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143) - Node-native TypeScript migration across desktop/server (pingdotgg#2098) - Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099) - Thread status in command palette (pingdotgg#2107) - Responsive composer / plan sidebar on narrow windows (pingdotgg#1198) - Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142) - Bypass xterm for global terminal shortcuts (pingdotgg#1580) - Windows ARM build target (pingdotgg#2080) - Windows PATH hydration + repair (pingdotgg#1729) - Gitignore-aware workspace search (pingdotgg#2078) - Claude process leak fix + stale session monitoring (pingdotgg#2042) - Preserve provider bindings when stopping sessions (pingdotgg#2084) - Clean up invalid pending-approval projections (pingdotgg#2106) — new migration - Extract backend startup readiness coordination - Drop stale text-gen options on reset (pingdotgg#2076) - Extend negative repository identity cache TTL (pingdotgg#2083) - Allow deleting non-empty projects from warning toast (pingdotgg#1264) - Restore defaults only on General settings (pingdotgg#1710) - Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump) Fork features preserved: - All 8 providers (codex, claudeAgent, copilot, cursor, opencode, geminiCli, amp, kilo) with their adapters, services, and tests - Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's version is tested and integrated; upstream's parallel files deleted) - Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted) - Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots; the other 6 providers register via ProviderAdapterRegistry - PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the registry actually caches - Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at ID 27 to avoid re-applying on deployed fork DBs) - Fork's generic per-provider settings (enabled/binaryPath/configDir/ customModels) kept over upstream's opencode-specific serverUrl/password - Log directory IPC channels, updateInstallInFlight tracking, icon composer pipeline all preserved - Fork's simplified release.yml (no npm CLI publish, no nightly infra) - composerDraftStore normalizeProviderKind widened to accept all 8 kinds - Dark mode --background set to #0f0f0f Test status: - All 9 package typechecks pass - Lint clean (0 errors) - Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager cross-repo PR selector tests newly gated with TODO for Node-native-TS follow-up)
What Changed
Sidebar.tsxinto a newThreadStatusIndicators.tsxmodule (ThreadStatusLabel,prStatusIndicator,resolveThreadPr,terminalStatusFromRunningIds), and added two thin components that wrap the per-row hooks so the same indicators can be rendered outside the sidebar without duplicating logic:ThreadRowLeadingStatus— PR icon + status pillThreadRowTrailingStatus— terminal icon + remote cloud iconCommandPaletteItemwith optionaltitleLeadingContentandtitleTrailingContentReactNodefields.buildThreadActionItemsnow acceptsrenderLeadingContent/renderTrailingContentcallbacks that populate them per-thread, and is generic over the thread shape so callers that pass a richer type (e.g.SidebarThreadSummary) keep their fields.CommandPaletteResultRowrenders the leading/trailing content inline around the title text while preserving truncation in both the title-only and title+description layouts.CommandPalette.tsxwiresThreadRowLeadingStatus/ThreadRowTrailingStatusinto the thread item builder.Why
Thread rows in the command palette previously showed only a title, a
project · #branchdescription, and a relative timestamp. You could not tell from a palette result whether a thread was still working, waiting on approval, had a PR merged, had a live terminal, or lived on a remote environment — even though the sidebar surfaces all of that. Mirroring the sidebar's indicators gives consistent signal between the two main thread navigation surfaces, at the cost of a small shared module that both entry points now reuse.UI Changes
Each thread row in the command palette now renders, from left to right:
[type icon] [PR icon?] [status dot?] [title] [terminal icon?] [cloud icon?] [timestamp]All new indicators are hidden when they don't apply, so threads with no running work, no PR, no terminal, and on the primary environment look the same as before.
Checklist
Note
Show thread status indicators (PR, terminal, environment) in the command palette
ThreadRowLeadingStatusandThreadRowTrailingStatuscomponents inThreadStatusIndicators.tsxthat render PR status, thread status pill, terminal-running pulse, and remote environment icon for a thread row.CommandPaletteItemwith optionaltitleLeadingContentandtitleTrailingContentfields, and updatesbuildThreadActionItemsto accept callbacks that populate these fields.CommandPaletteResultRowrenders leading/trailing content inline around the item title.prStatusIndicator,resolveThreadPr,terminalStatusFromRunningIds) fromSidebar.tsxinto the new shared module.Macroscope summarized eb38acf.
Note
Medium Risk
Adds additional per-thread status hooks (git status/terminal/environment) to command palette rendering and refactors sidebar status logic into a shared module, which could impact performance or introduce subtle UI/layout regressions.
Overview
Command palette thread results now render the same status indicators as the sidebar (PR state, thread status dot, terminal-running, and remote-environment icon) inline around the thread title.
To enable this,
CommandPaletteItem/buildThreadActionItemswere extended to support optional leading/trailing title content, and the sidebar’s PR/terminal/status indicator utilities were extracted into a new sharedThreadStatusIndicators.tsxmodule that also provides compactThreadRowLeadingStatus/ThreadRowTrailingStatuscomponents.CommandPaletteResultswas updated to lay out these new inline elements while preserving truncation.Reviewed by Cursor Bugbot for commit eb38acf. Bugbot is set up for automated code reviews on this repo. Configure here.