Skip to content

Show thread status in command palette#2107

Merged
juliusmarminge merged 2 commits intopingdotgg:mainfrom
Noojuno:feature/command-palette-thread-status
Apr 17, 2026
Merged

Show thread status in command palette#2107
juliusmarminge merged 2 commits intopingdotgg:mainfrom
Noojuno:feature/command-palette-thread-status

Conversation

@Noojuno
Copy link
Copy Markdown
Contributor

@Noojuno Noojuno commented Apr 17, 2026

What Changed

  • Thread rows in the command palette now display the same status indicators as the sidebar:
    • PR state icon (open / closed / merged) when the thread's branch has an associated PR
    • Thread status pill (Working, Connecting, Pending Approval, Awaiting Input, Plan Ready, Completed)
    • Terminal-running icon when a terminal in that thread has a live subprocess
    • Cloud icon when the thread belongs to a remote environment
  • Extracted the shared status UI out of Sidebar.tsx into a new ThreadStatusIndicators.tsx module (ThreadStatusLabel, prStatusIndicator, resolveThreadPr, terminalStatusFromRunningIds), and added two thin components that wrap the per-row hooks so the same indicators can be rendered outside the sidebar without duplicating logic:
    • ThreadRowLeadingStatus — PR icon + status pill
    • ThreadRowTrailingStatus — terminal icon + remote cloud icon
  • Extended CommandPaletteItem with optional titleLeadingContent and titleTrailingContent ReactNode fields. buildThreadActionItems now accepts renderLeadingContent / renderTrailingContent callbacks that populate them per-thread, and is generic over the thread shape so callers that pass a richer type (e.g. SidebarThreadSummary) keep their fields.
  • CommandPaletteResultRow renders the leading/trailing content inline around the title text while preserving truncation in both the title-only and title+description layouts.
  • CommandPalette.tsx wires ThreadRowLeadingStatus / ThreadRowTrailingStatus into the thread item builder.

Why

Thread rows in the command palette previously showed only a title, a project · #branch description, and a relative timestamp. You could not tell from a palette result whether a thread was still working, waiting on approval, had a PR merged, had a live terminal, or lived on a remote environment — even though the sidebar surfaces all of that. Mirroring the sidebar's indicators gives consistent signal between the two main thread navigation surfaces, at the cost of a small shared module that both entry points now reuse.

UI Changes

Each thread row in the command palette now renders, from left to right:

[type icon] [PR icon?] [status dot?] [title] [terminal icon?] [cloud icon?] [timestamp]

All new indicators are hidden when they don't apply, so threads with no running work, no PR, no terminal, and on the primary environment look the same as before.

image image image image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Show thread status indicators (PR, terminal, environment) in the command palette

  • Adds ThreadRowLeadingStatus and ThreadRowTrailingStatus components in ThreadStatusIndicators.tsx that render PR status, thread status pill, terminal-running pulse, and remote environment icon for a thread row.
  • Extends CommandPaletteItem with optional titleLeadingContent and titleTrailingContent fields, and updates buildThreadActionItems to accept callbacks that populate these fields.
  • CommandPaletteResultRow renders leading/trailing content inline around the item title.
  • Extracts shared status utilities (prStatusIndicator, resolveThreadPr, terminalStatusFromRunningIds) from Sidebar.tsx into the new shared module.

Macroscope summarized eb38acf.


Note

Medium Risk
Adds additional per-thread status hooks (git status/terminal/environment) to command palette rendering and refactors sidebar status logic into a shared module, which could impact performance or introduce subtle UI/layout regressions.

Overview
Command palette thread results now render the same status indicators as the sidebar (PR state, thread status dot, terminal-running, and remote-environment icon) inline around the thread title.

To enable this, CommandPaletteItem/buildThreadActionItems were extended to support optional leading/trailing title content, and the sidebar’s PR/terminal/status indicator utilities were extracted into a new shared ThreadStatusIndicators.tsx module that also provides compact ThreadRowLeadingStatus/ThreadRowTrailingStatus components. CommandPaletteResults was updated to lay out these new inline elements while preserving truncation.

Reviewed by Cursor Bugbot for commit eb38acf. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e0b2c24a-8d29-4ab3-8e2b-fa0ac6fe2e2c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 17, 2026
- Reuse sidebar thread status indicators in palette rows
- Display PR, terminal, and remote environment badges
@Noojuno Noojuno force-pushed the feature/command-palette-thread-status branch from 3bf2898 to 5b7ad8f Compare April 17, 2026 04:24
@Noojuno Noojuno marked this pull request as ready for review April 17, 2026 04:27
- Remove compact rendering from the thread status pill
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 17, 2026

Approvability

Verdict: Approved

This PR extracts existing thread status indicator components from the sidebar into a shared file and reuses them to display thread status in the command palette. The changes are purely presentational - moving existing code to enable reuse in a new UI context without changing any business logic.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit d8d3296 into pingdotgg:main Apr 17, 2026
12 checks passed
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18).

Upstream features adopted:
- Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143)
- Node-native TypeScript migration across desktop/server (pingdotgg#2098)
- Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099)
- Thread status in command palette (pingdotgg#2107)
- Responsive composer / plan sidebar on narrow windows (pingdotgg#1198)
- Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142)
- Bypass xterm for global terminal shortcuts (pingdotgg#1580)
- Windows ARM build target (pingdotgg#2080)
- Windows PATH hydration + repair (pingdotgg#1729)
- Gitignore-aware workspace search (pingdotgg#2078)
- Claude process leak fix + stale session monitoring (pingdotgg#2042)
- Preserve provider bindings when stopping sessions (pingdotgg#2084)
- Clean up invalid pending-approval projections (pingdotgg#2106) — new migration
- Extract backend startup readiness coordination
- Drop stale text-gen options on reset (pingdotgg#2076)
- Extend negative repository identity cache TTL (pingdotgg#2083)
- Allow deleting non-empty projects from warning toast (pingdotgg#1264)
- Restore defaults only on General settings (pingdotgg#1710)
- Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump)

Fork features preserved:
- All 8 providers (codex, claudeAgent, copilot, cursor, opencode,
  geminiCli, amp, kilo) with their adapters, services, and tests
- Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept
  over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's
  version is tested and integrated; upstream's parallel files deleted)
- Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based
  CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted)
- Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots;
  the other 6 providers register via ProviderAdapterRegistry
- PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the
  registry actually caches
- Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at
  ID 27 to avoid re-applying on deployed fork DBs)
- Fork's generic per-provider settings (enabled/binaryPath/configDir/
  customModels) kept over upstream's opencode-specific serverUrl/password
- Log directory IPC channels, updateInstallInFlight tracking, icon
  composer pipeline all preserved
- Fork's simplified release.yml (no npm CLI publish, no nightly infra)
- composerDraftStore normalizeProviderKind widened to accept all 8 kinds
- Dark mode --background set to #0f0f0f

Test status:
- All 9 package typechecks pass
- Lint clean (0 errors)
- Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager
  cross-repo PR selector tests newly gated with TODO for Node-native-TS
  follow-up)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants