fix(web): use capture-phase keydown listener so CTRL+J toggles terminal from terminal focus on Windows (#2113)

[mvanhorn]

What Changed

The window keydown listener in ChatView.tsx now runs in the capture phase instead of the default bubble phase.

Why

On Windows, CTRL+J opens the terminal but pressing it again while the terminal has focus does not close it. Clicking back into chat and pressing CTRL+J closes it fine. macOS CMD+J is unaffected.

PR #1580 added terminal.attachCustomKeyEventHandler inside ThreadTerminalDrawer.tsx that returns false for terminal shortcuts, with the intent of letting the event bubble up to the global keydown listener in ChatView.tsx. On Windows, xterm.js still processes the event before it reaches the bubble-phase listener (ctrlKey combinations that map to control characters like LF get consumed), so the toggle never fires.

Flipping the listener to capture phase makes it fire before xterm.js has a chance to touch the event. The handler already calls event.preventDefault() and event.stopPropagation() when a terminal command matches, so xterm never sees those events at all. macOS stays unaffected because CMD+J was already working via the same code path.

Added a regression test for isTerminalToggleShortcut with terminalFocus: true on Win32.

UI Changes

No visual change. Keyboard behavior only: CTRL+J now consistently toggles the terminal regardless of which pane has focus on Windows.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes (N/A, no visual change)
• I included a video for animation/interaction changes (N/A, requires Windows to reproduce)

Fixes #2113

---

Note

Medium Risk
Changes global keydown handling to run in the capture phase, which can subtly affect shortcut/event propagation ordering across the app, though the change is localized and guarded by command matching.

Overview
Ensures the terminal toggle shortcut works consistently on Windows even when focus is inside the terminal by registering the ChatView global window keydown listener in the capture phase (and removing it with matching options).

Adds a regression test confirming Ctrl+J still matches terminal.toggle on non-macOS when terminalFocus: true.

^{Reviewed by Cursor Bugbot for commit 5ffb946. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix CTRL+J terminal toggle from terminal focus on Windows by using capture-phase keydown listener

The global keydown listener in ChatView.tsx is now registered with { capture: true } so it intercepts events before they reach the focused terminal element, which was previously consuming the event during the bubble phase. A test is added to confirm isTerminalToggleShortcut matches Ctrl+J when context.terminalFocus is true on non-macOS.

^{Macroscope summarized 5ffb946.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2c22266a-0473-4ccf-9ce3-d6f601297e28

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a straightforward bug fix that changes a keydown event listener to use capture phase, ensuring the CTRL+J terminal toggle shortcut works when the terminal itself has focus on Windows. The change is minimal (adding a boolean parameter) with a corresponding test case.

^{You can customize Macroscope's approvability policy. Learn more.}