Clean up invalid pending approval projections

[juliusmarminge]

Summary

• Adds migration 025_CleanupInvalidProjectionPendingApprovals to delete projection_pending_approvals rows that are not backed by an approval.requested activity.
• Recomputes projection_threads.pending_approval_count from the remaining pending approvals so thread state stays consistent after cleanup.
• Adds a migration test covering valid approval-backed rows, invalid orphaned rows, and count recalculation.

Testing

• Added apps/server/src/persistence/Migrations/025_CleanupInvalidProjectionPendingApprovals.test.ts to verify cleanup and count reconciliation.
• Not run: bun fmt
• Not run: bun lint
• Not run: bun typecheck
• Not run: bun run test

---

Note

Medium Risk
Data-cleanup migration deletes rows from projection_pending_approvals based on activity history and recomputes projection_threads.pending_approval_count, which could impact thread state if the matching criteria is wrong or activity payloads vary.

Overview
Adds migration 025_CleanupInvalidProjectionPendingApprovals to delete orphaned projection_pending_approvals rows that are not backed by an approval.requested entry in projection_thread_activities (matching via payload_json.requestId).

After cleanup, it recalculates projection_threads.pending_approval_count from remaining pending approvals to keep thread aggregates consistent, and includes a new sqlite-backed migration test verifying both deletion behavior and count reconciliation.

^{Reviewed by Cursor Bugbot for commit 532ab0c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add migration to remove invalid pending approvals and recalculate thread counts

• Adds migration 025 that deletes rows from projection_pending_approvals where no matching approval.requested activity exists in projection_thread_activities.
• Recalculates pending_approval_count on projection_threads based on remaining pending approvals after the cleanup.
• Behavioral Change: existing orphaned pending approval rows are permanently deleted when this migration runs.

^{Macroscope summarized 532ab0c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8245debd-6ccc-430c-b96f-eb54e849bc87

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/1dc35fb3

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

A data cleanup migration that removes orphaned pending approval records and recalculates counts. The migration is well-scoped, has comprehensive test coverage, and the author is the primary maintainer of the migrations system.

^{You can customize Macroscope's approvability policy. Learn more.}