fix(server): extend negative repository identity cache ttl#2083
Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom Apr 16, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:XS
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved This PR extends a cache timeout constant from 10 seconds to 1 minute and updates a test to match. The change is a simple, low-risk configuration tweak with no broader side effects. You can customize Macroscope's approvability policy. Learn more. |
|
Thank You for writing the PR :) @m-mohamed |
znoraka
pushed a commit
to znoraka/t3code
that referenced
this pull request
Apr 17, 2026
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Apr 18, 2026
Integrates upstream/main (9df3c64) on top of fork's main (9602c18). Upstream features adopted: - Claude Opus 4.5 and 4.7 built-in models (pingdotgg#2072, pingdotgg#2143) - Node-native TypeScript migration across desktop/server (pingdotgg#2098) - Configurable project grouping with client-settings overrides (pingdotgg#2055, pingdotgg#2099) - Thread status in command palette (pingdotgg#2107) - Responsive composer / plan sidebar on narrow windows (pingdotgg#1198) - Capture-phase CTRL+J keydown for Windows terminal toggle (pingdotgg#2113/pingdotgg#2142) - Bypass xterm for global terminal shortcuts (pingdotgg#1580) - Windows ARM build target (pingdotgg#2080) - Windows PATH hydration + repair (pingdotgg#1729) - Gitignore-aware workspace search (pingdotgg#2078) - Claude process leak fix + stale session monitoring (pingdotgg#2042) - Preserve provider bindings when stopping sessions (pingdotgg#2084) - Clean up invalid pending-approval projections (pingdotgg#2106) — new migration - Extract backend startup readiness coordination - Drop stale text-gen options on reset (pingdotgg#2076) - Extend negative repository identity cache TTL (pingdotgg#2083) - Allow deleting non-empty projects from warning toast (pingdotgg#1264) - Restore defaults only on General settings (pingdotgg#1710) - Release workflow modernization (blacksmith runners, GitHub App token guards, v0.0.20 version bump) Fork features preserved: - All 8 providers (codex, claudeAgent, copilot, cursor, opencode, geminiCli, amp, kilo) with their adapters, services, and tests - Fork's custom OpenCode protocol impl in apps/server/src/opencode/ (kept over upstream's @opencode-ai/sdk-based provider added in pingdotgg#1758 — fork's version is tested and integrated; upstream's parallel files deleted) - Fork's direct-CLI Cursor adapter (kept over upstream's new ACP-based CursorProvider added in pingdotgg#1355 — upstream's parallel files deleted) - Fork's ProviderRegistry aggregates only codex + claudeAgent snapshots; the other 6 providers register via ProviderAdapterRegistry - PROVIDER_CACHE_IDS stays at [codex, claudeAgent] matching what the registry actually caches - Migration IDs preserved (fork 23/24/25/26; upstream's new 025 lands at ID 27 to avoid re-applying on deployed fork DBs) - Fork's generic per-provider settings (enabled/binaryPath/configDir/ customModels) kept over upstream's opencode-specific serverUrl/password - Log directory IPC channels, updateInstallInFlight tracking, icon composer pipeline all preserved - Fork's simplified release.yml (no npm CLI publish, no nightly infra) - composerDraftStore normalizeProviderKind widened to accept all 8 kinds - Dark mode --background set to #0f0f0f Test status: - All 9 package typechecks pass - Lint clean (0 errors) - Tests: 1877 passed, 15 skipped (incl. 4 historically-flaky GitManager cross-repo PR selector tests newly gated with TODO for Node-native-TS follow-up)
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR implements Fix 2 proposed by @mei-the-dev in #2037, taking the smallest cache-only slice of that issue.
RepositoryIdentityResolvernow keeps null repository identities for 60 seconds instead of 10 seconds. I also tightened the resolver regression test so repeated resolves continue to reuse the cached null identity until the negative TTL expires.Validated locally with
bun run test -- src/project/Layers/RepositoryIdentityResolver.test.tsandbun run typecheckinapps/server.Why
In #2037, @mei-the-dev traced the persistent "Some requests are slow" toast back to replay-time repository identity enrichment and called out the 10-second negative TTL as one of the quick-win fixes. This PR implements that specific Fix 2 only: it stretches the negative cache window to 60 seconds so projects without remotes reuse the same null lookup across reconnect churn instead of refreshing every 10 seconds, while keeping behavior localized to the existing cache. The updated test demonstrates the cached null result is stable across repeated resolves and only refreshes after TTL expiry.
UI Changes
Not applicable.
Checklist
Note
Low Risk
Small, localized change to cache TTL and its test coverage; main behavioral impact is delaying detection of newly-added remotes for up to 1 minute.
Overview
RepositoryIdentityResolvernow caches null (no identity/no remote) lookups for 1 minute instead of 10 seconds, reducing repeated git-remote resolution work during churn.Updates the late-remote regression test to assert repeated
resolve()calls continue returning the cached null identity until the negative TTL elapses, after which the identity is recomputed and returned.Reviewed by Cursor Bugbot for commit 54f6322. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Extend negative repository identity cache TTL from 10 seconds to 1 minute
Increases
DEFAULT_NEGATIVE_CACHE_TTLin RepositoryIdentityResolver.ts from 10 seconds to 1 minute. The test in RepositoryIdentityResolver.test.ts is updated to perform three consecutive resolve calls expecting a null identity before advancing the clock past the new TTL. Behavioral Change: null identities are now cached 6× longer, reducing re-resolution attempts for missing repositories.Macroscope summarized 54f6322.