Skip to content

chore: fixes loop#4740

Draft
NathanFlurry wants to merge 1 commit intographite-base/4740from
04-24-chore_fixes_loop
Draft

chore: fixes loop#4740
NathanFlurry wants to merge 1 commit intographite-base/4740from
04-24-chore_fixes_loop

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Apr 24, 2026
11 tasks
@claude
Copy link
Copy Markdown

claude Bot commented Apr 24, 2026

PR Review

Overview

This PR adds @rivetkit/sql-loader as a dependency to examples/kitchen-sink and adds a trailing newline to scripts/ralph/prd.json. The kitchen-sink dev and start scripts already reference --import @rivetkit/sql-loader, so this adds the missing dependency declaration.


Issues

Missing root resolutions entry (critical)

examples/kitchen-sink/package.json correctly uses "@rivetkit/sql-loader": "*" (per CLAUDE.md convention for examples), but the root package.json is missing the corresponding workspace resolution. As a result, pnpm resolves to the published npm version 2.2.1 instead of the local workspace version (2.3.0-rc.4) -- meaning the example runs against a stale published package, not the in-repo source.

CLAUDE.md says: Add new internal @rivetkit/* packages to root resolutions with workspace:* if missing.

Compare with @rivetkit/rivetkit-napi in the same lockfile -- its root resolution maps it to link:../../rivetkit-typescript/packages/rivetkit-napi. The @rivetkit/sql-loader entry has no root resolution and falls through to npm.

Suggested fix: Add to root package.json resolutions:

"@rivetkit/sql-loader": "workspace:*"

Then re-run pnpm install. The lockfile entry should change from version: 2.2.1 to version: link:../../rivetkit-typescript/packages/sql-loader.


Minor

  • scripts/ralph/prd.json change is a trailing newline only. Harmless but unrelated.
  • PR description is blank and checklist unchecked. Fine for a draft, but worth filling in before marking ready.
  • PR title is vague. Something like chore(kitchen-sink): add sql-loader dependency would be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant