Support roslaunch parameters in static_transform_publisher

[orzechow]

eg. to enable using already loaded parameters as arguments:

<node pkg="tf" type="static_transform_publisher" name="static_tf_broadcaster1" respawn="true" >
  <remap from="~/x" to="/foo/bar"/>
  <param name="y" type="double" value="0.0" />
  <param name="z" type="double" value="0.0" />
  <param name="frame_id" type="string" value="link1_parent" />
  <param name="child_frame_id" type="string" value="link1" />
  <param name="period" type="double" value="100" />
  <param name="yaw" type="double" value="0.0" />
  <param name="pitch" type="double" value="0.0" />
  <param name="roll" type="double" value="0.0" />
</node>

[tfoote]

Thanks this looks good overall. If we're revisiting this command I'd like to make the same changes to https://github.com/ros/geometry_experimental/blob/jade-devel/tf2_ros/src/static_transform_broadcaster_program.cpp and possibly reuse the functionality from that program here as that approach is much lower bandwidth.

[orzechow]

Sure! I didn't know which package to choose, so decided for tf.
But this change fits to both obviously.

Am 06.11.2015 um 00:11 schrieb Tully Foote notifications@github.com:

Thanks this looks good overall. If we're revisiting this command I'd like to make the same changes to https://github.com/ros/geometry_experimental/blob/jade-devel/tf2_ros/src/static_transform_broadcaster_program.cpp and possibly reuse the functionality from that program here as that approach is much lower bandwidth.

—
Reply to this email directly or view it on GitHub.

[tfoote]

@ros-pull-request-builder retest this please

[tfoote]

@ros-pull-request-builder retest this please

[sloretz]

Thank you for the PR!

Unfortunately I don't think we should merge this one.

ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. I'm closing pull requests that add features so that the remaining time is allocated towards bug fixes and compatibility with newer Ubuntu distros.

[orzechow]

Yeah, merging after 10 years wouldn't really make a difference any more 😅