Skip to content

Update showimage.cpp removing extra std::cerr outputs (backport #785)#787

Merged
ahcorde merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-785
May 5, 2026
Merged

Update showimage.cpp removing extra std::cerr outputs (backport #785)#787
ahcorde merged 1 commit intojazzyfrom
mergify/bp/jazzy/pr-785

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented May 4, 2026

Description

Right now when running this you get the following:

/# ros2 run image_tools showimage 
[INFO] [1777605547.094321809] [showimage]: Subscribing to topic 'image'
[INFO] [1777605547.203184824] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.533933569] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.538867302] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.543719581] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.548553095] [showimage]: Received image #camera_frame
Received image #camera_frame
[INFO] [1777605547.553280199] [showimage]: Received image #camera_frame
Received image #camera_frame

The std::cerr message is redundant and doesn't actually display any additional helpful information. I propose we remove it since it doesn't seem to serve a purpose.

Is this user-facing behavior change?

This just changes the terminal output when running showImage.

Did you use Generative AI?

No.


This is an automatic backport of pull request #785 done by [Mergify](https://mergify.com).

Signed-off-by: jmackay2 <1.732mackay@gmail.com>
(cherry picked from commit 362e5bb)
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 4, 2026

Pulls: #787
Gist: https://gist.githubusercontent.com/ahcorde/0535906ad4b8a72c11c71a22bd726c7d/raw/3d1f110db9c76bf95a012c43346b9710b4c2d703/ros2.repos
BUILD args: --packages-above-and-dependencies image_tools
TEST args: --packages-above image_tools
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19113

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 0853025 into jazzy May 5, 2026
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-785 branch May 5, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants