Skip to content

Fix Pytest 8/9 compatibility in launch_testing_ros hooks (backport #540)#541

Open
mergify[bot] wants to merge 2 commits intolyricalfrom
mergify/bp/lyrical/pr-540
Open

Fix Pytest 8/9 compatibility in launch_testing_ros hooks (backport #540)#541
mergify[bot] wants to merge 2 commits intolyricalfrom
mergify/bp/lyrical/pr-540

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented May 5, 2026

This PR fixes deprecated hook signatures in launch_testing_ros that cause failures in newer pytest versions (e.g. Pytest 9.0).

Related: ros2/launch#972

This is an automatic backport of pull request #540 done by Mergify.

@mjcarroll @mergify
Fix Pytest 8/9 compatibility in launch_testing_ros hooks (#540)
0ca4944 
Rename deprecated path argument to module_path to avoid warnings and failures in newer pytest versions.

Assisted-by: Gemini CLI:2.0-Flash [run_shell_command, replace, git, gh]

Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
(cherry picked from commit 5ba9fa4)
@mergify mergify Bot mentioned this pull request May 5, 2026
Merged
@clalancette clalancette mentioned this pull request May 5, 2026
Merged
@mergify mergify Bot mentioned this pull request May 6, 2026
Closed
@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented May 6, 2026

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Note that I expect this to fail on Windows (it wasn't tested there before). That will eventually be fixed by #544

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 6, 2026

Pulls: ros2/launch#973, #541
Gist: https://gist.githubusercontent.com/ahcorde/4d3ffee57c7342ceb8b6d6f9b3298cb2/raw/d8bb2a360c2644f720e9d36a1e6d847a6a7715a3/ros2.repos
BUILD args: --packages-above-and-dependencies launch_testing_ros launch launch_pytest launch_testing
TEST args: --packages-above launch_testing_ros launch launch_pytest launch_testing
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19164

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request May 6, 2026
Open
@clalancette
Fix launch_testing_ros so it works with pytest 7. (#543)
3349347 
We need this compatibility because Windows pixi is
still using an older pytest.  This doesn't really
hurt anything either.

While we are in here, fix a pep257 warning that I noticed
in the tests.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented May 6, 2026

I just cherry-picked #543 onto here, since they need to go in together. Now I'm going to run CI again.

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented May 6, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented May 7, 2026

Holding off on this until we figure out the situation in ros2/launch#974 and can backport it.

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented May 7, 2026

Full CI with this PR, ros2/launch#973, and ament/ament_lint#582 all in:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette mentioned this pull request May 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clalancette @ahcorde @mjcarroll