Skip to content

Deprecate memory strategy (backport #3136)#3141

Merged
jmachowinski merged 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-3136
May 5, 2026
Merged

Deprecate memory strategy (backport #3136)#3141
jmachowinski merged 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-3136

Conversation

@mergify

@mergify mergify Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description

Deprecate non used classes.

Is this user-facing behavior change?

Yes, we are deprecating classes.

Did you use Generative AI?

no

This is an automatic backport of pull request #3136 done by Mergify.

@jmachowinski @mjcarroll @mergify
Deprecate memory strategy (#3136)
1117e9d 
* feat: Deprecate AllocatorMemoryStrategy

Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>

* feat: Deprecate MemoryStrategy as well

Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>

* Apply suggestions from code review

Co-authored-by: Michael Carroll <mjcarroll.oss@gmail.com>
Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com>

* chore: Added comments on when to remove

Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>

* Add RCLCPP_PUBLIC to deprecated MemoryStrategy class

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>

---------

Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com>
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Co-authored-by: Janosch Machowinski <j.machowinski@cellumation.com>
Co-authored-by: Michael Carroll <mjcarroll.oss@gmail.com>
(cherry picked from commit 4b6c362)
@mergify mergify Bot mentioned this pull request May 4, 2026
Merged
@jmachowinski

jmachowinski commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Pulls: #3141, ros2/realtime_support#142, ros2/demos#790
Gist: https://gist.githubusercontent.com/jmachowinski/705c11b142eec7522834f0210408f252/raw/4e89c45ec1734fed090aae2d0ccd158b983cfb93/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19121

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced May 4, 2026
Merged
Merged
@jmachowinski

jmachowinski commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Pulls: #3141, ros2/realtime_support#142, ros2/demos#790
Gist: https://gist.githubusercontent.com/jmachowinski/ce1dc4ae0db1b21fc20e569ca60a1643/raw/9e00874fee8d1100cfa6f6b58a8c99a1d40f54f4/ros2.repos
BUILD args:
TEST args:
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19122

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski

jmachowinski commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Pulls: #3141, ros2/realtime_support#142, ros2/demos#790
Gist: https://gist.githubusercontent.com/jmachowinski/cb086d98bed60e486c6b4638ca29e89d/raw/9e00874fee8d1100cfa6f6b58a8c99a1d40f54f4/ros2.repos
BUILD args:
TEST args:
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19124

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski jmachowinski merged commit c586be5 into lyrical May 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jmachowinski