Skip to content

Conversation

@rahatchd
Copy link
Contributor

Description

  • use the context passed in to wait_for_message to construct wait set
    • this lets users use wait_for_message with custom ros context
  • add unit test for custom ros context

Fixes #3020

Is this user-facing behavior change?

  • users are able to use custom ros context with wait_for_message
  • previously users have to use global default context

Did you use Generative AI?

no

Additional Information

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, i think this is inconsistent bug to manage context.

lgtm with green CI.

@fujitatomoya
Copy link
Collaborator

@rahatchd can you fix DCO error?

@fujitatomoya
Copy link
Collaborator

Pulls: #3021
Gist: https://gist.githubusercontent.com/fujitatomoya/bae49577c927add9219975134a799d91/raw/aced9d55325344995a5492734267fe3ea318d8cf/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18005

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit cd86362 into ros2:rolling Jan 21, 2026
1 of 3 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Jan 21, 2026

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2026

backport kilted jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 21, 2026
mergify bot pushed a commit that referenced this pull request Jan 21, 2026
mergify bot pushed a commit that referenced this pull request Jan 21, 2026
mjcarroll added a commit that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wait_for_message uses default ros context instead of passed node's context

3 participants