Qualify ShutdownCallbackHandle in context.cpp#3208
Open
Tobias-Fischer wants to merge 1 commit into
Open
Conversation
This upstreams a RoboStack build fix from patch/ros-rolling-rclcpp.win.patch. Qualifying ShutdownCallbackHandle through the rclcpp namespace avoids dependent-name lookup issues on stricter C++ compilers while keeping the existing callback behavior unchanged. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Author
|
FYI @wep21 @traversaro, this is a small PR from the effort to upstream RoboStack downstream patches tracked in RoboStack/robostack.github.io#16. |
ahcorde
approved these changes
Jul 20, 2026
Contributor
|
Pulls: #3208
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to contribute RoboStack downstream patches back upstream.
This upstreams
patch/ros-rolling-rclcpp.win.patch, authored in RoboStack by wep21<daisuke.nishimatsu1021@gmail.com>.Qualifying
ShutdownCallbackHandlethrough therclcppnamespace avoids dependent-name lookup issues on stricter C++ compilers while keeping the existing callback behavior unchanged.