Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Comments

Add taskcluster yml#768

Merged
bors-servo merged 3 commits intoservo:masterfrom
aneeshusa:add-taskcluster-yml
May 15, 2018
Merged

Add taskcluster yml#768
bors-servo merged 3 commits intoservo:masterfrom
aneeshusa:add-taskcluster-yml

Conversation

@aneeshusa
Copy link
Contributor

@aneeshusa aneeshusa commented Dec 19, 2017

We need newer Docker images to be able to use TC for servo (see servo/servo#19591). Use TC to build these images from the saltfs repository.


This change is Reviewable

@aneeshusa
Copy link
Contributor Author

r? @edunham
We also need to enable the TaskCluster webhook on this repository.
Once we have images building, we'll need to set up scopes so that TC can push the images it builds to a registry somewhere so we can use them.

Use the latest ubuntu:trusty and ubuntu:xenial.
Also, update the Dockerfile so it can be built without any build args,
and add some documentatation about how to do so.
@edunham
Copy link
Contributor

edunham commented May 15, 2018

Waiting till I know enough to be certain this is right has hung it up for embarrassingly long. Let's merge and fix things if it breaks them.

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit ef311bc has been approved by edunham

@bors-servo
Copy link
Contributor

⌛ Testing commit ef311bc with merge 7e7976b...

bors-servo pushed a commit that referenced this pull request May 15, 2018
Add taskcluster yml

We need newer Docker images to be able to use TC for servo (see servo/servo#19591). Use TC to build these images from the saltfs repository.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/768)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: edunham
Pushing 7e7976b to master...

@bors-servo bors-servo merged commit ef311bc into servo:master May 15, 2018
@jdm jdm removed the S-needs-deploy label Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants