Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CPU* structs to Cpu* to conform to Rust's naming convention #617

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 5, 2024

This change is Reviewable

@andrewmilson andrewmilson mentioned this pull request May 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 92.64%. Comparing base (d4372f9) to head (1f8d0e0).

Files Patch % Lines
crates/prover/src/core/poly/circle/secure_poly.rs 0.00% 3 Missing ⚠️
crates/prover/src/core/backend/simd/circle.rs 0.00% 1 Missing ⚠️
crates/prover/src/core/fields/secure_column.rs 50.00% 1 Missing ⚠️
crates/prover/src/core/prover/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #617   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          69       69           
  Lines        8995     8995           
  Branches     8995     8995           
=======================================
  Hits         8333     8333           
  Misses        590      590           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from c8d3597 to d1c03a4 Compare May 6, 2024 19:17
@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from 33f24d0 to 9d234a8 Compare May 11, 2024 00:38
@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from 9d234a8 to 3047e39 Compare May 11, 2024 02:44
@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from 3047e39 to 5ffdadd Compare May 15, 2024 04:35
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why clippy didn't yell about that?
Do we want to assert this naming convention?

Reviewed 37 of 37 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from 5ffdadd to d7f433c Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from d7f433c to 21913db Compare May 16, 2024 03:56
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from 21913db to 3ec8d07 Compare May 16, 2024 15:25
@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from 3ec8d07 to fa4089a Compare May 16, 2024 16:47
@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from fa4089a to 81c9507 Compare May 19, 2024 14:35
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

Base automatically changed from 05-04-Remove_AVX_backend to dev May 20, 2024 14:49
@andrewmilson andrewmilson force-pushed the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch from 81c9507 to 1f8d0e0 Compare May 20, 2024 14:51
@andrewmilson andrewmilson merged commit 8d16c06 into dev May 20, 2024
25 of 26 checks passed
@andrewmilson andrewmilson deleted the 05-04-Rename_CPU_structs_to_Cpu_to_conform_to_Rust_s_naming_convention branch May 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants