Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to test Wasm simd128, avx2 and aarch64 neon #614

Merged

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 4, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (2f84421) to head (4631456).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #614   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          84       84           
  Lines       11909    11909           
  Branches    11909    11909           
=======================================
  Hits        11125    11125           
  Misses        702      702           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch from d9657d9 to 0713b9f Compare May 11, 2024 02:44
@andrewmilson andrewmilson force-pushed the 05-02-Fix_CirclePointIndex_bug_in_debug_mode_for_32-bit_archs branch from 279a980 to e6948f4 Compare May 15, 2024 04:35
@andrewmilson andrewmilson force-pushed the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch from 0713b9f to 9e6727f Compare May 15, 2024 04:35
@andrewmilson andrewmilson force-pushed the 05-02-Fix_CirclePointIndex_bug_in_debug_mode_for_32-bit_archs branch from e6948f4 to d98f633 Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch from 9e6727f to 5dd85bc Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Fix_CirclePointIndex_bug_in_debug_mode_for_32-bit_archs branch from d98f633 to dbbd950 Compare May 16, 2024 03:56
@andrewmilson andrewmilson force-pushed the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch from 5dd85bc to 0d904e8 Compare May 16, 2024 03:56
Copy link
Collaborator

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @andrewmilson)


.github/workflows/ci.yaml line 52 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

It can. The way I thought about doing it with matrix required so many ifs (for wasmtime, env variable, rustc flags) I figured it was much clearer just to have a seperate job. WDYT?

Then maybe just unite neon and avx to a matrix?

Copy link
Collaborator

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @andrewmilson)

@andrewmilson andrewmilson force-pushed the 05-02-Fix_CirclePointIndex_bug_in_debug_mode_for_32-bit_archs branch from dbbd950 to 05762bd Compare May 16, 2024 15:25
@andrewmilson andrewmilson force-pushed the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch from 0d904e8 to af77ce3 Compare May 16, 2024 15:25
@andrewmilson andrewmilson force-pushed the 05-02-Fix_CirclePointIndex_bug_in_debug_mode_for_32-bit_archs branch from 05762bd to 7e1ac4e Compare May 16, 2024 16:47
@andrewmilson andrewmilson force-pushed the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch from af77ce3 to 3377384 Compare May 16, 2024 16:47
@andrewmilson andrewmilson force-pushed the 05-02-Fix_CirclePointIndex_bug_in_debug_mode_for_32-bit_archs branch from 7e1ac4e to 6e736a5 Compare May 19, 2024 14:34
@andrewmilson andrewmilson force-pushed the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch from 3377384 to 30ac630 Compare May 19, 2024 14:34
@andrewmilson andrewmilson force-pushed the 05-02-Fix_CirclePointIndex_bug_in_debug_mode_for_32-bit_archs branch from 6e736a5 to f070d14 Compare May 19, 2024 14:40
Copy link
Contributor

@alon-dotan-starkware alon-dotan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

Copy link
Contributor

@alon-dotan-starkware alon-dotan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)

Base automatically changed from 05-02-Fix_CirclePointIndex_bug_in_debug_mode_for_32-bit_archs to dev May 20, 2024 14:00
@andrewmilson andrewmilson force-pushed the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch from 30ac630 to 4631456 Compare May 20, 2024 14:00
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


.github/workflows/ci.yaml line 52 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Then maybe just unite neon and avx to a matrix?

AFAICT also requires ifs. I think it's more maintainable having separate jobs

@andrewmilson andrewmilson merged commit bbeb3be into dev May 20, 2024
25 of 26 checks passed
@andrewmilson andrewmilson deleted the 05-04-Update_CI_to_test_Wasm_simd128_avx2_and_aarch64_neon branch May 20, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants