-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to test Wasm simd128, avx2 and aarch64 neon #614
Update CI to test Wasm simd128, avx2 and aarch64 neon #614
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #614 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 84 84
Lines 11909 11909
Branches 11909 11909
=======================================
Hits 11125 11125
Misses 702 702
Partials 82 82 ☔ View full report in Codecov by Sentry. |
c67fd63
to
aceec97
Compare
d9657d9
to
0713b9f
Compare
279a980
to
e6948f4
Compare
0713b9f
to
9e6727f
Compare
e6948f4
to
d98f633
Compare
9e6727f
to
5dd85bc
Compare
d98f633
to
dbbd950
Compare
5dd85bc
to
0d904e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @andrewmilson)
.github/workflows/ci.yaml
line 52 at r1 (raw file):
Previously, andrewmilson (Andrew Milson) wrote…
It can. The way I thought about doing it with matrix required so many
if
s (for wasmtime, env variable, rustc flags) I figured it was much clearer just to have a seperate job. WDYT?
Then maybe just unite neon and avx to a matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-dotan-starkware and @andrewmilson)
dbbd950
to
05762bd
Compare
0d904e8
to
af77ce3
Compare
05762bd
to
7e1ac4e
Compare
af77ce3
to
3377384
Compare
7e1ac4e
to
6e736a5
Compare
3377384
to
30ac630
Compare
6e736a5
to
f070d14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
30ac630
to
4631456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
.github/workflows/ci.yaml
line 52 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Then maybe just unite neon and avx to a matrix?
AFAICT also requires if
s. I think it's more maintainable having separate jobs
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)