Add benchmarks for SIMD merkle

[andrewmilson]

This change is 

[andrewmilson]

• Add eval order and interpolate to SecureEvaluation #794
• Add MLE eval constraints #742
• Add eq evals constraints #741
• Add benchmarks for GKR lookups #673
• Implement LogupOps for SIMD backend #641
• Implement GrandProductOps for SIMD backend #640
• Implement GkrOps for SIMD backend #630
• Implement MleOps for SIMD backend #629
• Add GKR implementation of Logup lookups #623
• Add GKR implementation of Grand Product lookups #620
• Implement GkrOps for CPU backend #621
• Add batch GKR prover and verifier #581
• Rename CPU* structs to Cpu* to conform to Rust's naming convention #617
• Remove AVX backend #616
• Convert wide_fibbonacci AVX backend example to SIMD backend #615
• Update CI to test Wasm simd128, avx2 and aarch64 neon #614
• Fix CirclePointIndex bug in debug mode for 32-bit archs #613
• Change opt-level in benchmarks script #612
• Add benchmarks for SIMD m31 #611
• Add benchmarks for SIMD merkle #610 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andrewmilson and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (70e1b37) to head (87eafcb).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #610   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          84       84           
  Lines       11909    11909           
  Branches    11909    11909           
=======================================
  Hits        11125    11125           
  Misses        702      702           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[spapinistarkware]

simd merkle benchmarks seems slower than avx.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

[andrewmilson]

Fixed

Reviewable status: 0 of 2 files reviewed, all discussions resolved

[shaharsamocha7]

Nice

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson)

---

crates/prover/benches/merkle.rs line 22 at r2 (raw file):

    let mut group = c.benchmark_group("merkle throughput");
    group.throughput(Throughput::Elements(1 << (LOG_N_COLS + LOG_N_ROWS)));
    group.throughput(Throughput::Bytes(4 << (LOG_N_COLS + LOG_N_ROWS)));

I think that we have n_bytes_per_felt const.

Code quote:

4

---

crates/prover/src/core/backend/simd/blake2s.rs line 114 at r2 (raw file):

// `inline(always)` can cause code parsing errors for wasm: "locals exceed maximum".
#[cfg_attr(not(target_arch = "wasm32"), inline(always))]

Can you separate this change from the benchmark pr?

Code quote:

// `inline(always)` can cause code parsing errors for wasm: "locals exceed maximum".
#[cfg_attr(not(target_arch = "wasm32"), inline(always))]

[andrewmilson]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

crates/prover/src/core/backend/simd/blake2s.rs line 114 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Can you separate this change from the benchmark pr?

https://reviewable.io/reviews/starkware-libs/stwo/635