Fix CirclePointIndex bug in debug mode for 32-bit archs

[andrewmilson]

This change is 

[andrewmilson]

• Add benchmarks for GKR lookups #673
• Implement LogupOps for SIMD backend #641
• Implement GrandProductOps for SIMD backend #640
• Implement GkrOps for SIMD backend #630
• Implement MleOps for SIMD backend #629
• Add GKR implementation of Logup lookups #623
• Add GKR implementation of Grand Product lookups #620
• Implement GkrOps for CPU backend #621
• Add batch GKR prover and verifier #581
• Rename CPU* structs to Cpu* to conform to Rust's naming convention #617
• Remove AVX backend #616
• Convert wide_fibbonacci AVX backend example to SIMD backend #615
• Update CI to test Wasm simd128, avx2 and aarch64 neon #614
• Fix CirclePointIndex bug in debug mode for 32-bit archs #613 👈
• Change opt-level in benchmarks script #612
• Add benchmarks for SIMD m31 #611
• Add benchmarks for SIMD merkle #610
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andrewmilson and the rest of your teammates on Graphite

[andrewmilson]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion

---

crates/prover/src/core/circle.rs line 272 at r1 (raw file):

    fn mul(self, rhs: usize) -> Self::Output {
        Self(self.0.wrapping_mul(rhs)).reduce()

Test examples::fibonacci::tests::test_mixed_degree_multi_fibonacci caused an overflow here.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (403c45c) to head (f070d14).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #613   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          84       84           
  Lines       11909    11909           
  Branches    11909    11909           
=======================================
  Hits        11125    11125           
  Misses        702      702           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @andrewmilson)

---

crates/prover/src/core/circle.rs line 256 at r1 (raw file):

    fn add(self, rhs: Self) -> Self::Output {
        Self(self.0 + rhs.0).reduce()

Do we need also wrapping_add here?

Code quote:

self.0 + rhs.0

---

crates/prover/src/core/circle.rs line 272 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

Test examples::fibonacci::tests::test_mixed_degree_multi_fibonacci caused an overflow here.

how it didn't overflow up until now?

[andrewmilson]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @shaharsamocha7)

---

crates/prover/src/core/circle.rs line 256 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Do we need also wrapping_add here?

We don't because all values are in the range [0, 2^31]

---

crates/prover/src/core/circle.rs line 272 at r1 (raw file):

Previously, shaharsamocha7 wrote…

how it didn't overflow up until now?

Because it's usize. All the platforms we had currently tested on where 64 bit. Since we now test Wasm (tests added to CI in the next PR) which is 32 bit it caused overflow

[shaharsamocha7]

Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[andrewmilson]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/prover/src/core/circle.rs line 256 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

We don't because all values are in the range [0, 2^31]

*[0, 2^31)