Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change opt-level in benchmarks script #612

Merged
merged 1 commit into from
May 19, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 3, 2024

This change is Reviewable

@andrewmilson andrewmilson changed the title Change in benchmarks script Change opt-level in benchmarks script May 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (94f93cc) to head (6c233c2).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           05-02-Add_benchmarks_for_SIMD_m31     #612   +/-   ##
==================================================================
  Coverage                              93.41%   93.41%           
==================================================================
  Files                                     84       84           
  Lines                                  11909    11909           
  Branches                               11909    11909           
==================================================================
  Hits                                   11125    11125           
  Misses                                   702      702           
  Partials                                  82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


scripts/bench.sh line 5 at r1 (raw file):

# For example, `./scripts/bench.sh` will run all benchmarks.
# or `./scripts/bench.sh M31` will run only the M31 benchmarks.
RUSTFLAGS="-Awarnings -C target-cpu=native -C target-feature=+avx512f -C opt-level=3" cargo bench $@

On my AVX512 AWS machine this improved benchmark performance for all backends.

@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from 49ad150 to fea500d Compare May 8, 2024 15:46
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from a67bd58 to 6472874 Compare May 8, 2024 15:46
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from fea500d to 0119989 Compare May 11, 2024 00:37
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from 6472874 to a553947 Compare May 11, 2024 00:37
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from 0119989 to 2e5dacb Compare May 11, 2024 02:43
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from a553947 to d96abee Compare May 11, 2024 02:43
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from 2e5dacb to f822266 Compare May 15, 2024 04:35
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from d96abee to 79d4eb3 Compare May 15, 2024 04:35
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from f822266 to dc620dd Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from 79d4eb3 to 99939af Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from dc620dd to a4fa5c7 Compare May 16, 2024 03:56
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from 99939af to 793628e Compare May 16, 2024 03:56
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from a4fa5c7 to 94f93cc Compare May 16, 2024 15:24
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from 793628e to 6c233c2 Compare May 16, 2024 15:24
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from 94f93cc to 2c3d55a Compare May 16, 2024 16:47
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from 6c233c2 to 1ad5eef Compare May 16, 2024 16:47
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_m31 branch from 2c3d55a to b0d3d1a Compare May 19, 2024 14:24
Base automatically changed from 05-02-Add_benchmarks_for_SIMD_m31 to dev May 19, 2024 14:33
@andrewmilson andrewmilson force-pushed the 05-02-Change_in_benchmarks_script branch from 1ad5eef to 86303f4 Compare May 19, 2024 14:34
@andrewmilson andrewmilson merged commit 403c45c into dev May 19, 2024
11 of 12 checks passed
@andrewmilson andrewmilson deleted the 05-02-Change_in_benchmarks_script branch May 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants