Promote cmd/clioptions to top-level clioptions/#370
Closed
lilydoar wants to merge 1 commit into
Closed
Conversation
clioptions is the most-imported package in the repo (used across both the root module and the workers/go module), but it lived under cmd/, which by convention is reserved for main packages (binary entry points). Move it to a top-level clioptions/ and rewrite the import path accordingly. Testing: `go build ./...` and `go vet ./...` pass for both the root and workers/go modules. stack-info: PR: #370, branch: lilydoar/stack/4
lilydoar
force-pushed
the
lilydoar/stack/4
branch
from
cbc2b74 to
a38ccec
Compare
This was referenced May 28, 2026
lilydoar
added a commit
that referenced
this pull request
May 29, 2026
clioptions is the most-imported package in the repo (used across both the root module and the workers/go module), but it lived under cmd/, which by convention is reserved for main packages (binary entry points). Move it to a top-level clioptions/ and rewrite the import path accordingly. Testing: `go build ./...` and `go vet ./...` pass for both the root and workers/go modules. stack-info: PR: #370, branch: lilydoar/stack/4
Contributor
Author
|
Closing — the module-organization stack was rebased (devserver move dropped, since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Promote cmd/clioptions to top-level clioptions/
clioptions is the most-imported package in the repo (used across both the
root module and the workers/go module), but it lived under cmd/, which by
convention is reserved for main packages (binary entry points). Move it to
a top-level clioptions/ and rewrite the import path accordingly.
Testing:
go build ./...andgo vet ./...pass for both the root andworkers/go modules.